Page MenuHomeFreeBSD

kern: switch various devfs_notify() callers to devfs_notifyf()
Needs ReviewPublic

Authored by kevans on Mar 9 2022, 5:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 3, 8:57 PM
Unknown Object (File)
Sun, Apr 27, 2:29 AM
Unknown Object (File)
Sat, Apr 26, 7:16 PM
Unknown Object (File)
Mar 22 2025, 5:31 AM
Unknown Object (File)
Mar 7 2025, 7:17 PM
Unknown Object (File)
Jan 21 2025, 6:03 PM
Unknown Object (File)
Jan 18 2025, 10:21 AM
Unknown Object (File)
Nov 30 2024, 11:10 AM

Details

Summary

This is largely a simplification, avoiding extra allocations or string
manipulations where it's safe to do so (i.e., doesn't require extra
quoting).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63974
Build 60858: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Mar 9 2022, 5:25 AM
kevans added a parent revision: D34504: kern: add devctl_notifyf().

I just noticed there's a devctl_notify(9) to update.

sys/dev/asmc/asmc.c
1478

I assumed the space here is insignificant and just gets absorbed as consecutive whitespace...

I wish we had a way to validate that things were safe, though...
Maybe I'll add it after you commit this.

sys/dev/asmc/asmc.c
1478

correct.

This revision is now accepted and ready to land.Mar 9 2022, 5:58 PM

Rebase and hit a few more devctl_notify() callers

vtterm_devctl(), in particular, becomes significantly less complicated as the
complexity of the operation moves into devctl_notifyf (where it would need to
allocate another sbuf, etc., even before devctl_notifyf was introduced).

This revision now requires review to proceed.Wed, May 7, 1:39 AM