Page MenuHomeFreeBSD
Differential D34505

kern: switch various devfs_notify() callers to devfs_notifyf()
AcceptedPublic
Actions

Authored by kevans on Mar 9 2022, 5:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 22 2024, 6:42 AM
Unknown Object (File)
Dec 24 2023, 1:43 PM
Unknown Object (File)
Dec 20 2023, 5:35 AM
Unknown Object (File)
Nov 23 2023, 1:13 PM
Unknown Object (File)
Nov 6 2023, 8:11 PM
Unknown Object (File)
Nov 1 2023, 9:44 PM
Unknown Object (File)
Sep 15 2023, 3:01 PM
Unknown Object (File)
Aug 18 2023, 3:09 PM
View All 10 Files
Subscribers
ae
andrew
glebius
jhibbits
melifaro

Details

Reviewers
imp
Summary

This is largely a simplification, avoiding extra allocations or string
manipulations where it's safe to do so (i.e., doesn't require extra
quoting).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44719
Build 41607: arc lint + arc unit

Event Timeline

kevans created this revision.Mar 9 2022, 5:25 AM
Herald added subscribers: glebius, melifaro, ae and 2 others. · View Herald TranscriptMar 9 2022, 5:25 AM
kevans requested review of this revision.Mar 9 2022, 5:25 AM
kevans added a parent revision: D34504: kern: add devctl_notifyf().
Harbormaster completed remote builds in B44719: Diff 103671.Mar 9 2022, 5:25 AM
kevans added a comment.Mar 9 2022, 5:26 AM

I just noticed there's a devctl_notify(9) to update.

sys/dev/asmc/asmc.c
1358

I assumed the space here is insignificant and just gets absorbed as consecutive whitespace...

imp accepted this revision.Mar 9 2022, 5:58 PM

I wish we had a way to validate that things were safe, though...
Maybe I'll add it after you commit this.

sys/dev/asmc/asmc.c
1358

correct.

This revision is now accepted and ready to land.Mar 9 2022, 5:58 PM

Revision Contents
Changeset List

PathSize
sys/
arm/
ti/
am335x/
4 lines
dev/
acpica/
5 lines
asmc/
4 lines
usb/
13 lines
geom/
29 lines
4 lines
kern/
13 lines
net/
6 lines
powerpc/
powermac/
6 lines

Diff 103671

View Options

sys/arm/ti/am335x/am335x_pmic.c

Loading...
View Options

sys/dev/acpica/acpi.c

Loading...
View Options

sys/dev/asmc/asmc.c

Loading...
View Options

sys/dev/usb/usb_device.c

Loading...
View Options

sys/geom/geom_dev.c

Loading...
View Options

sys/geom/geom_disk.c

Loading...
View Options

sys/kern/kern_conf.c

Loading...
View Options

sys/net/if.c

Loading...
View Options

sys/powerpc/powermac/pmu.c

Loading...