Page MenuHomeFreeBSD

kern: switch various devfs_notify() callers to devfs_notifyf()
Needs ReviewPublic

Authored by kevans on Mar 9 2022, 5:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 12, 9:55 AM
Unknown Object (File)
Thu, Jul 10, 1:42 AM
Unknown Object (File)
Wed, Jul 9, 3:16 PM
Unknown Object (File)
Mon, Jul 7, 12:58 AM
Unknown Object (File)
Sun, Jul 6, 12:42 PM
Unknown Object (File)
Sat, Jul 5, 3:10 PM
Unknown Object (File)
Mon, Jun 30, 5:32 AM
Unknown Object (File)
Wed, Jun 25, 6:38 AM

Details

Summary

This is largely a simplification, avoiding extra allocations or string
manipulations where it's safe to do so (i.e., doesn't require extra
quoting).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44719
Build 41607: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Mar 9 2022, 5:25 AM
kevans added a parent revision: D34504: kern: add devctl_notifyf().

I just noticed there's a devctl_notify(9) to update.

sys/dev/asmc/asmc.c
1358

I assumed the space here is insignificant and just gets absorbed as consecutive whitespace...

I wish we had a way to validate that things were safe, though...
Maybe I'll add it after you commit this.

sys/dev/asmc/asmc.c
1358

correct.

This revision is now accepted and ready to land.Mar 9 2022, 5:58 PM

Rebase and hit a few more devctl_notify() callers

vtterm_devctl(), in particular, becomes significantly less complicated as the
complexity of the operation moves into devctl_notifyf (where it would need to
allocate another sbuf, etc., even before devctl_notifyf was introduced).

This revision now requires review to proceed.May 7 2025, 1:39 AM