- User Since
- May 6 2018, 1:20 PM (187 w, 3 d)
Mon, Dec 6
Sat, Dec 4
Fri, Dec 3
Thu, Dec 2
Thu, Nov 25
Tue, Nov 16
Fri, Nov 12
Nov 1 2021
Oct 28 2021
Oct 25 2021
Oct 20 2021
Oct 19 2021
Oct 11 2021
Oct 10 2021
Oct 7 2021
LGTM but let's wait until @ygy reviews.
Oct 6 2021
Oct 2 2021
Oct 1 2021
Sep 30 2021
Committed, thanks for the patience!
Sep 29 2021
Approved, go ahead. Don't forget to do MFH after pushing to main branch.
Thank you both. I learned a new thing.
- Take maintainership
I see. Regarding PORTEPOCH, it makes sense to keep it.
Hmm, it appears to be OK. Sorry for the noise.
Changes are LGTM. However, I think push will be rejected author of the commit is different from committer.
Sep 28 2021
Almost fine but don't forget to add 'Submitted by:' line. Go ahead after adding the line.
Don't forget to add clamav-lts port to security/Makefile.
Can you add one more commit to change copied port to the actual LTS port?
LGTM now. I would like to request peer review by ygy. Go ahead if ygy approved.
Since D25019 has been reopened, I abandon this.
I have already approved this. Feel free to commit with commit message Approved by: meta (maintainer).
Include Submitted by: line. Following two are popular format.
- Submitted by: yasu (myself)
- Submitted by: myself
Not bad but I would write commit message like this:
Now ports tree requires a commit message that begins with */*;.
Sep 27 2021
Update commit message.
This is a practice to learn how to use Phabricator with git ports tree. I'm mentoring a new committer and would like to use Phabricator in mentor-mentee review. So approving this by myself.
Sep 26 2021
Sep 25 2021
This is a test how to use phabricator with git.
Sep 24 2021
Differential Revision should be full URL.