Fix file descriptor and memory leaks in libdpv
Needs ReviewPublic
Actions

Authored by dteske on Jun 8 2016, 10:00 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 14, 11:03 PM

	Unknown Object (File)
	Thu, May 14, 9:14 PM

	Unknown Object (File)
	Wed, May 13, 11:58 PM

	Unknown Object (File)
	Tue, May 12, 7:33 AM

	Unknown Object (File)
	Thu, Apr 30, 2:13 PM

	Unknown Object (File)
	Sat, Apr 25, 7:06 AM

	Unknown Object (File)
	Apr 22 2026, 9:03 PM

	Unknown Object (File)
	Apr 22 2026, 8:24 PM

View All Files

Subscribers

imp

Details

Reviewers

truckman

Summary

Close /dev/tty in tty_maxsize_update() if we open it
in the !isatty(fd) case to avoid leaking the descriptor.
Verify that we were actually able to open /dev/tty.

Don't leak a file descriptor and a process in x11_maxsize_update()
if fgets() fails.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4147
Build 4190: arc lint + arc unit

Event Timeline

truckman updated this revision to Diff 17402.Jun 8 2016, 10:00 AM

truckman retitled this revision from to Fix file descriptor and memory leaks in libdpv.

truckman updated this object.

truckman edited the test plan for this revision. (Show Details)

truckman added a reviewer: dteske.

Herald added a subscriber: imp. · View Herald TranscriptJun 8 2016, 10:00 AM

Take

I've only a couple changes I'll make before committing with reference to OP. Instead of "doclose" I will use "opened" which makes the code easier to read.

That sounds reasonable to me.

Sorry for the delay, had a disk failure take out my operations for a full 4 weeks, but finally got all the data recovered and back up and running

Revision Contents
Changeset List

Path

Size

lib/

libdpv/

dialog_util.c

16 lines

Diff 17402

View Options

Fix file descriptor and memory leaks in libdpvNeeds ReviewPublicActions