- User Since
- Jun 5 2014, 6:17 AM (189 w, 1 d)
Tue, Jan 2
is there a formatted version of this available somewhere so it can be read in final form?
Dec 5 2017
Nov 10 2017
Have applied this patch at $JOB now to stable/10
Oct 30 2017
what are the chances of this improvement making it into stable/10?
Oct 20 2017
really minor things only.. don't get discouraged..
Oct 5 2017
Sep 30 2017
Sep 15 2017
I've applied these changes to 10.3 and will give them a run..
Sep 14 2017
so there are bits of this missing if you are (like us) trying to make this work in stable/10 or stable/11 because Isilon have already aommitted parts of it..
like change 313475 for example..
I need to merge that into our 10 based code until I can use this..
Sep 12 2017
Aug 19 2017
Very glad to see this. at $JOB we create an appliance and we have ami, azure and vmware versions and I can predict that google-compute is on the Horizon (actually it's already prototyped).
so I'm sure I will get to know and love (?) this port .. :-)
Aug 16 2017
so, like is this getting committed some time?
May 4 2017
DOn't see issues in this code but see other comment
Apr 6 2017
Who;s going to commit?
any doc change required?
Mar 16 2017
note that this was committed
Mar 10 2017
just an idea for sometime
we are going to run out of available tricks for this in ipfw at some stage.. Can we re-use () like used in table? or make the : part of the keep-state.. so that "keep_state: state1" or keep_state(state1) vs "keep_state :state1"
just my $0.02
will work on this this a bit more this weekend
Mar 7 2017
p.s. I'm still considering line 266/267 in ln.c which came with the original patch, but I have not totally understood yet..
Bapt has convinced me to add these functions to libutil instead of keeping them in libpathconv as they originally came.
The Pathconvert package has been incorporated over the years into many projects.
The simplest way to see how to use this is to imagine how difficult it can be sometimes to generate relative symlinks when installing packages or generated binaries when the source and destination are not fixed relative to each other but expressed as two absolute paths. This becomes trivial by adding the -r option and specifying the available absolute paths. I originally started checking this in as libpathconv, before Bapt got to m. I will remove that at the same time I add this.
Feb 9 2017
I think that "collision" is ok.
so what change did pkelsey request? I can't see any request to change anything.
who is this mysterious group reviewer "transport"? And where is their negative review? I only see gnn's
my only comment is that I ask you to just confirm that a listening socket can not collide with the socket we are allocating.
i don't think it does, but I may have missed something
As long as features are DISABLED and not removed (e.g. at $JOB we need MD2) then ok.
I think we should make two versions of this port: openssl and openssl-insecure, which has features like sslv2 and MD2 enabled for people who need that functionality. (e.g. for talking to old machines or handling old certificates etc.)
maybe with a different .so number. (just an idea).
Jan 27 2017
Jan 22 2017
as far as I can see it looks good. Same default value as before..
Considering how much work went into writing this and the fact that we had to get it approved by verizon (or whatever they were called at the time) its amazing that I remember almost nothing about how it works.
Jan 20 2017
we should probably skip ports that have a listenig socket on them.. do we?
Jan 19 2017
looks good to me. Hit this in 10.3
Jan 4 2017
this is obviously part of a bigger change, so I can't comment on that part but the part about the EXTRA_PATCH_TREE looks like it should work.
I don't see why one would have a compressed patch file but handling it shouldn't hurt. (except by hiding bugs through added complexity.)
Dec 27 2016
Dec 22 2016
Dec 2 2016
Nov 24 2016
I vaguely remember another superio driver for another model/maker super io chip
Nov 23 2016
Nov 15 2016
Nov 10 2016
looks reasonable, but am unsure of all the possible cases for *end given garbage input
Nov 3 2016
I'd still vote for using rcvif if a new field is out of the question.
Oct 12 2016
Oct 10 2016
Oct 7 2016
Oct 5 2016
Sep 24 2016
Aug 14 2016
This shoudn't be needed.. it should be panic condition if item is NULL.
Aug 1 2016
Jul 27 2016
Jul 25 2016
Jul 14 2016
Jun 20 2016
ok so I see the points of both of you.. hmm that doesn't sound very english.. let's try again..
Jun 13 2016
seems ok from the quick look I gave it
We've needed this feature for a long time.
Mar 18 2016
Jan 29 2016
some pointers to references on hardware pacing and how it works might be useful.
this can already be done using dummy net.. Just set a tag/flag on the socket so that ipfw can identify it.
Jan 25 2016
looks about right but I'm not current with all the internal functions. I also want more eyes, but I like it generally.
Dec 27 2015
Dec 5 2015
just a nit
Oct 26 2015
My only comment is that if you have a simple enough test.. i.e. "are there any policies (regardless of direction) then I'd go for guarding the callers rather that returning immediately.. in other words don't even do the call.
amd64 may have very cheap function calls but they still cause register spills etc. some other processors may cost more..
Aug 24 2015
Aug 5 2015
If you are going to replace a file, then you need to have a big banner in that file saying
"this file will be replaced automaitcally on upgrade. Do not edit it.
Please put any local changes in /boot/rc.loader.local"
Jul 29 2015
AS I said before, I can see a use of much of this but I think I would still settle for a version of "keep-state" that sets the state without checking it (except to look for duplicates). If you are being blocked by the nefarious melifaro then maybe a subset that just implements "set-state" would surfice. .
Jul 24 2015
probably ok but could do with an example or better comments
Jun 29 2015
Jun 22 2015
Jun 17 2015
I don't mind if people leave them out but I do prefer to see them in, especially if there are other clauses. This is true in if, for, while, etc.... gratuitously removing them makes the single line clauses not match the multiple line clauses in style.
I really hate if-elseif-elseif-elseif-else chains where some clauses have them, and some do not.