julian (JulianElischer)
User

Projects

User Details

User Since
Jun 5 2014, 6:17 AM (189 w, 1 d)

Recent Activity

Tue, Jan 2

julian added a comment to D12921: Three New Chapter for Porters Handbook.

is there a formatted version of this available somewhere so it can be read in final form?

Tue, Jan 2, 6:16 AM

Dec 5 2017

julian committed rS326568: Steps to Reproduce:.
Steps to Reproduce:
Dec 5 2017, 2:46 PM

Nov 10 2017

julian added a comment to D12330: "Long" filename support changes.

Have applied this patch at $JOB now to stable/10

Nov 10 2017, 8:41 AM

Oct 30 2017

julian added a comment to D12685: Make ipfw dynamic states lockless on fast path.

what are the chances of this improvement making it into stable/10?

Oct 30 2017, 2:35 PM

Oct 20 2017

julian requested changes to D12685: Make ipfw dynamic states lockless on fast path.

really minor things only.. don't get discouraged..

Oct 20 2017, 8:00 AM

Oct 5 2017

julian accepted D12545: sysctl-s in a module should be accessible only when the module is initialized.
Oct 5 2017, 4:05 AM

Sep 30 2017

julian accepted D12545: sysctl-s in a module should be accessible only when the module is initialized.
Sep 30 2017, 6:45 PM
julian added a comment to D12545: sysctl-s in a module should be accessible only when the module is initialized.
Sep 30 2017, 6:44 PM

Sep 15 2017

julian added a comment to D12330: "Long" filename support changes.

I've applied these changes to 10.3 and will give them a run..

Sep 15 2017, 6:33 PM

Sep 14 2017

julian added a comment to D12330: "Long" filename support changes.

so there are bits of this missing if you are (like us) trying to make this work in stable/10 or stable/11 because Isilon have already aommitted parts of it..
like change 313475 for example..
I need to merge that into our 10 based code until I can use this..

Sep 14 2017, 5:47 PM

Sep 12 2017

julian added a comment to D12330: "Long" filename support changes.
In D12330#255757, @cem wrote:

It seems that ZFS (which we don't use) has some ABI dependency on these constants via zfs_cmd, and this change breaks a CTASSERT on line 202 of zfs_ioctl.c. For some reason passing 3 MAXPATHLENs and 1 MAXNAMELEN via ioctl is too much. Someone would need to figure out how to fix ZFS to use this patch.

Sep 12 2017, 5:10 PM

Aug 19 2017

julian added a comment to D12077: [NEW PORT] sysutils/google-compute-engine: User daemon for Google Compute Engine.

Very glad to see this. at $JOB we create an appliance and we have ami, azure and vmware versions and I can predict that google-compute is on the Horizon (actually it's already prototyped).
so I'm sure I will get to know and love (?) this port .. :-)

Aug 19 2017, 7:09 AM

Aug 16 2017

julian added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.
In D10006#206784, @gnn wrote:

New, BSD license, code does not need to be in cddl. Most of the new D scripts and programs go into either share/dtrace or the DTrace Toolkit port. Since this is a script I'd put it into share/dtrace if you want it in the src tree.

Aug 16 2017, 3:22 PM
julian added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

so, like is this getting committed some time?

Aug 16 2017, 3:18 PM

May 4 2017

julian accepted D10591: zfsboot: drvsize() may be unusable on some systems.

DOn't see issues in this code but see other comment

May 4 2017, 3:32 AM

Apr 6 2017

julian accepted D9848: Fix MPD5 PPPoE support on vlans and add basic parsing of PADM messages.

looks ok.
Who;s going to commit?
any doc change required?

Apr 6 2017, 2:30 PM

Mar 16 2017

julian added a comment to D2596: NFSv4 server tunable hash table sizing.

note that this was committed

Mar 16 2017, 5:11 AM

Mar 10 2017

julian added a comment to D9932: Prefer ${SRCTOP}/foo over ${.CURDIR}/../../foo and ${SRCTOP}/usr.bin/foo over ${.CURDIR}/../foo for paths in Makefiles..
In D9932#205427, @imp wrote:

just my $0.02

Nice two cents. Not going to do it since it is beyond the scope of this work, but it is a nice idea down the road. Similar to libnames.mk, it would make things better. But there's a lot of them in the tree, so that's outside the scope.

just an idea for sometime
Mar 10 2017, 4:32 AM
julian added a comment to D9929: Change the syntax of ipfw named states.

we are going to run out of available tricks for this in ipfw at some stage.. Can we re-use () like used in table? or make the : part of the keep-state.. so that "keep_state: state1" or keep_state(state1) vs "keep_state :state1"

Mar 10 2017, 2:59 AM
julian added a comment to D9932: Prefer ${SRCTOP}/foo over ${.CURDIR}/../../foo and ${SRCTOP}/usr.bin/foo over ${.CURDIR}/../foo for paths in Makefiles..

just my $0.02

Mar 10 2017, 2:52 AM
julian added a comment to D9917: Add abs2rel and rel2abs to libutil and use them in ln to provide the -a and -r options.

will work on this this a bit more this weekend

Mar 10 2017, 2:22 AM
julian accepted D9933: Increase WARNS for selected tests.
Mar 10 2017, 2:21 AM

Mar 7 2017

julian added a comment to D9917: Add abs2rel and rel2abs to libutil and use them in ln to provide the -a and -r options.

First off in the unix philosophy /we also be adding a relname in the spirit of
basename and dirname that calls this library so that any shell script or
Makefile, etc could easily add this functionality?

Mar 7 2017, 8:15 AM
julian added a comment to D9917: Add abs2rel and rel2abs to libutil and use them in ln to provide the -a and -r options.

p.s. I'm still considering line 266/267 in ln.c which came with the original patch, but I have not totally understood yet..

Mar 7 2017, 6:49 AM
julian added a comment to D9917: Add abs2rel and rel2abs to libutil and use them in ln to provide the -a and -r options.

Bapt has convinced me to add these functions to libutil instead of keeping them in libpathconv as they originally came.
The Pathconvert package has been incorporated over the years into many projects.
The simplest way to see how to use this is to imagine how difficult it can be sometimes to generate relative symlinks when installing packages or generated binaries when the source and destination are not fixed relative to each other but expressed as two absolute paths. This becomes trivial by adding the -r option and specifying the available absolute paths. I originally started checking this in as libpathconv, before Bapt got to m. I will remove that at the same time I add this.

Mar 7 2017, 6:46 AM
julian retitled D9917: Add abs2rel and rel2abs to libutil and use them in ln to provide the -a and -r options from to Add abs2rel and rel2abs to libutil and use them in ln to provide the -a and -r options.
Mar 7 2017, 6:33 AM

Feb 9 2017

julian added a comment to D5017: More than 65K connection from single application.

I think that "collision" is ok.

Feb 9 2017, 5:48 PM · network
julian added a comment to D5017: More than 65K connection from single application.

This is the source comment that should have been submitted with my 'request for change' action, had I pressed the buttons in a way that didn't dispose of it instead.

Feb 9 2017, 5:25 PM · network
julian added a comment to D5017: More than 65K connection from single application.

so what change did pkelsey request? I can't see any request to change anything.

Feb 9 2017, 5:23 PM · network
julian added a comment to D5017: More than 65K connection from single application.

who is this mysterious group reviewer "transport"? And where is their negative review? I only see gnn's

Feb 9 2017, 7:59 AM · network
julian accepted D5017: More than 65K connection from single application.

my only comment is that I ask you to just confirm that a listening socket can not collide with the socket we are allocating.
i don't think it does, but I may have missed something

Feb 9 2017, 7:57 AM · network
julian added a comment to D9480: security/openssl: Enable ASM by default.

As long as features are DISABLED and not removed (e.g. at $JOB we need MD2) then ok.
I think we should make two versions of this port: openssl and openssl-insecure, which has features like sslv2 and MD2 enabled for people who need that functionality. (e.g. for talking to old machines or handling old certificates etc.)
maybe with a different .so number. (just an idea).

Feb 9 2017, 4:25 AM

Jan 27 2017

julian committed rS312871: MFH: r308671.
MFH: r308671
Jan 27 2017, 9:12 AM
julian committed rS312870: MFH: r310426.
MFH: r310426
Jan 27 2017, 9:07 AM
julian committed rS312869: MFH: r308671.
MFH: r308671
Jan 27 2017, 9:04 AM

Jan 22 2017

julian accepted D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

as far as I can see it looks good. Same default value as before..

Jan 22 2017, 12:19 PM
julian added a comment to D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

Considering how much work went into writing this and the fact that we had to get it approved by verizon (or whatever they were called at the time) its amazing that I remember almost nothing about how it works.

Jan 22 2017, 11:38 AM

Jan 20 2017

julian added a comment to D5017: More than 65K connection from single application.

we should probably skip ports that have a listenig socket on them.. do we?

Jan 20 2017, 3:02 PM · network

Jan 19 2017

julian accepted D9233: don't abort writing of a core dump after EFAULT.

looks good to me. Hit this in 10.3

Jan 19 2017, 3:42 AM

Jan 4 2017

julian added a comment to D9029: Extract do-patch into a separate script..

this is obviously part of a bigger change, so I can't comment on that part but the part about the EXTRA_PATCH_TREE looks like it should work.
I don't see why one would have a compressed patch file but handling it shouldn't hurt. (except by hiding bugs through added complexity.)

Jan 4 2017, 8:15 PM

Dec 27 2016

julian committed rS310626: MFH: r309407.
MFH: r309407
Dec 27 2016, 8:33 AM
julian committed rS310625: MFH: r309408.
MFH: r309408
Dec 27 2016, 8:31 AM

Dec 22 2016

julian committed rS310426: If you are going to be run individually to make a new timezone set.
If you are going to be run individually to make a new timezone set
Dec 22 2016, 6:30 PM

Dec 2 2016

julian committed rS309408: Changes to allow the patching of packets with an offset (and other changes...
Changes to allow the patching of packets with an offset (and other changes..
Dec 2 2016, 10:47 AM
julian committed rS309407: A little light wordsmithing only..
A little light wordsmithing only.
Dec 2 2016, 9:51 AM
julian committed rS309402: MFH: r309295.
MFH: r309295
Dec 2 2016, 8:24 AM
julian committed rS309401: MFH: r309295.
MFH: r309295
Dec 2 2016, 8:21 AM
julian committed rS309399: MFH: r307917.
MFH: r307917
Dec 2 2016, 8:16 AM
julian committed rS309398: MFH: r306554.
MFH: r306554
Dec 2 2016, 8:13 AM
julian committed rS309396: MFH: r297015.
MFH: r297015
Dec 2 2016, 6:28 AM
julian committed rS309395: MFH: r297012.
MFH: r297012
Dec 2 2016, 6:27 AM
julian committed rS309391: MFH: r303287.
MFH: r303287
Dec 2 2016, 5:47 AM
julian committed rS309390: MFH: r303611.
MFH: r303611
Dec 2 2016, 5:43 AM
julian committed rS309389: MFH: r303611.
MFH: r303611
Dec 2 2016, 5:42 AM
julian committed rS309388: MFH: r303613.
MFH: r303613
Dec 2 2016, 5:39 AM
julian committed rS309387: MFH: r303612.
MFH: r303612
Dec 2 2016, 5:38 AM
julian committed rS309386: MFH: r303613.
MFH: r303613
Dec 2 2016, 5:37 AM
julian committed rS309385: MFH: r303612.
MFH: r303612
Dec 2 2016, 5:36 AM
julian committed rS309384: MFH: r306306.
MFH: r306306
Dec 2 2016, 5:25 AM
julian committed rS309383: MFH: r306306.
MFH: r306306
Dec 2 2016, 5:25 AM

Nov 24 2016

julian added a comment to D8175: add superio driver.

I vaguely remember another superio driver for another model/maker super io chip

Nov 24 2016, 6:02 PM

Nov 23 2016

julian committed rS309035: This little BSD licensed library has been kicking around for years..
This little BSD licensed library has been kicking around for years.
Nov 23 2016, 7:58 AM

Nov 15 2016

julian committed rS308671: When you select make OLDTIMEZONES=1 then you need a few added directories.
When you select make OLDTIMEZONES=1 then you need a few added directories
Nov 15 2016, 6:38 AM

Nov 10 2016

julian accepted D8491: libstand: verify value provided by nfs.read_size.

looks reasonable, but am unsure of all the possible cases for *end given garbage input

Nov 10 2016, 2:32 PM

Nov 3 2016

julian added a comment to D3687: Implement kernel support for hardware rate limited sockets.

I'd still vote for using rcvif if a new field is out of the question.

Nov 3 2016, 8:35 AM

Oct 12 2016

julian accepted D7465: Make warning configurable for obsolete per-jail configuration.

shipit

Oct 12 2016, 8:46 PM

Oct 10 2016

julian committed rS306935: While the thread is sleeping in taskqueue_drain_all() it is.
While the thread is sleeping in taskqueue_drain_all() it is
Oct 10 2016, 4:57 AM
julian closed D8160: Fix potential use-after free in taskqueue_drain_all by committing rS306935: While the thread is sleeping in taskqueue_drain_all() it is.
Oct 10 2016, 4:57 AM
julian added a comment to D8160: Fix potential use-after free in taskqueue_drain_all.
Oct 10 2016, 4:42 AM

Oct 7 2016

julian committed rS306824: MFH: r259647.
MFH: r259647
Oct 7 2016, 7:29 PM

Oct 5 2016

julian retitled D8160: Fix potential use-after free in taskqueue_drain_all from to Fix potential use-after free in taskqueue_drain_all.
Oct 5 2016, 11:52 PM

Sep 24 2016

julian committed rS306306: Give the user a clue as to which process hit maxfiles..
Give the user a clue as to which process hit maxfiles.
Sep 24 2016, 10:56 PM

Aug 14 2016

julian added a comment to D7209: [Bug 211031] [panic] in ng_uncallout when argument is NULL.

This shoudn't be needed.. it should be panic condition if item is NULL.

Aug 14 2016, 2:23 PM

Aug 1 2016

julian committed rS303613: Man page for the new checksum netgraph module..
Man page for the new checksum netgraph module.
Aug 1 2016, 12:14 PM
julian committed rS303612: netgraph module for reconstructing checksums.
netgraph module for reconstructing checksums
Aug 1 2016, 12:09 PM
julian committed rS303611: slite style changes. There is an incoming patch that rewrites a.
slite style changes. There is an incoming patch that rewrites a
Aug 1 2016, 11:34 AM

Jul 27 2016

julian committed rS303395: MFH: r303287.
MFH: r303287
Jul 27 2016, 4:28 PM

Jul 25 2016

julian committed rS303287: Split MAKE_SYSENT into two parts so that the initializer part can be.
Split MAKE_SYSENT into two parts so that the initializer part can be
Jul 25 2016, 8:14 AM

Jul 14 2016

julian committed rS302800: MFH: r297023.
MFH: r297023
Jul 14 2016, 4:30 AM

Jun 20 2016

julian added a comment to D1776: New options for ipfw - record-state, set-limit and skip-immediate-action - for simpler rulesets.

ok so I see the points of both of you.. hmm that doesn't sound very english.. let's try again..

Jun 20 2016, 11:02 AM

Jun 13 2016

julian accepted D6674: Add named dynamic states support..

seems ok from the quick look I gave it
We've needed this feature for a long time.

Jun 13 2016, 2:49 PM

Mar 18 2016

julian committed rS297023: Add the ability to print out ht emodule specific information in likely formats..
Add the ability to print out ht emodule specific information in likely formats.
Mar 18 2016, 2:49 PM
julian committed rS297015: Change a little to match what appears to be the right way of specifying an….
Change a little to match what appears to be the right way of specifying an…
Mar 18 2016, 9:18 AM
julian committed rS297013: Use the right argumant name.
Use the right argumant name
Mar 18 2016, 8:47 AM
julian committed rS297012: Add a few details that make it easier to use this macro..
Add a few details that make it easier to use this macro.
Mar 18 2016, 7:59 AM

Jan 29 2016

julian added a comment to D3687: Implement kernel support for hardware rate limited sockets.

some pointers to references on hardware pacing and how it works might be useful.

Jan 29 2016, 4:48 AM
julian added a comment to D3687: Implement kernel support for hardware rate limited sockets.

this can already be done using dummy net.. Just set a tag/flag on the socket so that ipfw can identify it.

Jan 29 2016, 4:36 AM

Jan 25 2016

julian added a comment to D5017: More than 65K connection from single application.

looks about right but I'm not current with all the internal functions. I also want more eyes, but I like it generally.

Jan 25 2016, 4:32 PM · network
julian added a comment to D5017: More than 65K connection from single application.
In D5017#106574, @gnn wrote:

I'm a bit confused by this proposal. No protocol I know of has a port field larger than 16 bits. How and where might this be applied?

Jan 25 2016, 4:21 PM · network

Dec 27 2015

julian committed rS292770: MFH: r278640.
MFH: r278640
Dec 27 2015, 1:37 PM

Dec 5 2015

julian added a comment to D4384: style.9: Add a small blurb about preferring bool to older types.

just a nit

Dec 5 2015, 1:47 AM

Oct 26 2015

julian added a comment to D3993: Optimize the case where we have IPSEC enabled but do not have security policies..

My only comment is that if you have a simple enough test.. i.e. "are there any policies (regardless of direction) then I'd go for guarding the callers rather that returning immediately.. in other words don't even do the call.
amd64 may have very cheap function calls but they still cause register spills etc. some other processors may cost more..

Oct 26 2015, 3:54 PM

Aug 24 2015

julian committed rS287091: MFH: r284691.
MFH: r284691
Aug 24 2015, 3:51 AM
julian committed rS287090: MFH: r273762.
MFH: r273762
Aug 24 2015, 3:41 AM

Aug 5 2015

julian added a comment to D3176: remove guards around installing loader.rc and menu.rc.

If you are going to replace a file, then you need to have a big banner in that file saying
"this file will be replaced automaitcally on upgrade. Do not edit it.
Please put any local changes in /boot/rc.loader.local"

Aug 5 2015, 3:40 PM

Jul 29 2015

julian added a comment to D1776: New options for ipfw - record-state, set-limit and skip-immediate-action - for simpler rulesets.

AS I said before, I can see a use of much of this but I think I would still settle for a version of "keep-state" that sets the state without checking it (except to look for duplicates). If you are being blocked by the nefarious melifaro then maybe a subset that just implements "set-state" would surfice. .

Jul 29 2015, 5:49 AM

Jul 24 2015

julian added a comment to D3181: Teach sysctl about the new optional suffix after IK to specify precision. Update input as well. Add IK to the manual (it was missing completely)..

probably ok but could do with an example or better comments

Jul 24 2015, 6:56 AM

Jun 29 2015

julian committed rS284920: Slight tidy up of comments before MFC.
Slight tidy up of comments before MFC
Jun 29 2015, 7:43 AM

Jun 22 2015

julian committed rS284691: remove 16 rules and replace by 2 by using a table.
remove 16 rules and replace by 2 by using a table
Jun 22 2015, 4:25 AM

Jun 17 2015

julian accepted D2842: Update style.9 to reflect consensus on developer's mailing list..

I don't mind if people leave them out but I do prefer to see them in, especially if there are other clauses. This is true in if, for, while, etc.... gratuitously removing them makes the single line clauses not match the multiple line clauses in style.
I really hate if-elseif-elseif-elseif-else chains where some clauses have them, and some do not.

Jun 17 2015, 3:53 AM