Page MenuHomeFreeBSD
Differential D9848

Fix MPD5 PPPoE support on vlans and add basic parsing of PADM messages
ClosedPublic
Actions

Authored by ale on Mar 1 2017, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 8:17 PM
Unknown Object (File)
Nov 30 2024, 5:15 AM
Unknown Object (File)
Nov 29 2024, 2:50 PM
Unknown Object (File)
Nov 24 2024, 8:23 PM
Unknown Object (File)
Nov 21 2024, 1:49 AM
Unknown Object (File)
Nov 16 2024, 7:53 AM
Unknown Object (File)
Oct 7 2024, 1:03 PM
Unknown Object (File)
Sep 13 2024, 12:24 AM
View All 89 Files
Subscribers
eugen_grosbein.net
garga
julian
mat

Details

Reviewers
mav
julian
Commits
rP463007: Fix support of PPPoE over VLAN and add basic parsing of PADM messages.
Summary

The netgraph node paths cannot contain '.' and ':' characters, so the ng_ether module sanitizes interface names containing them (like the new format for vlans, eg. fxp0.1) by replacing illegal characters with underscores. This patch keeps interface name and netgraph path separated in the pppoe layer so that mpd can be used successfully on vlan interfaces.

iface = fxp0.1
path = fxp0_1:

Moreover I've added basic support to display PADM messages, introduced by the following patch: https://reviews.freebsd.org/D9270

Test Plan

I've setup pppoe connections on vlans and used ngctl to test the PADM messages.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ale updated this revision to Diff 25850.Mar 1 2017, 10:49 PM
ale retitled this revision from to Fix MPD5 PPPoE support on vlans and add basic parsing of PADM messages.
ale updated this object.
ale edited the test plan for this revision. (Show Details)
ale added a reviewer: mav.
ale set the repository for this revision to rP FreeBSD ports repository.
ale added a subscriber: julian.
Herald added a subscriber: mat. · View Herald TranscriptMar 1 2017, 10:49 PM
mav accepted this revision.Mar 2 2017, 5:50 AM
mav edited edge metadata.

I have no objections.

This revision is now accepted and ready to land.Mar 2 2017, 5:50 AM
ale added a comment.Apr 4 2017, 8:48 PM

Do you plan the apply the patch upstream and release a new version or may I apply it directly to the ports tree?

julian accepted this revision.Apr 6 2017, 2:30 PM

looks ok.
Who;s going to commit?
any doc change required?

ale added a comment.Apr 6 2017, 3:53 PM

No need to change documentation IMO, the manual already states that you have to specify the ethernet interface name:

set pppoe iface interface-name

Set the name of the Ethernet interface to use. PPPoE does not affect normal use of the interface.
garga added a subscriber: garga.Oct 21 2017, 4:04 PM
ale added a subscriber: eugen_grosbein.net.Feb 14 2018, 10:04 PM

Hey @eugen_grosbein.net since you are the new maintainer of the mpd5 port can you commit also this patch, please? Thanks

Closed by commit rP463007: Fix support of PPPoE over VLAN and add basic parsing of PADM messages. (authored by ale). · Explain WhyFeb 26 2018, 9:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
net/
mpd5/
2 lines
files/
126 lines

Diff 39739

View Options

head/net/mpd5/Makefile

Loading...
View Options

head/net/mpd5/files/patch-src_pppoe.c

Loading...