Page MenuHomeFreeBSD

Change the syntax of ipfw named states
AbandonedPublic

Authored by ae on Mar 9 2017, 8:41 AM.

Details

Reviewers
julian
Group Reviewers
manpages
Summary

I'm going to merge ipfw changes from head/ to stable/11 and thus I decided to change the syntax that we use for named states.
To avoid ambiguity I prefixed the state name with a colon.

Diff Detail

Event Timeline

ae created this revision.Mar 9 2017, 8:41 AM
julian edited edge metadata.Mar 10 2017, 2:59 AM

we are going to run out of available tricks for this in ipfw at some stage.. Can we re-use () like used in table? or make the : part of the keep-state.. so that "keep_state: state1" or keep_state(state1) vs "keep_state :state1"

ae added a comment.Mar 10 2017, 7:00 AM

we are going to run out of available tricks for this in ipfw at some stage.. Can we re-use () like used in table? or make the : part of the keep-state.. so that "keep_state: state1" or keep_state(state1) vs "keep_state :state1"

In general we have no preference about the syntax. But inventing the similar syntax for "limit" rules seems not so obvious. Also I don't see how such trick can prevent to use it later for another opcode.

ae added a comment.Mar 13 2017, 4:31 PM

Julian, if you have no objection I'll commit it tomorrow.

ae abandoned this revision.Mar 16 2017, 11:59 AM

Committed in r315305.