I'm going to merge ipfw changes from head/ to stable/11 and thus I decided to change the syntax that we use for named states.
To avoid ambiguity I prefixed the state name with a colon.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 7957 Build 8104: CI src build Jenkins Build 8103: arc lint + arc unit
Event Timeline
Comment Actions
we are going to run out of available tricks for this in ipfw at some stage.. Can we re-use () like used in table? or make the : part of the keep-state.. so that "keep_state: state1" or keep_state(state1) vs "keep_state :state1"
Comment Actions
In general we have no preference about the syntax. But inventing the similar syntax for "limit" rules seems not so obvious. Also I don't see how such trick can prevent to use it later for another opcode.