Increase WARNS for selected tests
ATF tests have a default WARNS of 0, unlike other usermode programs.
This change increases WARNS to the highest level that each test
directory can tolerate.
ngie | |
julian |
Increase WARNS for selected tests
ATF tests have a default WARNS of 0, unlike other usermode programs.
This change increases WARNS to the highest level that each test
directory can tolerate.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
First off, thank you very much for doing this. It's been on my TODO list for a bit (just further down the stack).
A few questions:
Also:
Thank you so very much again :):):)!
lib/libpathconv/tests/Makefile | ||
---|---|---|
9 ↗ | (On Diff #26100) | This isn't currently hooked into the build. Please check with Julian about it, since he owns this directory/tests. |
Not yet; I opened the code review in parallel with build testing. But I'm definitely going to do a full universe on this one.
Also:
- could you please move this down the WARNS assignment above the first set of .includes?
What?
- could you please commit this changes and MFC them separately?
Certainly.
Thank you so very much again :):):)!
Per style.Makefile(5), WARNS should come before CFLAGS/CXXFLAGS (I misremembered that nuance too so I'm guilty of getting it wrong, probably). Not a ship blocker, but if we can nip this in the bud now, that would be awesome :)... (Either way, I'm ok with the change as-is, because it's a net win :)..)!
- could you please commit this changes and MFC them separately?
Certainly.
Thank you so very much again :):):)!