The bandwidth calculation that was saved into the hostcache was removed by r211315, and r212765 marked it unused in tcp_info as it was found conflicting with the new modular congestion control. Clean up the remnants of this in the hostcache.
- Group Reviewers
- rS292087: Clean up unused bandwidth entry in the TCP hostcache.
This has been tested on production boxes within Limelight.
Looks good to me.
Only thing I am not sure about is if we want to keep struct size unchanged and also keep a spare field where we removed the bandwidth field in struct hc_metrics and hc_metrics_lite. On a second thought, I can't think of anything that I'd want to add to hostcache at this point so might as well remove them. And as I understand, MFC is not planned for this.
It'd be great if someone else can also review the change.
Thank you, Jason.
that's what we are doing (just adding the fields back locally..
The estimator is, unfortunately, a bit crude for public consumption, or I'd commit it.
Contact me privately if you (anyone) needs a per-peer bandwidth estimation feature.