Page MenuHomeFreeBSD

Extract do-patch into a separate script.
ClosedPublic

Authored by mat on Jan 3 2017, 2:17 PM.

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP431680: Extract do-patch into a separate script.
Summary

Implement EXTRA_PATCH_TREE. (idea from the PR)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat updated this revision to Diff 23572.Jan 3 2017, 2:17 PM
mat retitled this revision from to Extract do-patch into a separate script. Implement EXTRA_PATCH_TREE. (idea from the PR).
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: portmgr.
mat added subscribers: bapt, julian.
julian added a comment.Jan 4 2017, 8:14 PM

this is obviously part of a bigger change, so I can't comment on that part but the part about the EXTRA_PATCH_TREE looks like it should work.
I don't see why one would have a compressed patch file but handling it shouldn't hurt. (except by hiding bugs through added complexity.)

mat updated this revision to Diff 23878.Jan 11 2017, 2:26 PM
mat retitled this revision from Extract do-patch into a separate script. Implement EXTRA_PATCH_TREE. (idea from the PR) to Extract do-patch into a separate script..
mat updated this object.
  • Fixup EXTRA_PATCHES missing the :-pX argument.
  • Implement EXTRA_PATCH_TREE. (idea from the PR)
  • Remove PATCH_WRKSRC from PATCH_ARGS.
  • Don't go through apply_one_patch for local files.
mat updated this revision to Diff 23879.Jan 11 2017, 3:06 PM
  • Use the framework correctly.
  • "Fix" ports using PATCH_ARGS to patch things manually (???)
This revision was automatically updated to reflect the committed changes.