Add the core netdump client code.
ClosedPublic
Actions

Authored by markj on May 1 2018, 5:22 PM.

Details

Reviewers

sbruno
julian

Group Reviewers

Doc Committers
manpages

Commits

rS333283: Import the netdump client code.

Summary

The netdump client creates a /dev/netdump. A couple of ioctls are used
by dumpon(8) to configure netdump as the dump device. At panic time,
netdump hooks the if_input function of the interface so that it can poll
for received packets.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 1 2018, 5:22 PM

Herald added a subscriber: ae. · View Herald TranscriptMay 1 2018, 5:22 PM

Harbormaster completed remote builds in B16376: Diff 42040.May 1 2018, 5:22 PM

sbruno accepted this revision.May 1 2018, 8:46 PM

sbruno added a reviewer: Doc Committers.

This revision is now accepted and ready to land.May 1 2018, 8:47 PM

emaste added a subscriber: emaste.May 2 2018, 12:13 AM

emaste added inline comments.

sys/netinet/netdump/netdump.h
3 ↗	(On Diff #42040)	We ought to check if this email address is valid.

julian accepted this revision.May 2 2018, 6:13 AM

julian added a subscriber: julian.

julian added inline comments.

share/man/man4/netdump.4
3 ↗	(On Diff #42040)	according to rumour this line isn't needed any more.. ask warner
sys/netinet/netdump/netdump_client.c
833 ↗	(On Diff #42040)	probably..

shurd added a subscriber: shurd.May 2 2018, 8:12 PM

markj added inline comments.May 2 2018, 8:38 PM

sys/netinet/netdump/netdump.h
3 ↗	(On Diff #42040)	I emailed a quick note to the author at that address. It hasn't bounced back yet, so we'll see if he replies.

markj added inline comments.May 2 2018, 8:45 PM

sys/netinet/netdump/netdump.h
3 ↗	(On Diff #42040)	It ended up bouncing. I'll just remove the address.

markj marked 2 inline comments as done.May 4 2018, 7:30 PM

Remove "all rights reserved" text.
Check the dst MAC address on inbound packets.
Remove Darrell Anderson's email address from the copyright, the address bounces.

This revision now requires review to proceed.May 4 2018, 7:52 PM

Harbormaster completed remote builds in B16435: Diff 42154.May 4 2018, 7:52 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 6 2018, 12:38 AM

Closed by commit rS333283: Import the netdump client code. (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: manpages. · View Herald TranscriptMay 6 2018, 12:38 AM

Herald added a subscriber: imp. · View Herald Transcript