Page MenuHomeFreeBSD

darius-dons.net.au (Daniel O'Connor)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2015, 2:52 AM (466 w, 6 h)

Recent Activity

Nov 22 2023

darius-dons.net.au added inline comments to D42718: lockf: allow locking file descriptors.
Nov 22 2023, 10:43 AM

Jul 19 2023

darius-dons.net.au added inline comments to D41063: libsysdecode: add zfs iocs.
Jul 19 2023, 8:05 AM
darius-dons.net.au added inline comments to D41063: libsysdecode: add zfs iocs.
Jul 19 2023, 6:54 AM

Mar 4 2023

darius-dons.net.au updated the diff for D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.

This time for sure!

Mar 4 2023, 6:47 AM
darius-dons.net.au updated the diff for D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.
Mar 4 2023, 1:33 AM
darius-dons.net.au updated the diff for D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.

Fix whitespace.

Mar 4 2023, 1:24 AM

Feb 28 2023

darius-dons.net.au updated the diff for D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.
Feb 28 2023, 3:34 AM
darius-dons.net.au requested review of D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.
Feb 28 2023, 3:16 AM

Oct 7 2022

darius-dons.net.au added a comment to D36903: pf: apply the network stack's ICMP rate limiting to ICMP errors sent by pf.

That looks simple and good.

Oct 7 2022, 11:14 PM

Sep 14 2022

darius-dons.net.au added inline comments to D36550: i386: Make boot loader smaller by reducing size of bootinfo.
Sep 14 2022, 12:44 AM

May 17 2021

darius-dons.net.au added a comment to D30309: md5: Create md5sum, etc compatible programs.

I think there should be some updates to the man page to note the links and that they are for (limited) Linux compatibility.

May 17 2021, 6:01 AM

Jan 26 2020

darius-dons.net.au added a comment to D20969: Add option to set umask before starting child process.

I wrote two versions of a patch for limits. The first adds a '-M' option which when specified will set the umask on the command line or read the login class value (if -C is specified and no argument was used for -M). The second adds no option but sets the umask is -C is used.

I wrote the first one first but then realised it doesn't actually help my problem unless I modify rc.subr to pass -M to limits.

Anyone have a preference?

I think the second one is probably right but it's arguably a POLA violation.

Jan 26 2020, 6:21 AM

Jan 17 2020

darius-dons.net.au added a comment to D20969: Add option to set umask before starting child process.

Definitely a generic way of achieving this would be nice, and it looks like you can set umask with a login class - to be honest if I had known about the "${name}_login_class" before now I would have used that rather than writing this patch.

You can set umask with a login class but not all ways to apply a login class set it; logins and init's daemon login class do but rc.subr's ${name}_login_class currently does not.

So I don't like ${name}_umask since that may block off fixing ${name}_login_class to apply the umask. However, you may consider using the functions from login_class(3) in daemon.

Jan 17 2020, 4:18 AM

Sep 9 2019

darius-dons.net.au accepted D21563: Make timehands count selectable at boottime..

Looks good to me, tested on a Beaglebone black (I applied it to 41a4c010326cd697d92141076bab53c424edb56f)

Sep 9 2019, 12:47 AM

Aug 21 2019

darius-dons.net.au added a comment to D2844: Bail out of corrupt directory entries during boot.

Any progress on getting this done?

Aug 21 2019, 1:31 PM

Jul 23 2019

darius-dons.net.au added a comment to D20969: Add option to set umask before starting child process.

You can set umask with a login class but not all ways to apply a login class set it; logins and init's daemon login class do but rc.subr's ${name}_login_class currently does not.

Jul 23 2019, 2:16 AM

Jul 18 2019

darius-dons.net.au added a comment to D20983: Sort & dedupe getopt flags for daemon.

Now this includes parts of D20969 😕

The core of this change -- sort and de-dupe getopt() and sort the cases -- is fine. Please try again with just that part, and leave the rest as part of D20969 as intended.

Jul 18 2019, 11:42 PM
darius-dons.net.au added a comment to D20969: Add option to set umask before starting child process.

Perhaps it will be more generically useful to add a ${name}_umask variable to rc.subr instead.

Ideally this would go via a login class but the ${name}_login_class variable is already used for "rlimits from this login class".

Jul 18 2019, 10:47 PM
darius-dons.net.au added a comment to D2844: Bail out of corrupt directory entries during boot.
  • Update for head
  • Apply the same fix to ufs.c
Jul 18 2019, 7:18 AM
Herald added a reviewer for D20983: Sort & dedupe getopt flags for daemon: manpages.

Sorry for the noise, I can't drive Git..

Jul 18 2019, 6:26 AM
darius-dons.net.au added a comment to D20969: Add option to set umask before starting child process.

Sorry for the noise, I can't drive Git..

Jul 18 2019, 6:25 AM
darius-dons.net.au added inline comments to D20969: Add option to set umask before starting child process.
Jul 18 2019, 6:23 AM
darius-dons.net.au added a comment to D20969: Add option to set umask before starting child process.

Changed umask parsing to octal.

Jul 18 2019, 6:22 AM
D20969: Add option to set umask before starting child process now requires review to proceed.
Jul 18 2019, 6:19 AM
darius-dons.net.au updated the diff for D20983: Sort & dedupe getopt flags for daemon.
Jul 18 2019, 6:18 AM
darius-dons.net.au created D20983: Sort & dedupe getopt flags for daemon.
Jul 18 2019, 4:04 AM
darius-dons.net.au added reviewers for D20969: Add option to set umask before starting child process: cem, ian.
Jul 18 2019, 2:36 AM

Jul 16 2019

darius-dons.net.au created D20969: Add option to set umask before starting child process.
Jul 16 2019, 1:45 PM

Nov 8 2018

darius-dons.net.au accepted D17906: rm(1): Formalize non-functional status of -P flag.

LGTM although I wonder about adding a warning if it's used.

Nov 8 2018, 9:30 AM

Oct 24 2018

darius-dons.net.au accepted D17678: dumpon(8): Provide seatbelt against weak RSA keys.

Ship it!

Oct 24 2018, 2:44 AM

Aug 23 2018

darius-dons.net.au created D16876: Expand min/max_offset macros in vm_map.h to reduce pollution.
Aug 23 2018, 11:43 PM

Nov 15 2017

darius-dons.net.au added a comment to D13101: Add support for Zstd-compressed kernel and userspace dumps.

Any chance of zstdio_*(9) man pages? (even a stub would be useful IMO)

Nov 15 2017, 11:36 PM

Oct 30 2017

darius-dons.net.au accepted D12831: bluetooth: Default to discoverable off.

Shipit

Oct 30 2017, 4:35 AM

May 22 2017

darius-dons.net.au accepted D10851: Include rrsync with net/rsync.

lgtm

May 22 2017, 2:11 AM

May 8 2017

darius-dons.net.au accepted D10640: Improve resizewin(1) man page..
May 8 2017, 10:57 AM

May 7 2017

darius-dons.net.au accepted D10637: Add resizewin -z..
May 7 2017, 11:12 PM
darius-dons.net.au accepted D10624: Improve resizewin(1)..
May 7 2017, 5:49 AM
darius-dons.net.au added inline comments to D10624: Improve resizewin(1)..
May 7 2017, 5:49 AM

May 18 2016

darius-dons.net.au added a comment to D4112: Import Isilon port of VMWare PV SCSI driver.

I have this driver working in a VMWare Fusion host, but it's using INTx interrupts instead of MSIx. Fusion gives no knobs for controlling any of this (I had to take a guess at how to get it to create a pvscsi device), any idea on how I can tell it to enable MSI/MSIx?

May 18 2016, 11:32 PM
darius-dons.net.au added a comment to D4112: Import Isilon port of VMWare PV SCSI driver.

Unfortunately I'm no longer working at Isilon so I'm not in a position to push this along any further :(

May 18 2016, 11:30 PM

May 3 2016

darius-dons.net.au added inline comments to D4907: Track mbuf owner.
May 3 2016, 10:14 PM

Mar 17 2016

darius-dons.net.au updated the diff for D4438: Add small tool to query terminal for window size.

More man page tweaks.

Mar 17 2016, 12:49 AM

Mar 16 2016

darius-dons.net.au added inline comments to D4438: Add small tool to query terminal for window size.
Mar 16 2016, 10:35 PM
darius-dons.net.au updated the diff for D4438: Add small tool to query terminal for window size.

Update man page based on feedback.

Mar 16 2016, 10:32 PM

Jan 14 2016

darius-dons.net.au accepted D4929: [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl.
Jan 14 2016, 2:45 AM

Jan 13 2016

darius-dons.net.au retitled D4907: Track mbuf owner from to Track mbuf owner.
Jan 13 2016, 4:36 AM

Dec 9 2015

darius-dons.net.au added a comment to D4438: Add small tool to query terminal for window size.
In D4438#93765, @cem wrote:

Hm, isn't this surprising? Isn't the default SIGINT handler "Exit immediately?"

If we get a Terminate Program signal mid-run, do we leave the terminal in a usable state (echo, cursor in the right place, etc)?

Dec 9 2015, 3:10 AM
darius-dons.net.au added a comment to D4438: Add small tool to query terminal for window size.
In D4438#93753, @kan wrote:

What happens if user ^Cs the program while it loops?

Pretty sure read gets EINTR and it exits.

Dec 9 2015, 12:23 AM

Dec 8 2015

darius-dons.net.au retitled D4438: Add small tool to query terminal for window size from to Add small tool to query terminal for window size.
Dec 8 2015, 1:41 PM

Nov 19 2015

darius-dons.net.au added a comment to D4198: Fix callout at high tick rates.
In D4198#88461, @kmacy wrote:

I'm not sure what the right solution, but I wanted to point out that callout_reset does _not_ take an int. All the callout_reset functions are macros around callout_reset_sbt_on which takes a sbintime_t, which is in fact 64-bit.

Nov 19 2015, 4:35 AM

Nov 18 2015

darius-dons.net.au added a comment to D4198: Fix callout at high tick rates.
Nov 18 2015, 10:14 AM
darius-dons.net.au added a comment to D4198: Fix callout at high tick rates.
In D4198#88277, @smh wrote:

Looks like ND6_RECALC_REACHTM_INTERVAL is used to set nd6_recalc_reachtm_interval, which in turn sets recalctm both of which are int's.

Nov 18 2015, 4:46 AM
darius-dons.net.au retitled D4198: Fix callout at high tick rates from to Fix callout at high tick rates.
Nov 18 2015, 12:57 AM

Nov 9 2015

darius-dons.net.au added a comment to D4112: Import Isilon port of VMWare PV SCSI driver.
In D4112#86515, @cem wrote:

pvscsi0: retval>6, msix_vecs_needed>1
pvscsi0: Using INTx interrupts

Any idea why it didn't succeed (ENXIO) in using MSI-X interrupts?

Nov 9 2015, 11:51 PM
darius-dons.net.au updated the diff for D4112: Import Isilon port of VMWare PV SCSI driver.

Spell ISILON correctly and fix a typo.

Nov 9 2015, 9:26 AM
darius-dons.net.au retitled D4112: Import Isilon port of VMWare PV SCSI driver from to Import Isilon port of VMWare PV SCSI driver.
Nov 9 2015, 6:02 AM

Jul 29 2015

darius-dons.net.au accepted D3225: Make Broadcom XLR use shared ds1374 RTC driver.
Jul 29 2015, 1:23 AM

Jul 21 2015

darius-dons.net.au added inline comments to D2956: 1 wire stuff: basics and temperature.
Jul 21 2015, 5:20 AM

Jul 15 2015

darius-dons.net.au accepted D3084: add option to invert data set so you can convert seconds into per seconds...
Jul 15 2015, 12:27 AM

Jul 13 2015

darius-dons.net.au accepted D3063: Set a mountpoint on the root of the pool so user-created datasets have a mountpoint to inherit.
Jul 13 2015, 1:36 AM
darius-dons.net.au accepted D3062: Make the zfsboot part of bsdinstall align partitions to 4k/1m when the option is enabled.
Jul 13 2015, 1:35 AM

Jun 19 2015

darius-dons.net.au accepted D2852: Fix bug 200942 - Don't squash fts_children errors.

LGTM

Jun 19 2015, 9:58 PM

Jun 16 2015

darius-dons.net.au added a comment to D2844: Bail out of corrupt directory entries during boot.

In our case we would fail to find a file on this drive and then fail over to another one, fsck would fix the directory after boot.

Jun 16 2015, 11:19 PM
darius-dons.net.au retitled D2844: Bail out of corrupt directory entries during boot from to Bail out of corrupt directory entries during boot.
Jun 16 2015, 11:10 PM

Apr 23 2015

darius-dons.net.au added a reviewer for D2351: Handle truncation while processing a file: security.
Apr 23 2015, 3:06 AM
darius-dons.net.au retitled D2351: Handle truncation while processing a file from to Handle truncation while processing a file.
Apr 23 2015, 3:05 AM