netgraph/ng_bridge: Handle send errors during loop processing
ClosedPublic
Actions

Authored by donner on Apr 27 2021, 7:58 AM.

Details

Reviewers

None

Group Reviewers

Commits

rG1165cafa0bae: netgraph/ng_bridge: Handle send errors during loop handling
rGe240dd0d502e: netgraph/ng_bridge: Handle send errors during loop handling
rGa56e5ad69030: netgraph/ng_bridge: Handle send errors during loop handling

Summary

If sending out a packet fails during the loop over all links, the
allocated memory is leaked and not all links receive a copy. This
patch fixes those problems, clarifies a premature abort of the loop,
and fixes a minory style(9) bug.

PR: 255430
MFC: 1 week
Submitted by: Dancho Penev

Test Plan

Build a bridge over a bunch of ng_eiface(4). Set one of the
interfaces down (causing the error), try to send out a broadcast
packet and monitor all the interfaces.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

donner created this revision.Apr 27 2021, 7:58 AM

Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptApr 27 2021, 7:58 AM

donner requested review of this revision.Apr 27 2021, 7:58 AM

Harbormaster completed remote builds in B38885: Diff 88243.Apr 27 2021, 7:58 AM

Free packet if not send at all.

Harbormaster completed remote builds in B38888: Diff 88246.Apr 27 2021, 8:05 AM

donner added a reviewer: network.Apr 27 2021, 8:18 AM

donner retitled this revision from netgraph/ng_bridge: Handle send errors during loop handling to netgraph/ng_bridge: Handle send errors during loop processing.Apr 27 2021, 11:11 AM

donner edited the summary of this revision. (Show Details)

julian added a subscriber: julian.May 1 2021, 12:30 PM

julian added inline comments.

sys/netgraph/ng_bridge.c
667	I would do: if error ( error stuff; return error} followed by the non error case continuing on with one level less indent. just a style thing.. result is the same