Page MenuHomeFreeBSD

freebsd-update(8): Add -j flag to support jails
Needs ReviewPublic

Authored by kfv_irbug.org on Jul 18 2020, 12:24 AM.

Details

Summary

Make freebsd-update(8) support jails by adding the -j flag which takes jail jid or name as an argument. This requires and depends on D25705 since it uses freebsd-version -j jail to get the version of the installed userland.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 35354
Build 32280: arc lint + arc unit

Event Timeline

bcr requested changes to this revision.Jul 18 2020, 9:38 AM
bcr added a subscriber: bcr.
bcr added inline comments.
usr.sbin/freebsd-update/freebsd-update.8
98

s/the/The/

100

The sentence stop is missing here.

This revision now requires changes to proceed.Jul 18 2020, 9:38 AM

The man page looks good now, thanks!

Any updates on the src part of the change?

I think we won't progress here if we don't get someone else to review the src parts.
@cperciva: Can you take a look at it?

dteske requested changes to this revision.Dec 11 2020, 4:43 PM

Just a simple bogon in the src bits, after which I will approve

usr.sbin/freebsd-update/freebsd-update.sh
331

I would use NR instead of FNR here simply because FNR has the additional complexity that it will reset to 1 when working on the next file, but when used to process a pipe stream it is in-essence working on a single file (/dev/stdin) and thus NR and FNR are always aligned making the use of FNR a bit of a bogon

This revision now requires changes to proceed.Dec 11 2020, 4:43 PM

Fixed. Thanks for the neat point, I'll keep it in mind.

Fixing my previous mistake - my apologies.

Sorry again, it must be good this time.

@bcr: I think we could proceed now. Please note, that a very little change was made in D25705 where this diff relies on, and if you or anyone approve differentials, I think we can have them landed in 13.0-RELEASE, right? Please let me know if there is anything else I need to improve and update.