Page MenuHomeFreeBSD

freebsd-version(1): Add -j flag to support jails
ClosedPublic

Authored by kfv_kfv.io on Jul 17 2020, 12:13 PM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bcr added a subscriber: bcr.

OK from manpages. A useful feature, I might add.

kevans added inline comments.
bin/freebsd-version/freebsd-version.sh.in
121

We should probably warn if $opt_j == 1 already, but as a future addition it'd be neat if we could support manually-driven usage like:

freebsd-version -j1 -j2 -j3

to fetch the versions of multiple jails, but I don't think that's important to do up front.

  • freebsd-version(1): accept multiple occurrences of the -j option
kfv_kfv.io added inline comments.
bin/freebsd-version/freebsd-version.sh.in
121

I just took care of that, but I didn't know if I should eliminate duplicates, so the user can currently do something like:

freebsd-version -j1 -j1 -j2 -j1

And in return, we give them the versions in the same order as specified.
Please let me know if I should change this behaviour.

@kevans: by the way, on the subject of the attribution we discussed in IRC, I prefer Faraz Vahedi <kfv@kfv.io>, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2021, 6:51 PM
This revision was automatically updated to reflect the committed changes.