Page MenuHomeFreeBSD

jilles (Jilles Tjoelker)
User

Projects

User Details

User Since
May 14 2014, 7:55 PM (341 w, 1 d)

Recent Activity

Wed, Nov 25

jilles added a comment to D27310: kern: never restart syscalls calling closefp(), e.g. close(2).
Wed, Nov 25, 8:25 PM

Tue, Nov 24

jilles accepted D27310: kern: never restart syscalls calling closefp(), e.g. close(2).
In D27310#610450, @kib wrote:

I do not see this EINTR and EINPROGRESS change in the most recent version of POSIX I have, IEEE Std 1003.1™-2017.

The referenced austin group ticket even went as far as propose posix_close() with some retry flag, which again was not added. More, there were strong objections from Linux side arguing that EINTR behavior should be as it is de-facto implemented by Linux and FreeBSD: file is always closed.

Tue, Nov 24, 10:41 PM

Sun, Nov 22

jilles requested changes to D27310: kern: never restart syscalls calling closefp(), e.g. close(2).

Restarting a close() would indeed be very bad, but returning [EINTR] might cause userland to do the same.

Sun, Nov 22, 10:34 PM

Thu, Nov 19

jilles accepted D26208: sleep(1) fractional seconds not so risky.
Thu, Nov 19, 9:47 PM
jilles added a comment to D24617: Add additional EINVAL information about wrong block size to read(2)/write(2).

Having this kind of possibly mysterious errors documented is very useful.

Thu, Nov 19, 9:46 PM
jilles added a comment to D27161: growfs: use sysexits in place of err/errc/errx(1).

My suggestion is to change all the exit statuses that were changed to sysexits codes here to 2 instead.

Thu, Nov 19, 8:23 PM

Mon, Nov 16

jilles added a comment to D27216: Add HISTORY sections for pthread(3) functions.
In D27216#607710, @gbe wrote:

A pthread implementation "libc_r" was already added in 2.2-release, which contained most of these functions.

Mon, Nov 16, 6:39 PM

Sat, Nov 14

jilles requested changes to D27216: Add HISTORY sections for pthread(3) functions.

A pthread implementation "libc_r" was already added in 2.2-release, which contained most of these functions.

Sat, Nov 14, 7:33 PM

Wed, Nov 11

jilles added a comment to D27176: Discourage the use of sysexits(3) in new code.

Exit statuses should implement a protocol between the calling and called process. Since only 8 bits (or 32 if the calling process uses waitid()) are available, there is not much flexibility. I think distinctions between different exit statuses should have a purpose, while most of the sysexits codes categorize errors without a clear purpose. If more flexibility is needed, a channel with more capacity should be used.

Wed, Nov 11, 8:35 PM

Oct 19 2020

jilles accepted D26845: Further refinements of ptsname_r(3) interface:.
Oct 19 2020, 7:53 PM

Oct 18 2020

jilles added inline comments to D26845: Further refinements of ptsname_r(3) interface:.
Oct 18 2020, 9:05 PM

Oct 4 2020

jilles added a comment to D26647: Implement ptsname_r..

This complies to https://www.austingroupbugs.net/bug_view_page.php?bug_id=508 which is planned for POSIX issue8 (in a few years).

Oct 4 2020, 2:01 PM
jilles accepted D26647: Implement ptsname_r..
Oct 4 2020, 1:59 PM

Sep 12 2020

jilles added a comment to D26414: Extend netstat to display the TCP congestion control.

Perhaps it is better to match sockstat (D26413) and make the option -C instead of -c.

Sep 12 2020, 5:36 PM

Sep 1 2020

jilles accepted D26255: phttpget: move out of portsnap.
Sep 1 2020, 1:55 PM
jilles committed rS365037: sh: Write absolute path in command -vV and type.
sh: Write absolute path in command -vV and type
Sep 1 2020, 1:19 PM

Aug 28 2020

jilles committed rS364919: sh: Keep ignored SIGINT/SIGQUIT after set in a background job.
sh: Keep ignored SIGINT/SIGQUIT after set in a background job
Aug 28 2020, 3:36 PM

Aug 22 2020

jilles accepted D26116: Fix several issues with process group orphanage..
Aug 22 2020, 4:31 PM

Aug 3 2020

jilles requested changes to D25922: Revert echo(1) diet changes..

I found a reason to touch this code, but otherwise I'm a bit surprised about a change here.

Aug 3 2020, 8:01 PM

Aug 1 2020

jilles accepted D25892: directory(3): Add an ERRORS section.
Aug 1 2020, 7:58 PM

Jul 30 2020

jilles added inline comments to D25892: directory(3): Add an ERRORS section.
Jul 30 2020, 7:25 PM

Jul 26 2020

jilles accepted D25813: sh(1): print a newline when ^D exits sh.
Jul 26 2020, 9:10 PM

Jul 16 2020

jilles requested changes to D21939: Enter chroot before looking up user or group to change to.

This change may cause breakage in setups where the chroot does not have /etc/pwd.db and related files. Given that chroot(8) has worked like this since 2003, why change it now?

Jul 16 2020, 7:55 PM

Jul 14 2020

jilles accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 14 2020, 10:35 PM

Jul 12 2020

jilles accepted D25554: Make CLOCK_REALTIME and TIMER_ABSTIME available for XOPEN_SOURCE >= 500.
Jul 12 2020, 9:28 PM

Jul 10 2020

jilles added a comment to D24801: Allow ls to list extattrs on a file.

I think the best way forward is to start with -@ first and leave -l output as it is, at first.

Jul 10 2020, 9:06 PM

Jul 9 2020

jilles committed rS363057: sh: Do not ignore INTOFF during a trap.
sh: Do not ignore INTOFF during a trap
Jul 9 2020, 8:54 PM
jilles closed D25270: sh: Do not ignore INTOFF during a trap.
Jul 9 2020, 8:54 PM
jilles committed rS363054: MFC r362738: sh/tests: Re-enable bin.sh.execution.functional_test.bg12.0.
MFC r362738: sh/tests: Re-enable bin.sh.execution.functional_test.bg12.0
Jul 9 2020, 5:43 PM
jilles committed rS363053: MFC r362737: sh/tests: Fix flaky execution/bg12.0.
MFC r362737: sh/tests: Fix flaky execution/bg12.0
Jul 9 2020, 5:42 PM

Jul 1 2020

jilles added a comment to D25525: Add timerisvalid() from OpenBSD.

Since struct timeval is mostly obsoleted by struct timespec, I suggest adding this only when there is existing code using it.

Jul 1 2020, 9:20 PM

Jun 28 2020

jilles committed rS362738: sh/tests: Re-enable bin.sh.execution.functional_test.bg12.0.
sh/tests: Re-enable bin.sh.execution.functional_test.bg12.0
Jun 28 2020, 9:33 PM
jilles committed rS362737: sh/tests: Fix flaky execution/bg12.0.
sh/tests: Fix flaky execution/bg12.0
Jun 28 2020, 9:15 PM

Jun 23 2020

jilles requested review of D25270: sh: Do not ignore INTOFF during a trap.
Jun 23 2020, 3:27 AM

Jun 21 2020

jilles committed rS362467: MFC r362182: sh/tests: Add tests for SIGINT in non-jobc background commands.
MFC r362182: sh/tests: Add tests for SIGINT in non-jobc background commands
Jun 21 2020, 4:06 PM

Jun 18 2020

jilles accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 18 2020, 9:24 AM

Jun 14 2020

jilles committed rS362182: sh/tests: Add tests for SIGINT in non-jobc background commands.
sh/tests: Add tests for SIGINT in non-jobc background commands
Jun 14 2020, 7:41 PM

Jun 9 2020

jilles accepted D25038: execvPe: obviate the need for potentially large stack allocations.
Jun 9 2020, 9:21 PM

May 30 2020

jilles committed rS361647: sh: Allow more scripts without #!.
sh: Allow more scripts without #!
May 30 2020, 4:01 PM
jilles committed rS361646: MFC r361112,r361117: sh: Fix double INTON with vfork.
MFC r361112,r361117: sh: Fix double INTON with vfork
May 30 2020, 1:40 PM

May 29 2020

jilles added inline comments to D25038: execvPe: obviate the need for potentially large stack allocations.
May 29 2020, 1:13 PM
jilles added a comment to D25033: posix_spawn(3): avoid redundant fcntl(2) calls.

The dup2 part looks good.

May 29 2020, 12:56 PM

May 28 2020

jilles added a comment to D25033: posix_spawn(3): avoid redundant fcntl(2) calls.

The dup2 part looks good.

May 28 2020, 9:28 PM
jilles requested changes to D25038: execvPe: obviate the need for potentially large stack allocations.
May 28 2020, 8:50 PM

May 24 2020

jilles added inline comments to D24801: Allow ls to list extattrs on a file.
May 24 2020, 12:56 PM

May 23 2020

jilles added inline comments to D24801: Allow ls to list extattrs on a file.
May 23 2020, 10:13 PM

May 22 2020

jilles committed rS361384: sh: Remove a comment that was obsoleted by r358152.
sh: Remove a comment that was obsoleted by r358152
May 22 2020, 2:46 PM

May 19 2020

jilles added a comment to D24916: Add Caveats Section to fgetln(3).

Although there is nothing wrong with this per se, applications can deal with this problem more easily using getline(3) (which is also standard).

May 19 2020, 8:28 PM

May 16 2020

jilles committed rS361117: sh/tests: Fix keywords on newly added test.
sh/tests: Fix keywords on newly added test
May 16 2020, 7:39 PM
jilles committed rS361112: sh: Fix double INTON with vfork.
sh: Fix double INTON with vfork
May 16 2020, 4:29 PM

May 15 2020

jilles requested changes to D24801: Allow ls to list extattrs on a file.
May 15 2020, 1:34 PM

May 13 2020

jilles accepted D24596: vfs: add restrictions to read(2) of a directory.
May 13 2020, 9:20 PM

May 12 2020

jilles committed rS360992: sh/tests: Test some obscure cases with aliasing keywords.
sh/tests: Test some obscure cases with aliasing keywords
May 12 2020, 9:59 PM
jilles added a comment to D24596: vfs: add restrictions to read(2) of a directory.

read(2) on a directory seems only useful for educational or debugging purposes. These purposes are better served by a different API.

May 12 2020, 6:36 PM

Apr 28 2020

jilles committed rS360452: sh: Assert INTOFF rather than applying it in ck*.
sh: Assert INTOFF rather than applying it in ck*
Apr 28 2020, 8:34 PM
jilles closed D24599: sh: Assert INTOFF rather than applying it in ck*.
Apr 28 2020, 8:34 PM

Apr 27 2020

jilles requested review of D24599: sh: Assert INTOFF rather than applying it in ck*.
Apr 27 2020, 9:59 PM

Apr 25 2020

jilles accepted D24297: Make include/malloc.h usable again..
Apr 25 2020, 3:06 PM

Apr 22 2020

jilles committed rS360210: sh: Remove remnants to compile out fc completely.
sh: Remove remnants to compile out fc completely
Apr 22 2020, 9:46 PM

Apr 20 2020

jilles added a comment to D24458: Fix build with NO_HISTORY set.

Feel free to commit this revision as is. I will handle -h in mkbuiltins.

Apr 20 2020, 8:55 PM

Apr 18 2020

jilles accepted D24458: Fix build with NO_HISTORY set.

A follow-up is to delete -h from mkbuiltins and builtins.def.

Apr 18 2020, 9:20 PM

Apr 17 2020

jilles requested changes to D24458: Fix build with NO_HISTORY set.

This solution looks inconsistent. Either fc and bind are always available (writing an error message if history is not compiled in), in which case mkbuiltins should not be omitting them, or they are not available if history is not compiled in, in which case the functions should not be defined at all if history is not compiled in.

Apr 17 2020, 11:46 AM

Apr 14 2020

jilles added a comment to D24415: Add rcvar to rc.d/utx.

Disabling utx boot and utx shutdown does not prevent other parts of the system writing to the utx files. So by itself this disable creates utx files that are less useful. Disabling utx completely needs patching, at least the way things are now.

Apr 14 2020, 7:13 PM

Apr 4 2020

jilles accepted D24292: Don't remove leading or trailing IFS for passwords.

Some people wrongly add whitespace via copy and paste, but let's be consistent with login, passwd, etc.

Apr 4 2020, 3:04 PM

Mar 25 2020

jilles accepted D24181: sh(1): bump WARNS.

Fine with me, assuming it still builds with recent GCC as well.

Mar 25 2020, 5:57 PM

Mar 4 2020

jilles accepted D21750: ftw.3: Add examples.
Mar 4 2020, 9:06 PM

Mar 2 2020

jilles added a comment to D23911: sshd: Warn about missing ssh-keygen only when necessary.

MAINTAINERS says openssh is maintained by des, who accepts reviews via email only (no phabricator).

Mar 2 2020, 10:46 PM

Feb 24 2020

jilles added a comment to D23802: vn_fullpath: const'ify retbuf.
In D23802#523379, @kib wrote:

The buffer was written by the function, this is my point of the aliasing breakage.

Feb 24 2020, 3:01 PM

Feb 19 2020

jilles accepted D23747: Improve sh(1) built-in read command performance when using a seekable fd.
Feb 19 2020, 11:34 PM

Feb 18 2020

jilles added inline comments to D23739: libfetch: add support for keep-alive.
Feb 18 2020, 10:09 PM

Feb 16 2020

jilles added a comment to D23690: pkgbase: return most config files back to ^/etc.

The bin/sh part looks OK.

Feb 16 2020, 11:06 PM

Feb 12 2020

jilles added inline comments to D21750: ftw.3: Add examples.
Feb 12 2020, 10:51 PM

Feb 9 2020

jilles added inline comments to D23450: libalias: Allow setting alias port ranges.
Feb 9 2020, 7:18 PM

Feb 4 2020

jilles added inline comments to D21750: ftw.3: Add examples.
Feb 4 2020, 11:02 PM

Jan 24 2020

jilles added a comment to D23336: stdio: provide _unlocked variants of fflush, fputc, fputs, fread, fwrite.

What is the point of fputc_unlocked() given that putc_unlocked() already exists?

Jan 24 2020, 4:15 PM

Jan 17 2020

jilles added a comment to D23174: Add qsort_s(3).

Hmm, https://reviews.freebsd.org/D17083 proposes to change qsort_r() argument order to glibc's since that is likely to become POSIX standard and is slightly better than our order.

Jan 17 2020, 7:28 PM

Jan 15 2020

jilles added a comment to D12773: Manage thread signal mask using a shared word, instead of syscall..
In D12773#508215, @cem wrote:

In fact, a very similar scenario is possible _today_ with sigprocmask:

Jan 15 2020, 9:02 PM

Jan 14 2020

jilles added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Jan 14 2020, 11:32 PM

Jan 7 2020

jilles accepted D23038: Make mqueeue objects work across a fork again..

The mq_notify() mechanism indeed needs to be considered here, but I think it already handles that:

Jan 7 2020, 4:21 PM

Jan 1 2020

jilles committed rS356251: sh: Fix rare memory leak with SIGINT.
sh: Fix rare memory leak with SIGINT
Jan 1 2020, 12:06 PM

Dec 30 2019

jilles committed rS356208: sh: Test that executing various binary files is rejected.
sh: Test that executing various binary files is rejected
Dec 30 2019, 9:33 PM

Dec 16 2019

jilles added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Dec 16 2019, 10:48 PM

Dec 11 2019

jilles requested changes to D22756: Have builtins use ck* malloc functions..

Adding INTOFF/INTON around malloc/free prevents unsafety due to interrupting the allocator, but does not prevent memory leaks or double frees due to the administration getting out of sync with the allocator (for example, if the INTON in ckmalloc() notices an interrupt, the allocated memory will leak). It would make more sense if ckmalloc/ckrealloc/ckfree merely asserted that INTON is in effect. I experimented with that earlier but did not follow through.

Dec 11 2019, 7:40 PM
jilles accepted D22187: Add sigsetop extensions commonly found in musl libc and glibc.
Dec 11 2019, 7:08 PM

Dec 7 2019

jilles accepted D22621: Only return EPERM from kill(-pid) when no process was signalled..
Dec 7 2019, 12:32 PM

Dec 6 2019

jilles requested changes to D22621: Only return EPERM from kill(-pid) when no process was signalled..
Dec 6 2019, 5:02 PM

Dec 4 2019

jilles added a comment to D22621: Only return EPERM from kill(-pid) when no process was signalled..

I think the part "to all processes with the same uid as the user" is rather vague now, and would probably be better written as "to all processes which the caller has permission to", given that permission checks are quite complicated nowadays.

Dec 4 2019, 11:21 PM

Oct 18 2019

jilles added a comment to D22061: Build toolchain components as dynamically linked executables by default.

Historically, another reason was performance. For example, https://svnweb.freebsd.org/base?view=revision&revision=76801 which changed make(1) to be statically linked states performance as the reason.

Oct 18 2019, 1:04 PM

Oct 9 2019

jilles accepted D21880: fstat(1) -s option.

Looks good with one grammar issue. Don't forget to bump .Dd.

Oct 9 2019, 9:30 PM

Oct 6 2019

jilles committed rS353148: MFC r352495,r352869: Adjust tests for page fault changes in r353102.
MFC r352495,r352869: Adjust tests for page fault changes in r353102
Oct 6 2019, 8:36 PM
jilles requested changes to D21880: fstat(1) -s option.

This seems useful.

Oct 6 2019, 6:27 PM
jilles added inline comments to D21903: Add per-process flag to disable logsigexit.
Oct 6 2019, 3:48 PM

Oct 5 2019

jilles added a comment to D21903: Add per-process flag to disable logsigexit.
In D21903#478452, @kib wrote:

I find it somewhat strange that you require global control to enable local setting. Less cryptic, I would expect to see per-process setting of 3 cases: 1. default/use sysctl, 2. enabled, 3. disabled.

Oct 5 2019, 5:37 PM

Sep 29 2019

jilles committed rS352869: Adjust tests after page fault changes in r352807.
Adjust tests after page fault changes in r352807
Sep 29 2019, 3:18 PM

Sep 22 2019

jilles added inline comments to D21750: ftw.3: Add examples.
Sep 22 2019, 1:41 PM

Sep 18 2019

jilles committed rS352495: Add some tests for page fault signals and codes.
Add some tests for page fault signals and codes
Sep 18 2019, 9:00 PM
jilles closed D21624: Add some tests for page fault signals and codes.
Sep 18 2019, 9:00 PM
jilles committed rS352492: MFC r351819: procstat/tests: Fix flakiness by waiting for program to start.
MFC r351819: procstat/tests: Fix flakiness by waiting for program to start
Sep 18 2019, 7:28 PM
jilles committed rS352491: MFC r351819: procstat/tests: Fix flakiness by waiting for program to start.
MFC r351819: procstat/tests: Fix flakiness by waiting for program to start
Sep 18 2019, 7:21 PM

Sep 17 2019

jilles added a comment to D21393: [3/3] Add linux-compatible memfd_create.

Very useful, and good generalization of shm_open(SHM_ANON) and memfd_create().

Sep 17 2019, 9:00 PM