jilles (Jilles Tjoelker)
User

Projects

User Details

User Since
May 14 2014, 7:55 PM (191 w, 5 d)

Recent Activity

Sun, Jan 14

jilles accepted D13862: Exit fsck_ffs with non-zero status when file system is not repaired..
Sun, Jan 14, 12:59 PM

Sat, Jan 13

jilles added inline comments to D13862: Exit fsck_ffs with non-zero status when file system is not repaired..
Sat, Jan 13, 2:09 PM

Thu, Jan 11

jilles added inline comments to D8575: Verified execution (veriexec) fingerprint loader.
Thu, Jan 11, 7:41 PM

Sat, Jan 6

jilles committed rS327652: MFC r327211: nandtool: Add missing mode for open() with O_CREAT.
MFC r327211: nandtool: Add missing mode for open() with O_CREAT
Sat, Jan 6, 10:59 PM

Fri, Jan 5

jilles accepted D13770: Make it possible to re-evaluate cpu_features..
Fri, Jan 5, 6:41 PM
jilles added inline comments to D13770: Make it possible to re-evaluate cpu_features..
Fri, Jan 5, 12:06 AM

Thu, Jan 4

jilles committed rS327565: find: Speed up tests by using touch -d instead of sleep for timestamps.
find: Speed up tests by using touch -d instead of sleep for timestamps
Thu, Jan 4, 10:59 PM
jilles added inline comments to D13770: Make it possible to re-evaluate cpu_features..
Thu, Jan 4, 10:48 PM
jilles added a comment to D13759: Remove/Limit whole process swapout.

It is already possible to disable swapping out kernel stacks via sysctl vm.swap_enabled (which has a wrong description) and configure it via sysctls vm.swap_idle_threshold1 and vm.swap_idle_threshold2. What is the problem you are trying to solve?

Thu, Jan 4, 8:42 PM · committers
jilles added a comment to D13759: Remove/Limit whole process swapout.

For a long time, "swapping out" a process has only made its U area (later, only the kernel stack) pageable. This is a few pages per thread. Therefore, comparing vmspace_resident_count does not seem to make much sense.

Thu, Jan 4, 1:42 PM · committers
jilles requested changes to D11958: usr.bin/mandoc build warning/error fixes.

As of rS303524 (July 2016), _WITH_GETLINE is no longer checked by stdio.h. Therefore, there are two possibilities:

Thu, Jan 4, 12:59 AM

Mon, Jan 1

jilles created D13729: Fix sysctl kern.proc.args on self if args are long after r325726.
Mon, Jan 1, 10:43 PM
jilles committed rS327475: sh: Move various structs from jobs.h to jobs.c.
sh: Move various structs from jobs.h to jobs.c
Mon, Jan 1, 10:32 PM

Sun, Dec 31

jilles committed rS327440: find: Link tests to the build.
find: Link tests to the build
Sun, Dec 31, 7:24 PM
jilles accepted D13645: Make vt(4) palette configurable.
Sun, Dec 31, 11:26 AM

Sat, Dec 30

jilles accepted D13645: Make vt(4) palette configurable.
Sat, Dec 30, 10:46 PM

Fri, Dec 29

jilles added inline comments to D13645: Make vt(4) palette configurable.
Fri, Dec 29, 9:45 PM
jilles added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Fri, Dec 29, 9:28 PM
jilles requested changes to D13645: Make vt(4) palette configurable.

Looks useful.

Fri, Dec 29, 2:28 PM

Wed, Dec 27

jilles accepted D13650: Fix a few more spelling errors.
Wed, Dec 27, 8:00 PM
jilles added a comment to D13649: Fix several spelling errors.

OK for bin/sh tests and man pages.

Wed, Dec 27, 7:56 PM

Tue, Dec 26

jilles committed rS327212: sh: Don't leak wait* implementation details from jobs.c.
sh: Don't leak wait* implementation details from jobs.c
Tue, Dec 26, 4:23 PM
jilles committed rS327211: nandtool: Add missing mode for open() with O_CREAT.
nandtool: Add missing mode for open() with O_CREAT
Tue, Dec 26, 4:21 PM
jilles closed D13607: nandtool: Add missing mode for open() with O_CREAT.
Tue, Dec 26, 4:21 PM

Sun, Dec 24

jilles created D13607: nandtool: Add missing mode for open() with O_CREAT.
Sun, Dec 24, 3:09 PM

Sat, Dec 23

jilles committed rS327121: sh(1): Markup and spelling fixes.
sh(1): Markup and spelling fixes
Sat, Dec 23, 10:58 PM

Dec 10 2017

jilles added a comment to D13433: Introduce daemonfd..

It looks like daemon()'s chdir and close actions are performed just before returning successfully; therefore, capability mode code could also call daemon(1, 1) and perform the chdir and/or close actions after it, either open-coded or calling new function(s).

Dec 10 2017, 10:44 PM

Dec 5 2017

jilles committed rS326603: mdoc(7): Update .Dd for previous commit.
mdoc(7): Update .Dd for previous commit
Dec 5 2017, 11:06 PM
jilles committed rS326601: mdocml: Add IEEE Std 1003.1-2008, 2016 edition.
mdocml: Add IEEE Std 1003.1-2008, 2016 edition
Dec 5 2017, 11:00 PM
jilles closed D13349: add IEEE Std 1003.1, 2016 edition.
Dec 5 2017, 11:00 PM
jilles accepted D12473: Allow mergemaster to ignore type mismatches for specified files.

Sorry for the delay.

Dec 5 2017, 9:33 PM
jilles accepted D13334: clean man lint warnings in bin/.
Dec 5 2017, 8:13 PM
jilles accepted D13349: add IEEE Std 1003.1, 2016 edition.
Dec 5 2017, 8:08 PM

Dec 3 2017

jilles added inline comments to D12900: Add sponge(1).
Dec 3 2017, 5:02 PM

Dec 2 2017

jilles added inline comments to D13334: clean man lint warnings in bin/.
Dec 2 2017, 11:03 PM

Nov 26 2017

jilles requested changes to D13244: Remove fortune(6).

This will leave the calls to /usr/bin/fortune in share/skel/dot.login and share/skel/dot.profile referring to something that does not and will not exist (the port will install as /usr/local/bin/fortune).

Nov 26 2017, 1:25 PM

Nov 22 2017

jilles accepted D12873: Move cpuset's parselist function into libutil.

Accepted with a minor change to the man page.

Nov 22 2017, 11:02 PM

Nov 12 2017

jilles requested changes to D13046: Add unit test for cpuset_parlelist(3).
Nov 12 2017, 8:20 PM
jilles added inline comments to D9396: geli attach multiple providers (with kernel changes).
Nov 12 2017, 12:33 PM

Nov 11 2017

jilles accepted D13024: Don't terminate when statfs() fails..
Nov 11 2017, 6:46 PM

Nov 10 2017

jilles requested changes to D13024: Don't terminate when statfs() fails..

Hmm, looking again, the idea of continuing is good, but printing diagnostics without affecting the exit status is usually not POSIX-compliant. To fix this, the global variable exitstatus can be set to 1. Note that there are existing places in function.c that do this wrong (which need not be fixed for this review).

Nov 10 2017, 8:54 PM
jilles accepted D13024: Don't terminate when statfs() fails..
Nov 10 2017, 2:01 PM

Nov 3 2017

jilles committed rS325372: MFC r325017: libnv: Fix strict-aliasing violation with cookie.
MFC r325017: libnv: Fix strict-aliasing violation with cookie
Nov 3 2017, 10:41 PM
jilles added a comment to D12900: Add sponge(1).

An alternative implementation would write to a temporary file, then rename onto the destination once stdin closes. This is how ksh93's >;pathname redirection works (this does not mean I think this definitely should be done like that, or that the shell is the best place to implement this feature).

Nov 3 2017, 3:32 PM

Oct 31 2017

jilles added a comment to D12873: Move cpuset's parselist function into libutil.

Note that all my comments on the cpuset_parselist() implementation also apply to the original version in cpuset.c; therefore, they could be fixed in a separate commit.

Oct 31 2017, 11:09 PM

Oct 26 2017

jilles committed rS325017: libnv: Fix strict-aliasing violation with cookie.
libnv: Fix strict-aliasing violation with cookie
Oct 26 2017, 6:32 PM
jilles closed D12760: libnv: Fix strict-aliasing violation with cookie.
Oct 26 2017, 6:32 PM

Oct 22 2017

jilles created D12760: libnv: Fix strict-aliasing violation with cookie.
Oct 22 2017, 8:23 PM
jilles closed D10363: libc: Do not refer to _DefaultRuneLocale in ctype inlines..
Oct 22 2017, 8:01 PM
jilles committed rS324866: libc: Do not refer to _DefaultRuneLocale in ctype inlines.
libc: Do not refer to _DefaultRuneLocale in ctype inlines
Oct 22 2017, 8:01 PM

Oct 15 2017

jilles committed rP452153: Make COPYTREE_* work with POSIX-compliant sh -c.
Make COPYTREE_* work with POSIX-compliant sh -c
Oct 15 2017, 3:30 PM
jilles committed rS324625: rc.subr: Remove test that is always true..
rc.subr: Remove test that is always true.
Oct 15 2017, 11:29 AM

Oct 6 2017

jilles added a comment to D10363: libc: Do not refer to _DefaultRuneLocale in ctype inlines..

This probably means that we no longer need to expose _DefaultRuneLocale in the header.

Oct 6 2017, 2:22 PM

Oct 1 2017

jilles requested changes to D12473: Allow mergemaster to ignore type mismatches for specified files.

Looks good except for the missing DESTDIR error check.

Oct 1 2017, 1:49 PM

Sep 26 2017

jilles added inline comments to D12473: Allow mergemaster to ignore type mismatches for specified files.
Sep 26 2017, 9:42 PM
jilles requested changes to D12473: Allow mergemaster to ignore type mismatches for specified files.
Sep 26 2017, 4:14 PM

Sep 18 2017

jilles accepted D12403: Instead of keeping a one off copy of the generated man page, follow the same pattern as the file(1) utility and generate the man page from the sources as part of the build..

As a side effect, this change brings in recent updates to the man page (this is good).

Sep 18 2017, 4:03 PM

Aug 16 2017

jilles added a comment to D12006: Update sigaction(2) to reflect the implemention in src/sys/sys/signal.h.

@jilles best to just revert the commit & leave it as-is?

Aug 16 2017, 5:15 PM

Aug 13 2017

jilles committed rS322455: sh: Add test for sh -c with missing command string..
sh: Add test for sh -c with missing command string.
Aug 13 2017, 2:36 PM

Aug 12 2017

jilles committed rS322438: sh: Add tests for sh -c that already pass..
sh: Add tests for sh -c that already pass.
Aug 12 2017, 7:18 PM
jilles added a comment to D12004: Add caveat to kinfo_getvmmap(3) explaining high CPU utilisation.

This seems a useful hint.

Aug 12 2017, 6:40 PM
jilles added a comment to D11783: lang/rust: Build and install Cargo.

Looks reasonable as far as I can see.

Aug 12 2017, 6:32 PM
jilles added a comment to D12007: Add missing header to shmget(2).

This is internally consistent, but does not match what POSIX says. POSIX says only <sys/shm.h> is required and the permissions should be coded using octal constants (yuck). However, if a programmer wants to use S_IRUSR and the like, that is fine. POSIX defines the exact values these constants should have. I don't think POSIX needs to be followed exactly in this.

Aug 12 2017, 6:25 PM
jilles requested changes to D12006: Update sigaction(2) to reflect the implemention in src/sys/sys/signal.h.

Note the paragraph below starting with "The above declaration of struct sigaction is not literal.". The man page is inconsistent now.

Aug 12 2017, 5:39 PM

Aug 9 2017

jilles added a comment to D11317: expr(1): Add -E flag to interpret regular expressions as EREs.

The code change by itself looks good (including all the reasoning about which extensions POSIX permits) but I would prefer not to encourage more use of expr(1) :(

Aug 9 2017, 7:41 PM

Jul 28 2017

jilles added a comment to D11748: du(1): Add --si option and test.

As a side effect, this change allows options and operands to be mixed in GNU style. Either this should be disabled by prepending "+" to the optstring or this should be mentioned in the commit message.

Jul 28 2017, 10:43 PM

Jul 18 2017

jilles committed rS321171: sh: Remove broken #ifdef NOHACK code (related to sh -c)..
sh: Remove broken #ifdef NOHACK code (related to sh -c).
Jul 18 2017, 7:00 PM

Jul 1 2017

jilles committed rS320532: MFC r318592: compress: Allow uncompress -c with multiple pathnames,.
MFC r318592: compress: Allow uncompress -c with multiple pathnames,
Jul 1 2017, 1:03 PM
jilles committed rS320531: MFC r317912: sh: Fix INTOFF leak after a builtin with different locale.
MFC r317912: sh: Fix INTOFF leak after a builtin with different locale
Jul 1 2017, 12:57 PM

Jun 30 2017

jilles committed rS320518: MFC r318591: compress: Add basic tests..
MFC r318591: compress: Add basic tests.
Jun 30 2017, 10:16 PM
jilles committed rS320510: MFC r315005: sh: Fix executing wrong command with ${x#$(y)}$(z)..
MFC r315005: sh: Fix executing wrong command with ${x#$(y)}$(z).
Jun 30 2017, 9:33 PM

Jun 25 2017

jilles committed rS320340: sh: Ignore error when cd writes the directory actually switched to..
sh: Ignore error when cd writes the directory actually switched to.
Jun 25 2017, 9:53 PM

Jun 23 2017

jilles added inline comments to D11304: Extract the DESKTOP_ENTRIES related targets..
Jun 23 2017, 8:11 PM
jilles requested changes to D11316: expr(1): Allow operators as right-hand-side to matching operator.

I looked at what NetBSD and GNU expr do, and they vary in what they accept.

Jun 23 2017, 2:34 PM
jilles added inline comments to D11304: Extract the DESKTOP_ENTRIES related targets..
Jun 23 2017, 2:13 PM

Jun 22 2017

jilles requested changes to D11304: Extract the DESKTOP_ENTRIES related targets..
Jun 22 2017, 10:03 PM

Jun 11 2017

jilles committed rS319828: rc.subr: Optimize repeated sourcing..
rc.subr: Optimize repeated sourcing.
Jun 11 2017, 7:06 PM
jilles committed rS319826: sh: Enable interrupts before executing EXIT trap and doing final flush..
sh: Enable interrupts before executing EXIT trap and doing final flush.
Jun 11 2017, 4:54 PM

Jun 8 2017

jilles added a comment to D11091: remove stale dependencies for utimens* wrappers removed in rS319663.

This looks similar to what I did manually to make a -DNO_CLEAN build work.

Jun 8 2017, 9:57 PM

Jun 7 2017

jilles committed rS319663: libc: Remove futimens() and utimensat() compat stubs..
libc: Remove futimens() and utimensat() compat stubs.
Jun 7 2017, 9:21 PM

Jun 6 2017

jilles committed rS319635: sh: Call fc -e editor with interrupts enabled..
sh: Call fc -e editor with interrupts enabled.
Jun 6 2017, 9:08 PM

Jun 4 2017

jilles committed rS319591: sh: Make sure to process SIGINT if SETINTON re-enables processing..
sh: Make sure to process SIGINT if SETINTON re-enables processing.
Jun 4 2017, 9:58 PM
jilles committed rS319590: tests/sys/aio: Add missing mode to open() calls with O_CREAT..
tests/sys/aio: Add missing mode to open() calls with O_CREAT.
Jun 4 2017, 9:39 PM
jilles accepted D11042: Allow defining nofork builtins from builtins.def and move always-safe ones there..

The test plan should also include running the Kyua/ATF tests.

Jun 4 2017, 8:54 PM
jilles committed rS319575: sh: Fix INTOFF leak when a redirection on a compound command fails..
sh: Fix INTOFF leak when a redirection on a compound command fails.
Jun 4 2017, 8:53 PM
jilles requested changes to D11042: Allow defining nofork builtins from builtins.def and move always-safe ones there..
Jun 4 2017, 7:40 PM

Jun 3 2017

jilles added a comment to D11035: Run child processes in a new process group..

If at all possible, I think it is best to avoid placing the traced process in a new process group, since this breaks things like terminal access control (the traced process will be in a background process group as far as the tty is concerned). Given that the new process group is removed, forwarding signals may make sense (but will duplicate signals if they were originally sent to the process group).

Jun 3 2017, 5:26 PM

May 31 2017

jilles committed rS319362: MFC r318592: compress: Allow uncompress -c with multiple pathnames,.
MFC r318592: compress: Allow uncompress -c with multiple pathnames,
May 31 2017, 9:54 PM

May 29 2017

jilles committed rS319163: MFC r318591: compress: Add basic tests..
MFC r318591: compress: Add basic tests.
May 29 2017, 9:48 PM

May 24 2017

jilles added inline comments to D10799: lang/rust: Update for ino64.
May 24 2017, 9:20 PM

May 23 2017

jilles accepted D10852: Document st_flags in the stat(2)..
May 23 2017, 8:16 PM

May 22 2017

jilles added inline comments to D10852: Document st_flags in the stat(2)..
May 22 2017, 9:34 PM

May 21 2017

jilles committed rS318592: compress: Allow uncompress -c with multiple pathnames, as required by POSIX..
compress: Allow uncompress -c with multiple pathnames, as required by POSIX.
May 21 2017, 2:35 PM
jilles committed rS318591: compress: Add basic tests..
compress: Add basic tests.
May 21 2017, 2:06 PM

May 19 2017

jilles added inline comments to D10818: VNC authentication based on review D7029.
May 19 2017, 3:45 PM

May 18 2017

jilles committed rS318502: sh: Keep output buffer across builtins..
sh: Keep output buffer across builtins.
May 18 2017, 10:10 PM
jilles committed rS318501: sh: Ensure memout.bufsize matches allocated buffer, if it exists..
sh: Ensure memout.bufsize matches allocated buffer, if it exists.
May 18 2017, 9:44 PM

May 16 2017

jilles committed rS318385: sh: Simplify output buffering..
sh: Simplify output buffering.
May 16 2017, 9:55 PM

May 14 2017

jilles committed rS318279: MFC r317912: sh: Fix INTOFF leak after a builtin with different locale.
MFC r317912: sh: Fix INTOFF leak after a builtin with different locale
May 14 2017, 8:18 PM
jilles committed rS318269: sh: Fix '-' from quoted arithmetic in case/glob pattern range..
sh: Fix '-' from quoted arithmetic in case/glob pattern range.
May 14 2017, 1:14 PM