Page MenuHomeFreeBSD

jilles (Jilles Tjoelker)
User

Projects

User Details

User Since
May 14 2014, 7:55 PM (235 w, 12 h)

Recent Activity

Tue, Nov 13

jilles added a comment to D17917: d_off support for multiple filesystems.

"Cookie" or "handle" are definitely good words here. The part "to position the directory descriptor to the start of the entry next to the current" could be simplified a bit to "to position the directory descriptor to the next entry" since the position cannot be in the middle of an entry.

Tue, Nov 13, 11:03 PM

Fri, Nov 9

jilles committed rS340284: sh: Unify EXERROR and EXEXEC.
sh: Unify EXERROR and EXEXEC
Fri, Nov 9, 2:58 PM

Sun, Oct 28

jilles accepted D17714: Allow absolute paths for O_BENEATH..

The man page seems to contain the right content now. I just have some English language comments.

Sun, Oct 28, 10:22 PM

Sat, Oct 27

jilles committed rS339822: sh: Use exitstatus instead of exerrno to pass EXEXEC status.
sh: Use exitstatus instead of exerrno to pass EXEXEC status
Sat, Oct 27, 8:18 PM
jilles requested changes to D17714: Allow absolute paths for O_BENEATH..
Sat, Oct 27, 10:29 AM

Sat, Oct 20

jilles accepted D17547: Implement O_BENEATH and AT_BENEATH.
Sat, Oct 20, 5:13 PM

Fri, Oct 19

jilles added a comment to D17547: Implement O_BENEATH and AT_BENEATH.
In D17547#375528, @kib wrote:

Unconditionally allowing absolute paths with O_BENEATH seems a bit strange, as I expect this to be used for partially untrusted paths. An application can easily check for absolute paths and cause either behaviour (allowing or disallowing).

This was one of my questions. But, it is not clear to me what change, if any, you are proposing.

Fri, Oct 19, 3:23 PM

Wed, Oct 17

jilles added a comment to D17582: sh: use larger BUFSIZ.

OUTBUFSIZ is somewhat of a strange name given that these buffers contain shell input.

Wed, Oct 17, 10:01 PM

Tue, Oct 16

jilles requested changes to D17582: sh: use larger BUFSIZ.
Tue, Oct 16, 11:00 PM
jilles added a comment to D17582: sh: use larger BUFSIZ.

I think it would make more sense to define a new buffer size constant than modifying BUFSIZ.

Tue, Oct 16, 11:00 PM
jilles added a comment to D17547: Implement O_BENEATH and AT_BENEATH.

Unconditionally allowing absolute paths with O_BENEATH seems a bit strange, as I expect this to be used for partially untrusted paths. An application can easily check for absolute paths and cause either behaviour (allowing or disallowing).

Tue, Oct 16, 10:53 PM

Oct 14 2018

jilles requested changes to D17554: s/use/show in two occasions of ls.1.

I don't think "Show time for sorting" is better than "Use time for sorting". If you want to avoid the weak "use", something like "Sort by (with .Fl t) or write (with .Fl l) time when file ..." may be better.

Oct 14 2018, 9:59 PM

Sep 28 2018

jilles committed rS338995: MFC r338473: sh: Fix formal overflow in pointer arithmetic.
MFC r338473: sh: Fix formal overflow in pointer arithmetic
Sep 28 2018, 12:30 PM

Sep 16 2018

jilles added a comment to D17146: ps(1): Add a standard exit status section..

This is not wrong, but perhaps some details about different types of errors may be helpful, such as that nonexistent usernames in -U are immediately fatal while an empty result (such as from only nonexistent process IDs in -p or only existing users that do not currently run any process in -U) still writes the header line (if not disabled) and also returns a non-zero exit status.

Sep 16 2018, 1:41 PM

Sep 6 2018

jilles committed rS338473: sh: Fix formal overflow in pointer arithmetic.
sh: Fix formal overflow in pointer arithmetic
Sep 6 2018, 12:30 PM

Aug 26 2018

jilles created D16910: libmd: Install libmd.so.6 into /lib again after SVN r338270.
Aug 26 2018, 4:33 PM
jilles added a comment to D14626: add -e flag to install(1).

I would like to see a consistent behaviour in handling chown/chmod failures between creating directories and installing files. A -e flag looks ugly and should only be added if both behaviours are necessary in different situations.

Aug 26 2018, 2:06 PM
jilles accepted D16843: development(7): Replace "reboot" with "shutdown -r now".

There is actually another important difference between reboot and shutdown -r now: reboot does not run /etc/rc.shutdown. This is because reboot has its own shutdown procedure and does not signal init like init 6 and shutdown -r now do (except in the case of rerooting via reboot -r).

Aug 26 2018, 11:15 AM

Aug 14 2018

jilles accepted D16700: Add SECURITY section to loader(8).
Aug 14 2018, 5:50 PM

Aug 13 2018

jilles committed rS337728: printf: Add test for width and precision in %b format.
printf: Add test for width and precision in %b format
Aug 13 2018, 9:54 PM
jilles added a comment to D16700: Add SECURITY section to loader(8).

This is useful, but some parts seem too specific to usage in appliances.

Aug 13 2018, 9:15 PM

Aug 11 2018

jilles committed rS337618: printf: Fix \c in %b in printf builtin exiting the shell after r337458.
printf: Fix \c in %b in printf builtin exiting the shell after r337458
Aug 11 2018, 11:13 AM

Aug 10 2018

jilles accepted D14142: getopt_long(3): Document behavior of leading characters in optstring.
Aug 10 2018, 12:36 PM

Jul 15 2018

jilles committed rS336320: sh: Don't treat % specially in CDPATH.
sh: Don't treat % specially in CDPATH
Jul 15 2018, 9:55 PM
jilles committed rS336303: sh: Don't use padvance() for MAIL/MAILPATH.
sh: Don't use padvance() for MAIL/MAILPATH
Jul 15 2018, 9:14 AM

Jul 3 2018

jilles added a comment to D14567: Introduce fdunlinkat..

I think this looks good except that I would like to consider a new errno again.

Jul 3 2018, 10:22 PM
jilles requested changes to D16064: bin/dd: Add conv=direct.

iflag= and oflag= would be better than inventing something new.

Jul 3 2018, 10:06 PM
jilles added a comment to D16064: bin/dd: Add conv=direct.

NetBSD and GNU instead have iflag= and oflag= operands that accept various open flags such as direct. I think that makes more sense, even though conv=notrunc could be considered to belong with oflag instead (but does not for historical reasons).

Jul 3 2018, 10:05 PM
jilles committed rS335905: rup: Fix -Wcast-align warnings.
rup: Fix -Wcast-align warnings
Jul 3 2018, 7:10 PM
jilles closed D16075: rup: Fix -Wcast-align warnings.
Jul 3 2018, 7:10 PM

Jul 1 2018

jilles added a comment to D16075: rup: Fix -Wcast-align warnings.

For my edification: the two possible solutions to cast alignment are (a) memcpy and (b) aligned_alloc. The issue with the latter is that the compiler likely won't understand it, and thus still warn.

Jul 1 2018, 7:12 PM

Jun 30 2018

jilles created D16075: rup: Fix -Wcast-align warnings.
Jun 30 2018, 10:49 AM

Jun 29 2018

jilles added a comment to D16067: Advise reader to also see mdconfig(8) in mount_cd9660(8).

Perhaps the alternative of listing and extracting iso images using tar(1) can be mentioned as well.

Jun 29 2018, 8:17 PM

Jun 26 2018

jilles accepted D15679: Remove potential identifier conflict in the EV_SET macro..

Looks good to me apart from the comment. Sorry for the delay.

Jun 26 2018, 8:32 PM

Jun 21 2018

jilles added inline comments to D14567: Introduce fdunlinkat..
Jun 21 2018, 9:26 PM

Jun 19 2018

jilles accepted D15609: Describe how to prevent *.core files from being created in sh(1) + pet mandoc.
Jun 19 2018, 9:37 PM · Doc Committers, manpages

Jun 10 2018

jilles requested changes to D14567: Introduce fdunlinkat..
Jun 10 2018, 9:14 AM

Jun 9 2018

jilles added inline comments to D15672: Add option to cluster-align the start of the root directory.
Jun 9 2018, 10:37 AM
jilles added inline comments to D15672: Add option to cluster-align the start of the root directory.
Jun 9 2018, 10:35 AM

Jun 7 2018

jilles requested changes to D15298: zgrep: multiple fixes.
Jun 7 2018, 9:48 PM

Jun 6 2018

jilles requested changes to D15679: Remove potential identifier conflict in the EV_SET macro..

Thanks for working on this, but I think pedantic compilation modes should be kept working.

Jun 6 2018, 9:41 PM

May 30 2018

jilles added inline comments to D15609: Describe how to prevent *.core files from being created in sh(1) + pet mandoc.
May 30 2018, 9:09 PM · Doc Committers, manpages

May 21 2018

jilles committed rS334008: sh: Split CNL syntax category to avoid a check on state[level].syntax.
sh: Split CNL syntax category to avoid a check on state[level].syntax
May 21 2018, 9:53 PM
jilles requested changes to D15514: Clarify in unlink(1) that like rm, unlink too requires "--".

I agree that the man page should be changed, but I think it can be done better.

May 21 2018, 8:14 PM

May 20 2018

jilles committed rS333927: sh: Allow unquoted newlines in word in ${param+word} etc..
sh: Allow unquoted newlines in word in ${param+word} etc.
May 20 2018, 5:26 PM

May 11 2018

jilles committed rS333507: sh: Test that backslash-newline within single-quotes is not special.
sh: Test that backslash-newline within single-quotes is not special
May 11 2018, 9:56 PM

May 6 2018

jilles requested changes to D15298: zgrep: multiple fixes.
May 6 2018, 9:16 PM

May 3 2018

jilles committed rS333224: MFC r333092: sh: Don't have [ match any [[:class:]].
MFC r333092: sh: Don't have [ match any [[:class:]]
May 3 2018, 7:47 PM

Apr 29 2018

jilles committed rS333092: sh: Don't have [ match any [[:class:]].
sh: Don't have [ match any [[:class:]]
Apr 29 2018, 5:46 PM

Apr 25 2018

jilles added inline comments to D15193: Use a script wrapper for <compress>grep.
Apr 25 2018, 7:44 PM

Apr 18 2018

jilles accepted D15106: Add PROC_PDEATHSIG_SET to procctl interface..

I like it.

Apr 18 2018, 8:12 PM

Apr 17 2018

jilles added a comment to D15106: Add PROC_PDEATHSIG_SET to procctl interface..

The code itself looks good, but something could be improved in the man page and test.

Apr 17 2018, 10:43 PM

Apr 15 2018

jilles requested changes to D14142: getopt_long(3): Document behavior of leading characters in optstring.

Even though it is from January, this is still a useful patch.

Apr 15 2018, 10:20 PM

Apr 10 2018

jilles accepted D14934: Add recursive flags to setfacl(1).
Apr 10 2018, 9:52 PM
jilles requested changes to D14934: Add recursive flags to setfacl(1).

I found two minor issues. It looks good otherwise.

Apr 10 2018, 9:23 PM

Apr 8 2018

jilles requested changes to D14934: Add recursive flags to setfacl(1).
Apr 8 2018, 9:09 PM

Apr 3 2018

jilles committed rS331955: rc.subr.8: Improve documentation of ${name}_limits and ${name}_login_class.
rc.subr.8: Improve documentation of ${name}_limits and ${name}_login_class
Apr 3 2018, 9:45 PM
jilles closed D14928: Improve documentation of ${name}_limits and ${name}_login_class in rc.subr.8.
Apr 3 2018, 9:45 PM · Doc Committers, manpages
jilles accepted D14928: Improve documentation of ${name}_limits and ${name}_login_class in rc.subr.8.
Apr 3 2018, 7:46 PM · Doc Committers, manpages

Apr 2 2018

jilles added a comment to D14934: Add recursive flags to setfacl(1).

I like the idea. Apparently, the idea of the designers of setfacl was to pipe in a list of filenames from find, but this cannot handle filenames containing newlines and race conditions (such as where an untrusted user replaces a file with a symlink to a different location).

Apr 2 2018, 9:55 PM
jilles added a comment to D14928: Improve documentation of ${name}_limits and ${name}_login_class in rc.subr.8.

Thanks for writing missing documentation.

Apr 2 2018, 9:16 PM · Doc Committers, manpages

Mar 18 2018

jilles added a comment to D14725: Make timespecadd(3) and friends public.
In D14725#309715, @cem wrote:

I think this kind of compatibility should be provided only if necessary for old code that cannot be changed (such as third party code). If it is just to avoid churn, we should keep using the old timespecadd and timespecsub (that is, abandon this change).

I don't follow that line of argument — that compatibility means we should abandon 3-arg timespecfoo, or bringing timespecfoo into userspace. But I will bow to quorum here, which seems to be: we'd rather churn it than have compatibility.

Mar 18 2018, 10:57 PM
jilles added a comment to D14725: Make timespecadd(3) and friends public.

The changes to adapt to the new API look correct to me.

Mar 18 2018, 5:49 PM

Mar 8 2018

jilles added a comment to D14626: add -e flag to install(1).

This patch only affects the -d case. Failure to change owner and modes when installing regular files is fatal in any case. Perhaps the directory case should work the same way?

Mar 8 2018, 9:56 PM

Mar 4 2018

jilles added a comment to D14557: Introduce caph_enter.

This seems sensible, but I found some small mistakes in the man page.

Mar 4 2018, 5:35 PM

Mar 2 2018

jilles added a comment to D14567: Introduce fdunlinkat..

I agree that this should be based on unlinkat(), not unlink(). The new call will therefore take two file descriptors.

Mar 2 2018, 10:08 PM

Feb 26 2018

jilles added inline comments to D14307: Improve missing tty handling in init(8).
Feb 26 2018, 10:39 PM

Feb 18 2018

jilles added inline comments to D14423: Create style.lua(9).
Feb 18 2018, 10:36 PM

Feb 13 2018

jilles accepted D14339: Allow overriding VTABSIZE at compile-time..

I agree that hash table resizing would be nicer, but this is acceptable to commit.

Feb 13 2018, 4:21 PM

Feb 6 2018

jilles added inline comments to D14196: [man page] Introduce channel flags..
Feb 6 2018, 11:01 PM

Feb 2 2018

jilles committed rS328818: sh: Refactor job status printing, preparing for -o pipefail and similar.
sh: Refactor job status printing, preparing for -o pipefail and similar
Feb 2 2018, 10:54 PM

Jan 24 2018

jilles added a comment to D14032: time(1): add an option to use the monotonic clock.

Hmm, it is remarkable to see this after the monotonic clock has existed for so long. Also, GNU time and mksh's keyword appear to use CLOCK_REALTIME without configurability.

Jan 24 2018, 10:50 PM

Jan 21 2018

jilles accepted D13952: usr.sbin/service: Fixes -j to not be order dependant.
Jan 21 2018, 3:06 PM

Jan 20 2018

jilles requested changes to D13952: usr.sbin/service: Fixes -j to not be order dependant.
Jan 20 2018, 11:02 PM
jilles abandoned D13729: Fix sysctl kern.proc.args on self if args are long after r325726.

This was committed by antoine as rS327473.

Jan 20 2018, 10:54 PM

Jan 19 2018

jilles accepted D11304: Extract the DESKTOP_ENTRIES related targets..

It looks like it will work.

Jan 19 2018, 11:00 PM

Jan 17 2018

jilles added a comment to D13952: usr.sbin/service: Fixes -j to not be order dependant.

getopts also allows option-arguments in the same argument as the option, like -jGAOL, or even -ejGAOL (for a jail named GAOL). Therefore, extracting the jail option out without rebuilding the arguments completely is rather hard.

Jan 17 2018, 10:27 PM

Jan 14 2018

jilles accepted D13862: Exit fsck_ffs with non-zero status when file system is not repaired..
Jan 14 2018, 12:59 PM

Jan 13 2018

jilles added inline comments to D13862: Exit fsck_ffs with non-zero status when file system is not repaired..
Jan 13 2018, 2:09 PM

Jan 11 2018

jilles added inline comments to D8575: Verified execution (veriexec) fingerprint loader.
Jan 11 2018, 7:41 PM

Jan 6 2018

jilles committed rS327652: MFC r327211: nandtool: Add missing mode for open() with O_CREAT.
MFC r327211: nandtool: Add missing mode for open() with O_CREAT
Jan 6 2018, 10:59 PM

Jan 5 2018

jilles accepted D13770: Make it possible to re-evaluate cpu_features..
Jan 5 2018, 6:41 PM
jilles added inline comments to D13770: Make it possible to re-evaluate cpu_features..
Jan 5 2018, 12:06 AM

Jan 4 2018

jilles committed rS327565: find: Speed up tests by using touch -d instead of sleep for timestamps.
find: Speed up tests by using touch -d instead of sleep for timestamps
Jan 4 2018, 10:59 PM
jilles added inline comments to D13770: Make it possible to re-evaluate cpu_features..
Jan 4 2018, 10:48 PM
jilles added a comment to D13759: Remove/Limit whole process swapout.

It is already possible to disable swapping out kernel stacks via sysctl vm.swap_enabled (which has a wrong description) and configure it via sysctls vm.swap_idle_threshold1 and vm.swap_idle_threshold2. What is the problem you are trying to solve?

Jan 4 2018, 8:42 PM · committers
jilles added a comment to D13759: Remove/Limit whole process swapout.

For a long time, "swapping out" a process has only made its U area (later, only the kernel stack) pageable. This is a few pages per thread. Therefore, comparing vmspace_resident_count does not seem to make much sense.

Jan 4 2018, 1:42 PM · committers
jilles requested changes to D11958: usr.bin/mandoc build warning/error fixes.

As of rS303524 (July 2016), _WITH_GETLINE is no longer checked by stdio.h. Therefore, there are two possibilities:

Jan 4 2018, 12:59 AM

Jan 1 2018

jilles created D13729: Fix sysctl kern.proc.args on self if args are long after r325726.
Jan 1 2018, 10:43 PM
jilles committed rS327475: sh: Move various structs from jobs.h to jobs.c.
sh: Move various structs from jobs.h to jobs.c
Jan 1 2018, 10:32 PM

Dec 31 2017

jilles committed rS327440: find: Link tests to the build.
find: Link tests to the build
Dec 31 2017, 7:24 PM
jilles accepted D13645: Make vt(4) palette configurable.
Dec 31 2017, 11:26 AM

Dec 30 2017

jilles accepted D13645: Make vt(4) palette configurable.
Dec 30 2017, 10:46 PM

Dec 29 2017

jilles added inline comments to D13645: Make vt(4) palette configurable.
Dec 29 2017, 9:45 PM
jilles added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Dec 29 2017, 9:28 PM
jilles requested changes to D13645: Make vt(4) palette configurable.

Looks useful.

Dec 29 2017, 2:28 PM

Dec 27 2017

jilles accepted D13650: Fix a few more spelling errors.
Dec 27 2017, 8:00 PM
jilles added a comment to D13649: Fix several spelling errors.

OK for bin/sh tests and man pages.

Dec 27 2017, 7:56 PM

Dec 26 2017

jilles committed rS327212: sh: Don't leak wait* implementation details from jobs.c.
sh: Don't leak wait* implementation details from jobs.c
Dec 26 2017, 4:23 PM
jilles committed rS327211: nandtool: Add missing mode for open() with O_CREAT.
nandtool: Add missing mode for open() with O_CREAT
Dec 26 2017, 4:21 PM