In D23802#523379, @kib wrote:

The buffer was written by the function, this is my point of the aliasing breakage.

The bin/sh part looks OK.

What is the point of fputc_unlocked() given that putc_unlocked() already exists?

Hmm, https://reviews.freebsd.org/D17083 proposes to change qsort_r() argument order to glibc's since that is likely to become POSIX standard and is slightly better than our order.

In D12773#508215, @cem wrote:

In fact, a very similar scenario is possible _today_ with sigprocmask:

The mq_notify() mechanism indeed needs to be considered here, but I think it already handles that:

Adding INTOFF/INTON around malloc/free prevents unsafety due to interrupting the allocator, but does not prevent memory leaks or double frees due to the administration getting out of sync with the allocator (for example, if the INTON in ckmalloc() notices an interrupt, the allocated memory will leak). It would make more sense if ckmalloc/ckrealloc/ckfree merely asserted that INTON is in effect. I experimented with that earlier but did not follow through.

I think the part "to all processes with the same uid as the user" is rather vague now, and would probably be better written as "to all processes which the caller has permission to", given that permission checks are quite complicated nowadays.

Historically, another reason was performance. For example, https://svnweb.freebsd.org/base?view=revision&revision=76801 which changed make(1) to be statically linked states performance as the reason.

Looks good with one grammar issue. Don't forget to bump .Dd.

This seems useful.

In D21903#478488, @kevans wrote:

In D21903#478452, @kib wrote:

I find it somewhat strange that you require global control to enable local setting. Less cryptic, I would expect to see per-process setting of 3 cases: 1. default/use sysctl, 2. enabled, 3. disabled.

Very useful, and good generalization of shm_open(SHM_ANON) and memfd_create().

Add more volatile

Add another testcase for access past end of non-empty object

I like that this makes signal numbers and codes more architecture-independent and reduces the number of conversions of this information.

Documentation for the _ variable was indeed missing.

Remove no longer used variable MAX_TRIES

This change looks reasonable, although the exact logic can be improved as noted. It may have been the original intent that $start_cmd use $_env by itself but that would involve replicating error-prone code.

This seems to fit the model.

Looks good to me.

Perhaps it's better to convert ps to use getopt_long() so that we do not invent new single-letter options.

In D20969#455437, @darius-dons.net.au wrote:

Definitely a generic way of achieving this would be nice, and it looks like you can set umask with a login class - to be honest if I had known about the "${name}_login_class" before now I would have used that rather than writing this patch.

Perhaps it will be more generically useful to add a ${name}_umask variable to rc.subr instead.

In D19902#437991, @hrs wrote:

In D19902#437962, @jilles wrote:

Perhaps it is cleaner to pass the int age to be searched for by reference. However, the asymmetry in the compare function is intentional as this allows finding an object with more data given the key, while having only one storage array.

I think it will be useful to have this. It fixes most of the drop in functionality when moving from System V shared memory to POSIX shared memory.

In D19902#437950, @hrs wrote:

As already pointed out on the mailing list, this example has a lot of problems which are not only style bugs. Ones I think as critical except for the style issues are the following:

• The function to compare two elements should accept the same type, not using an "age" field value by using a pointer type. It is a function to compare, not look up a matched element in the definition of bsearch(3). Passing a raw value as (void *) type is not impossible, but it is not suitable for a "textbook" example.

The new function sbuf_printf_drain was added recently enough that this should be safe (binaries using sbuf_printf_drain linked against the old libsbuf.so.6 will not run against the new libsbuf.so.6).

In D20111#433337, @asomers wrote:

In D20111#433326, @jilles wrote:

In D20111#432908, @asomers wrote:

Not so fast! I just discovered a serious footgun: Linux's struct dirent has a
d_off field, but it's meaning is different than FreeBSD's. That's worth
mentioning.

In D20111#432908, @asomers wrote:

Not so fast! I just discovered a serious footgun: Linux's struct dirent has a
d_off field, but it's meaning is different than FreeBSD's. That's worth
mentioning.