jilles (Jilles Tjoelker)
User

Projects

User Details

User Since
May 14 2014, 7:55 PM (214 w, 3 d)

Recent Activity

Thu, Jun 21

jilles added inline comments to D14567: Introduce fdunlinkat..
Thu, Jun 21, 9:26 PM

Tue, Jun 19

jilles accepted D15609: Describe how to prevent *.core files from being created in sh(1) + pet mandoc.
Tue, Jun 19, 9:37 PM · Doc Committers, manpages

Sun, Jun 10

jilles requested changes to D14567: Introduce fdunlinkat..
Sun, Jun 10, 9:14 AM

Sat, Jun 9

jilles added inline comments to D15672: Add option to cluster-align the start of the root directory.
Sat, Jun 9, 10:37 AM
jilles added inline comments to D15672: Add option to cluster-align the start of the root directory.
Sat, Jun 9, 10:35 AM

Thu, Jun 7

jilles requested changes to D15298: zgrep: multiple fixes.
Thu, Jun 7, 9:48 PM

Wed, Jun 6

jilles requested changes to D15679: Remove potential identifier conflict in the EV_SET macro..

Thanks for working on this, but I think pedantic compilation modes should be kept working.

Wed, Jun 6, 9:41 PM

Wed, May 30

jilles added inline comments to D15609: Describe how to prevent *.core files from being created in sh(1) + pet mandoc.
Wed, May 30, 9:09 PM · Doc Committers, manpages

May 21 2018

jilles committed rS334008: sh: Split CNL syntax category to avoid a check on state[level].syntax.
sh: Split CNL syntax category to avoid a check on state[level].syntax
May 21 2018, 9:53 PM
jilles requested changes to D15514: Clarify in unlink(1) that like rm, unlink too requires "--".

I agree that the man page should be changed, but I think it can be done better.

May 21 2018, 8:14 PM

May 20 2018

jilles committed rS333927: sh: Allow unquoted newlines in word in ${param+word} etc..
sh: Allow unquoted newlines in word in ${param+word} etc.
May 20 2018, 5:26 PM

May 11 2018

jilles committed rS333507: sh: Test that backslash-newline within single-quotes is not special.
sh: Test that backslash-newline within single-quotes is not special
May 11 2018, 9:56 PM

May 6 2018

jilles requested changes to D15298: zgrep: multiple fixes.
May 6 2018, 9:16 PM

May 3 2018

jilles committed rS333224: MFC r333092: sh: Don't have [ match any [[:class:]].
MFC r333092: sh: Don't have [ match any [[:class:]]
May 3 2018, 7:47 PM

Apr 29 2018

jilles committed rS333092: sh: Don't have [ match any [[:class:]].
sh: Don't have [ match any [[:class:]]
Apr 29 2018, 5:46 PM

Apr 25 2018

jilles added inline comments to D15193: Use a script wrapper for <compress>grep.
Apr 25 2018, 7:44 PM

Apr 18 2018

jilles accepted D15106: Add PROC_PDEATHSIG_SET to procctl interface..

I like it.

Apr 18 2018, 8:12 PM

Apr 17 2018

jilles added a comment to D15106: Add PROC_PDEATHSIG_SET to procctl interface..

The code itself looks good, but something could be improved in the man page and test.

Apr 17 2018, 10:43 PM

Apr 15 2018

jilles requested changes to D14142: getopt_long(3): Document behavior of leading characters in optstring.

Even though it is from January, this is still a useful patch.

Apr 15 2018, 10:20 PM

Apr 10 2018

jilles accepted D14934: Add recursive flags to setfacl(1).
Apr 10 2018, 9:52 PM
jilles requested changes to D14934: Add recursive flags to setfacl(1).

I found two minor issues. It looks good otherwise.

Apr 10 2018, 9:23 PM

Apr 8 2018

jilles requested changes to D14934: Add recursive flags to setfacl(1).
Apr 8 2018, 9:09 PM

Apr 3 2018

jilles committed rS331955: rc.subr.8: Improve documentation of ${name}_limits and ${name}_login_class.
rc.subr.8: Improve documentation of ${name}_limits and ${name}_login_class
Apr 3 2018, 9:45 PM
jilles closed D14928: Improve documentation of ${name}_limits and ${name}_login_class in rc.subr.8.
Apr 3 2018, 9:45 PM · Doc Committers, manpages
jilles accepted D14928: Improve documentation of ${name}_limits and ${name}_login_class in rc.subr.8.
Apr 3 2018, 7:46 PM · Doc Committers, manpages

Apr 2 2018

jilles added a comment to D14934: Add recursive flags to setfacl(1).

I like the idea. Apparently, the idea of the designers of setfacl was to pipe in a list of filenames from find, but this cannot handle filenames containing newlines and race conditions (such as where an untrusted user replaces a file with a symlink to a different location).

Apr 2 2018, 9:55 PM
jilles added a comment to D14928: Improve documentation of ${name}_limits and ${name}_login_class in rc.subr.8.

Thanks for writing missing documentation.

Apr 2 2018, 9:16 PM · Doc Committers, manpages

Mar 18 2018

jilles added a comment to D14725: Make timespecadd(3) and friends public.
In D14725#309715, @cem wrote:

I think this kind of compatibility should be provided only if necessary for old code that cannot be changed (such as third party code). If it is just to avoid churn, we should keep using the old timespecadd and timespecsub (that is, abandon this change).

I don't follow that line of argument — that compatibility means we should abandon 3-arg timespecfoo, or bringing timespecfoo into userspace. But I will bow to quorum here, which seems to be: we'd rather churn it than have compatibility.

Mar 18 2018, 10:57 PM
jilles added a comment to D14725: Make timespecadd(3) and friends public.

The changes to adapt to the new API look correct to me.

Mar 18 2018, 5:49 PM

Mar 8 2018

jilles added a comment to D14626: add -e flag to install(1).

This patch only affects the -d case. Failure to change owner and modes when installing regular files is fatal in any case. Perhaps the directory case should work the same way?

Mar 8 2018, 9:56 PM

Mar 4 2018

jilles added a comment to D14557: Introduce caph_enter.

This seems sensible, but I found some small mistakes in the man page.

Mar 4 2018, 5:35 PM

Mar 2 2018

jilles added a comment to D14567: Introduce fdunlinkat..

I agree that this should be based on unlinkat(), not unlink(). The new call will therefore take two file descriptors.

Mar 2 2018, 10:08 PM

Feb 26 2018

jilles added inline comments to D14307: Improve missing tty handling in init(8).
Feb 26 2018, 10:39 PM

Feb 18 2018

jilles added inline comments to D14423: Create style.lua(9).
Feb 18 2018, 10:36 PM

Feb 13 2018

jilles accepted D14339: Allow overriding VTABSIZE at compile-time..

I agree that hash table resizing would be nicer, but this is acceptable to commit.

Feb 13 2018, 4:21 PM

Feb 6 2018

jilles added inline comments to D14196: [man page] Introduce channel flags..
Feb 6 2018, 11:01 PM

Feb 2 2018

jilles committed rS328818: sh: Refactor job status printing, preparing for -o pipefail and similar.
sh: Refactor job status printing, preparing for -o pipefail and similar
Feb 2 2018, 10:54 PM

Jan 24 2018

jilles added a comment to D14032: time(1): add an option to use the monotonic clock.

Hmm, it is remarkable to see this after the monotonic clock has existed for so long. Also, GNU time and mksh's keyword appear to use CLOCK_REALTIME without configurability.

Jan 24 2018, 10:50 PM

Jan 21 2018

jilles accepted D13952: usr.sbin/service: Fixes -j to not be order dependant.
Jan 21 2018, 3:06 PM

Jan 20 2018

jilles requested changes to D13952: usr.sbin/service: Fixes -j to not be order dependant.
Jan 20 2018, 11:02 PM
jilles abandoned D13729: Fix sysctl kern.proc.args on self if args are long after r325726.

This was committed by antoine as rS327473.

Jan 20 2018, 10:54 PM

Jan 19 2018

jilles accepted D11304: Extract the DESKTOP_ENTRIES related targets..

It looks like it will work.

Jan 19 2018, 11:00 PM

Jan 17 2018

jilles added a comment to D13952: usr.sbin/service: Fixes -j to not be order dependant.

getopts also allows option-arguments in the same argument as the option, like -jGAOL, or even -ejGAOL (for a jail named GAOL). Therefore, extracting the jail option out without rebuilding the arguments completely is rather hard.

Jan 17 2018, 10:27 PM

Jan 14 2018

jilles accepted D13862: Exit fsck_ffs with non-zero status when file system is not repaired..
Jan 14 2018, 12:59 PM

Jan 13 2018

jilles added inline comments to D13862: Exit fsck_ffs with non-zero status when file system is not repaired..
Jan 13 2018, 2:09 PM

Jan 11 2018

jilles added inline comments to D8575: Verified execution (veriexec) fingerprint loader.
Jan 11 2018, 7:41 PM

Jan 6 2018

jilles committed rS327652: MFC r327211: nandtool: Add missing mode for open() with O_CREAT.
MFC r327211: nandtool: Add missing mode for open() with O_CREAT
Jan 6 2018, 10:59 PM

Jan 5 2018

jilles accepted D13770: Make it possible to re-evaluate cpu_features..
Jan 5 2018, 6:41 PM
jilles added inline comments to D13770: Make it possible to re-evaluate cpu_features..
Jan 5 2018, 12:06 AM

Jan 4 2018

jilles committed rS327565: find: Speed up tests by using touch -d instead of sleep for timestamps.
find: Speed up tests by using touch -d instead of sleep for timestamps
Jan 4 2018, 10:59 PM
jilles added inline comments to D13770: Make it possible to re-evaluate cpu_features..
Jan 4 2018, 10:48 PM
jilles added a comment to D13759: Remove/Limit whole process swapout.

It is already possible to disable swapping out kernel stacks via sysctl vm.swap_enabled (which has a wrong description) and configure it via sysctls vm.swap_idle_threshold1 and vm.swap_idle_threshold2. What is the problem you are trying to solve?

Jan 4 2018, 8:42 PM · committers
jilles added a comment to D13759: Remove/Limit whole process swapout.

For a long time, "swapping out" a process has only made its U area (later, only the kernel stack) pageable. This is a few pages per thread. Therefore, comparing vmspace_resident_count does not seem to make much sense.

Jan 4 2018, 1:42 PM · committers
jilles requested changes to D11958: usr.bin/mandoc build warning/error fixes.

As of rS303524 (July 2016), _WITH_GETLINE is no longer checked by stdio.h. Therefore, there are two possibilities:

Jan 4 2018, 12:59 AM

Jan 1 2018

jilles created D13729: Fix sysctl kern.proc.args on self if args are long after r325726.
Jan 1 2018, 10:43 PM
jilles committed rS327475: sh: Move various structs from jobs.h to jobs.c.
sh: Move various structs from jobs.h to jobs.c
Jan 1 2018, 10:32 PM

Dec 31 2017

jilles committed rS327440: find: Link tests to the build.
find: Link tests to the build
Dec 31 2017, 7:24 PM
jilles accepted D13645: Make vt(4) palette configurable.
Dec 31 2017, 11:26 AM

Dec 30 2017

jilles accepted D13645: Make vt(4) palette configurable.
Dec 30 2017, 10:46 PM

Dec 29 2017

jilles added inline comments to D13645: Make vt(4) palette configurable.
Dec 29 2017, 9:45 PM
jilles added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Dec 29 2017, 9:28 PM
jilles requested changes to D13645: Make vt(4) palette configurable.

Looks useful.

Dec 29 2017, 2:28 PM

Dec 27 2017

jilles accepted D13650: Fix a few more spelling errors.
Dec 27 2017, 8:00 PM
jilles added a comment to D13649: Fix several spelling errors.

OK for bin/sh tests and man pages.

Dec 27 2017, 7:56 PM

Dec 26 2017

jilles committed rS327212: sh: Don't leak wait* implementation details from jobs.c.
sh: Don't leak wait* implementation details from jobs.c
Dec 26 2017, 4:23 PM
jilles committed rS327211: nandtool: Add missing mode for open() with O_CREAT.
nandtool: Add missing mode for open() with O_CREAT
Dec 26 2017, 4:21 PM
jilles closed D13607: nandtool: Add missing mode for open() with O_CREAT.
Dec 26 2017, 4:21 PM

Dec 24 2017

jilles created D13607: nandtool: Add missing mode for open() with O_CREAT.
Dec 24 2017, 3:09 PM

Dec 23 2017

jilles committed rS327121: sh(1): Markup and spelling fixes.
sh(1): Markup and spelling fixes
Dec 23 2017, 10:58 PM

Dec 10 2017

jilles added a comment to D13433: Introduce daemonfd..

It looks like daemon()'s chdir and close actions are performed just before returning successfully; therefore, capability mode code could also call daemon(1, 1) and perform the chdir and/or close actions after it, either open-coded or calling new function(s).

Dec 10 2017, 10:44 PM

Dec 5 2017

jilles committed rS326603: mdoc(7): Update .Dd for previous commit.
mdoc(7): Update .Dd for previous commit
Dec 5 2017, 11:06 PM
jilles committed rS326601: mdocml: Add IEEE Std 1003.1-2008, 2016 edition.
mdocml: Add IEEE Std 1003.1-2008, 2016 edition
Dec 5 2017, 11:00 PM
jilles closed D13349: add IEEE Std 1003.1, 2016 edition.
Dec 5 2017, 11:00 PM
jilles accepted D12473: Allow mergemaster to ignore type mismatches for specified files.

Sorry for the delay.

Dec 5 2017, 9:33 PM
jilles accepted D13334: clean man lint warnings in bin/.
Dec 5 2017, 8:13 PM
jilles accepted D13349: add IEEE Std 1003.1, 2016 edition.
Dec 5 2017, 8:08 PM

Dec 3 2017

jilles added inline comments to D12900: Add sponge(1).
Dec 3 2017, 5:02 PM

Dec 2 2017

jilles added inline comments to D13334: clean man lint warnings in bin/.
Dec 2 2017, 11:03 PM

Nov 26 2017

jilles requested changes to D13244: Remove fortune(6).

This will leave the calls to /usr/bin/fortune in share/skel/dot.login and share/skel/dot.profile referring to something that does not and will not exist (the port will install as /usr/local/bin/fortune).

Nov 26 2017, 1:25 PM

Nov 22 2017

jilles accepted D12873: Move cpuset's parselist function into libutil.

Accepted with a minor change to the man page.

Nov 22 2017, 11:02 PM

Nov 12 2017

jilles requested changes to D13046: Add unit test for cpuset_parlelist(3).
Nov 12 2017, 8:20 PM
jilles added inline comments to D9396: geli attach multiple providers (with kernel changes).
Nov 12 2017, 12:33 PM

Nov 11 2017

jilles accepted D13024: Don't terminate when statfs() fails..
Nov 11 2017, 6:46 PM

Nov 10 2017

jilles requested changes to D13024: Don't terminate when statfs() fails..

Hmm, looking again, the idea of continuing is good, but printing diagnostics without affecting the exit status is usually not POSIX-compliant. To fix this, the global variable exitstatus can be set to 1. Note that there are existing places in function.c that do this wrong (which need not be fixed for this review).

Nov 10 2017, 8:54 PM
jilles accepted D13024: Don't terminate when statfs() fails..
Nov 10 2017, 2:01 PM

Nov 3 2017

jilles committed rS325372: MFC r325017: libnv: Fix strict-aliasing violation with cookie.
MFC r325017: libnv: Fix strict-aliasing violation with cookie
Nov 3 2017, 10:41 PM
jilles added a comment to D12900: Add sponge(1).

An alternative implementation would write to a temporary file, then rename onto the destination once stdin closes. This is how ksh93's >;pathname redirection works (this does not mean I think this definitely should be done like that, or that the shell is the best place to implement this feature).

Nov 3 2017, 3:32 PM

Oct 31 2017

jilles added a comment to D12873: Move cpuset's parselist function into libutil.

Note that all my comments on the cpuset_parselist() implementation also apply to the original version in cpuset.c; therefore, they could be fixed in a separate commit.

Oct 31 2017, 11:09 PM

Oct 26 2017

jilles committed rS325017: libnv: Fix strict-aliasing violation with cookie.
libnv: Fix strict-aliasing violation with cookie
Oct 26 2017, 6:32 PM
jilles closed D12760: libnv: Fix strict-aliasing violation with cookie.
Oct 26 2017, 6:32 PM

Oct 22 2017

jilles created D12760: libnv: Fix strict-aliasing violation with cookie.
Oct 22 2017, 8:23 PM
jilles closed D10363: libc: Do not refer to _DefaultRuneLocale in ctype inlines..
Oct 22 2017, 8:01 PM
jilles committed rS324866: libc: Do not refer to _DefaultRuneLocale in ctype inlines.
libc: Do not refer to _DefaultRuneLocale in ctype inlines
Oct 22 2017, 8:01 PM

Oct 15 2017

jilles committed rP452153: Make COPYTREE_* work with POSIX-compliant sh -c.
Make COPYTREE_* work with POSIX-compliant sh -c
Oct 15 2017, 3:30 PM
jilles committed rS324625: rc.subr: Remove test that is always true..
rc.subr: Remove test that is always true.
Oct 15 2017, 11:29 AM

Oct 6 2017

jilles added a comment to D10363: libc: Do not refer to _DefaultRuneLocale in ctype inlines..

This probably means that we no longer need to expose _DefaultRuneLocale in the header.

Oct 6 2017, 2:22 PM

Oct 1 2017

jilles requested changes to D12473: Allow mergemaster to ignore type mismatches for specified files.

Looks good except for the missing DESTDIR error check.

Oct 1 2017, 1:49 PM

Sep 26 2017

jilles added inline comments to D12473: Allow mergemaster to ignore type mismatches for specified files.
Sep 26 2017, 9:42 PM
jilles requested changes to D12473: Allow mergemaster to ignore type mismatches for specified files.
Sep 26 2017, 4:14 PM

Sep 18 2017

jilles accepted D12403: Instead of keeping a one off copy of the generated man page, follow the same pattern as the file(1) utility and generate the man page from the sources as part of the build..

As a side effect, this change brings in recent updates to the man page (this is good).

Sep 18 2017, 4:03 PM