nanobsd: minor formatting cleanup
ClosedPublic
Actions

Authored by ngie on Sep 17 2025, 6:23 PM.

Details

Reviewers

imp

Commits

rGc99bb5747f5e: nanobsd: minor formatting cleanup

Summary

Reformat function definitions

POSIX states that compound commands, i.e., ones that use (..) or
{ .. } , are permissible as function definitions, however, many shell
syntax validators do not acknowledge the former format.

Switch to the latter format so more naive editors, like the vim syntax
highlighter, better parse the syntax of the file.

Moreover, replacing (..) with {..} replaces several subshells with
their non-subshell equivalents. Given that set -e is used liberally
and exit is not used in the calling code when set -e is not
enforced, there is no net loss by making this change.

Clean trailing whitespace.
Reindent some related comments to match the indentation of the previous line.
Add shebangs to the tops of files to help syntax colorizers and file identifiers understand that the files are in shell syntax.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Sep 17 2025, 6:23 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 17 2025, 6:23 PM

ngie requested review of this revision.Sep 17 2025, 6:23 PM

Harbormaster completed remote builds in B67127: Diff 162271.Sep 17 2025, 6:23 PM

ngie added a reviewer: imp.Sep 17 2025, 6:24 PM

ngie removed a subscriber: imp.

ngie added a subscriber: jilles.

There's a few of these elsewhere in the nanobsd tree.
It's also the only place in the tree we do this style, so this is good, I think.

This revision is now accepted and ready to land.Sep 17 2025, 6:30 PM

ngie edited the summary of this revision. (Show Details)Sep 17 2025, 6:32 PM

Use local with variables for explicitness

This revision now requires review to proceed.Sep 17 2025, 6:33 PM

Harbormaster completed remote builds in B67128: Diff 162272.Sep 17 2025, 6:33 PM

imp accepted this revision.Sep 17 2025, 6:36 PM

This revision is now accepted and ready to land.Sep 17 2025, 6:36 PM

ngie edited the summary of this revision. (Show Details)Sep 17 2025, 6:40 PM

ngie retitled this revision from nanobsd: reformat function definitions to nanobsd: minor formatting cleanup.Sep 17 2025, 6:44 PM

ngie edited the summary of this revision. (Show Details)

Expand scope to include other files under tools/tools/nanobsd

This revision now requires review to proceed.Sep 17 2025, 6:44 PM

Harbormaster completed remote builds in B67129: Diff 162273.Sep 17 2025, 6:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2025, 7:18 PM

Closed by commit rGc99bb5747f5e: nanobsd: minor formatting cleanup (authored by ngie). · Explain Why

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rGc99bb5747f5e: nanobsd: minor formatting cleanup.

jilles added inline comments.Sep 21 2025, 3:31 PM

tools/tools/nanobsd/defaults.sh
257	So this function now changes the caller's current directory.
274	So this function now changes the caller's current directory.
526	So this function now changes the caller's current directory.