MFC after: 3 days
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 70709 Build 67592: arc lint + arc unit
Event Timeline
Shouldn't .Dd be bumped in this case?
| bin/sh/sh.1 | ||
|---|---|---|
| 3081 | Maybe we should describe it as 'default' file for user's history? Since it can be overwritten by HISTFILE. | |
Maybe we should describe it as 'default' file for user's history? Since it can be overwritten by HISTFILE.
I thought about this, but tried to follow the existing style of the section as tightly as possible. If they search up for .sh_history they will find that, no different than if we add an extra HISTFILE for them to search up for :) This makes the doc prettier and keeps it from being too bloated.
Thanks for the reviews! Edit: we'll give jilles a few days in case he wishes to weigh in per his request in MAINTAINERS.
I thought about this, but tried to follow the existing style of the section as tightly as possible. If they search up for .sh_history they will find that, no different than if we add an extra HISTFILE for them to search up for :) This makes the doc prettier and keeps it from being too bloated.
Thanks for the reviews! Edit: we'll give jilles a few days in case he wishes to weigh in per his request in MAINTAINERS.
The ~/.sh_history file differs from the other items in the FILES section in that it can be changed using a shell variable. So making it "Default file for shell history" seems reasonable to me. The part "user's" is not relevant since there is no "system" shell history (like there is a system login profile).
There is also the file ~/.shrc which is defined by the ENV setting in the default ~/.profile. This is described elsewhere in the manual page. Perhaps this can be added to the FILES section too? It needs yet another formulation since it has no default.