Page MenuHomeFreeBSD
Feed Advanced Search

Wed, Mar 25

jilles accepted D24181: sh(1): bump WARNS.

Fine with me, assuming it still builds with recent GCC as well.

Wed, Mar 25, 5:57 PM

Wed, Mar 4

jilles accepted D21750: ftw.3: Add examples.
Wed, Mar 4, 9:06 PM

Mon, Mar 2

jilles added a comment to D23911: sshd: Warn about missing ssh-keygen only when necessary.

MAINTAINERS says openssh is maintained by des, who accepts reviews via email only (no phabricator).

Mon, Mar 2, 10:46 PM

Feb 24 2020

jilles added a comment to D23802: vn_fullpath: const'ify retbuf.
In D23802#523379, @kib wrote:

The buffer was written by the function, this is my point of the aliasing breakage.

Feb 24 2020, 3:01 PM

Feb 19 2020

jilles accepted D23747: Improve sh(1) built-in read command performance when using a seekable fd.
Feb 19 2020, 11:34 PM

Feb 18 2020

jilles added inline comments to D23739: libfetch: add support for keep-alive.
Feb 18 2020, 10:09 PM

Feb 16 2020

jilles added a comment to D23690: pkgbase: return most config files back to ^/etc.

The bin/sh part looks OK.

Feb 16 2020, 11:06 PM

Feb 12 2020

jilles added inline comments to D21750: ftw.3: Add examples.
Feb 12 2020, 10:51 PM

Feb 9 2020

jilles added inline comments to D23450: libalias: Allow setting alias port ranges.
Feb 9 2020, 7:18 PM

Feb 4 2020

jilles added inline comments to D21750: ftw.3: Add examples.
Feb 4 2020, 11:02 PM

Jan 24 2020

jilles added a comment to D23336: stdio: provide _unlocked variants of fflush, fputc, fputs, fread, fwrite.

What is the point of fputc_unlocked() given that putc_unlocked() already exists?

Jan 24 2020, 4:15 PM

Jan 17 2020

jilles added a comment to D23174: Add qsort_s(3).

Hmm, https://reviews.freebsd.org/D17083 proposes to change qsort_r() argument order to glibc's since that is likely to become POSIX standard and is slightly better than our order.

Jan 17 2020, 7:28 PM

Jan 15 2020

jilles added a comment to D12773: Manage thread signal mask using a shared word, instead of syscall..
In D12773#508215, @cem wrote:

In fact, a very similar scenario is possible _today_ with sigprocmask:

Jan 15 2020, 9:02 PM

Jan 14 2020

jilles added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Jan 14 2020, 11:32 PM

Jan 7 2020

jilles accepted D23038: Make mqueeue objects work across a fork again..

The mq_notify() mechanism indeed needs to be considered here, but I think it already handles that:

Jan 7 2020, 4:21 PM

Jan 1 2020

jilles committed rS356251: sh: Fix rare memory leak with SIGINT.
sh: Fix rare memory leak with SIGINT
Jan 1 2020, 12:06 PM

Dec 30 2019

jilles committed rS356208: sh: Test that executing various binary files is rejected.
sh: Test that executing various binary files is rejected
Dec 30 2019, 9:33 PM

Dec 16 2019

jilles added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Dec 16 2019, 10:48 PM

Dec 11 2019

jilles requested changes to D22756: Have builtins use ck* malloc functions..

Adding INTOFF/INTON around malloc/free prevents unsafety due to interrupting the allocator, but does not prevent memory leaks or double frees due to the administration getting out of sync with the allocator (for example, if the INTON in ckmalloc() notices an interrupt, the allocated memory will leak). It would make more sense if ckmalloc/ckrealloc/ckfree merely asserted that INTON is in effect. I experimented with that earlier but did not follow through.

Dec 11 2019, 7:40 PM
jilles accepted D22187: Add sigsetop extensions commonly found in musl libc and glibc.
Dec 11 2019, 7:08 PM

Dec 7 2019

jilles accepted D22621: Only return EPERM from kill(-pid) when no process was signalled..
Dec 7 2019, 12:32 PM

Dec 6 2019

jilles requested changes to D22621: Only return EPERM from kill(-pid) when no process was signalled..
Dec 6 2019, 5:02 PM

Dec 4 2019

jilles added a comment to D22621: Only return EPERM from kill(-pid) when no process was signalled..

I think the part "to all processes with the same uid as the user" is rather vague now, and would probably be better written as "to all processes which the caller has permission to", given that permission checks are quite complicated nowadays.

Dec 4 2019, 11:21 PM

Oct 18 2019

jilles added a comment to D22061: Build toolchain components as dynamically linked executables by default.

Historically, another reason was performance. For example, https://svnweb.freebsd.org/base?view=revision&revision=76801 which changed make(1) to be statically linked states performance as the reason.

Oct 18 2019, 1:04 PM

Oct 9 2019

jilles accepted D21880: fstat(1) -s option.

Looks good with one grammar issue. Don't forget to bump .Dd.

Oct 9 2019, 9:30 PM

Oct 6 2019

jilles committed rS353148: MFC r352495,r352869: Adjust tests for page fault changes in r353102.
MFC r352495,r352869: Adjust tests for page fault changes in r353102
Oct 6 2019, 8:36 PM
jilles requested changes to D21880: fstat(1) -s option.

This seems useful.

Oct 6 2019, 6:27 PM
jilles added inline comments to D21903: Add per-process flag to disable logsigexit.
Oct 6 2019, 3:48 PM

Oct 5 2019

jilles added a comment to D21903: Add per-process flag to disable logsigexit.
In D21903#478452, @kib wrote:

I find it somewhat strange that you require global control to enable local setting. Less cryptic, I would expect to see per-process setting of 3 cases: 1. default/use sysctl, 2. enabled, 3. disabled.

Oct 5 2019, 5:37 PM

Sep 29 2019

jilles committed rS352869: Adjust tests after page fault changes in r352807.
Adjust tests after page fault changes in r352807
Sep 29 2019, 3:18 PM

Sep 22 2019

jilles added inline comments to D21750: ftw.3: Add examples.
Sep 22 2019, 1:41 PM

Sep 18 2019

jilles committed rS352495: Add some tests for page fault signals and codes.
Add some tests for page fault signals and codes
Sep 18 2019, 9:00 PM
jilles closed D21624: Add some tests for page fault signals and codes.
Sep 18 2019, 9:00 PM
jilles committed rS352492: MFC r351819: procstat/tests: Fix flakiness by waiting for program to start.
MFC r351819: procstat/tests: Fix flakiness by waiting for program to start
Sep 18 2019, 7:28 PM
jilles committed rS352491: MFC r351819: procstat/tests: Fix flakiness by waiting for program to start.
MFC r351819: procstat/tests: Fix flakiness by waiting for program to start
Sep 18 2019, 7:21 PM

Sep 17 2019

jilles added a comment to D21393: [3/3] Add linux-compatible memfd_create.

Very useful, and good generalization of shm_open(SHM_ANON) and memfd_create().

Sep 17 2019, 9:00 PM

Sep 16 2019

jilles updated the diff for D21624: Add some tests for page fault signals and codes.

Add more volatile

Sep 16 2019, 9:56 PM
jilles added inline comments to D21624: Add some tests for page fault signals and codes.
Sep 16 2019, 9:54 PM
jilles added inline comments to D20477: Introduce stats(3).
Sep 16 2019, 9:39 PM

Sep 15 2019

jilles updated the diff for D21624: Add some tests for page fault signals and codes.

Add another testcase for access past end of non-empty object

Sep 15 2019, 9:51 PM
jilles accepted D19058: posix_spawn(3): handle potential signal issues with vfork.
Sep 15 2019, 11:33 AM

Sep 14 2019

jilles added inline comments to D21566: Improve MD page fault handlers..
Sep 14 2019, 11:10 AM

Sep 12 2019

jilles added inline comments to D19058: posix_spawn(3): handle potential signal issues with vfork.
Sep 12 2019, 8:10 PM
jilles created D21624: Add some tests for page fault signals and codes.
Sep 12 2019, 7:53 PM

Sep 10 2019

jilles added a comment to D21566: Improve MD page fault handlers..

I like that this makes signal numbers and codes more architecture-independent and reduces the number of conversions of this information.

Sep 10 2019, 9:31 PM

Sep 9 2019

jilles requested changes to D21571: sh(1): Document the special underscore parameter ("$_").

Documentation for the _ variable was indeed missing.

Sep 9 2019, 10:14 PM

Sep 4 2019

jilles committed rS351819: procstat/tests: Fix flakiness by waiting for program to start.
procstat/tests: Fix flakiness by waiting for program to start
Sep 4 2019, 4:26 PM
jilles closed D21519: procstat/tests: Fix flakiness by waiting for program to start.
Sep 4 2019, 4:26 PM
jilles updated the diff for D21519: procstat/tests: Fix flakiness by waiting for program to start.

Remove no longer used variable MAX_TRIES

Sep 4 2019, 2:06 PM
jilles created D21519: procstat/tests: Fix flakiness by waiting for program to start.
Sep 4 2019, 2:00 PM

Sep 2 2019

jilles added inline comments to D21473: freebsd-update: Add `updatesready` and `showconfig` commands..
Sep 2 2019, 10:07 PM

Sep 1 2019

D21423: Add an shm_rename syscall is now accepted and ready to land.
Sep 1 2019, 10:02 PM

Aug 31 2019

jilles added inline comments to D21423: Add an shm_rename syscall.
Aug 31 2019, 4:05 PM

Aug 29 2019

D21228: rc: Honor ${name}_env when a custom *_cmd is defined (e.g., start_cmd) is now accepted and ready to land.
Aug 29 2019, 10:21 PM

Aug 28 2019

jilles added inline comments to D21423: Add an shm_rename syscall.
Aug 28 2019, 8:29 PM
D21228: rc: Honor ${name}_env when a custom *_cmd is defined (e.g., start_cmd) now requires changes to proceed.

This change looks reasonable, although the exact logic can be improved as noted. It may have been the original intent that $start_cmd use $_env by itself but that would involve replicating error-prone code.

Aug 28 2019, 1:04 PM
D21443: S"timefmt" flag to newsyslog(8) is now accepted and ready to land.
Aug 28 2019, 10:05 AM

Aug 27 2019

jilles added inline comments to D21443: S"timefmt" flag to newsyslog(8).
Aug 27 2019, 9:21 PM
jilles added inline comments to D21391: [1/3] Add mostly Linux-compatible file sealing support.
Aug 27 2019, 7:09 PM
jilles added a comment to D21423: Add an shm_rename syscall.

This seems to fit the model.

Aug 27 2019, 12:56 PM

Aug 22 2019

D21370: Add conv=fsync flag to dd is now accepted and ready to land.

Looks good to me.

Aug 22 2019, 8:36 PM

Aug 6 2019

jilles committed rS350658: Add a test for kill() on a zombie.
Add a test for kill() on a zombie
Aug 6 2019, 9:17 PM

Aug 5 2019

jilles committed rS350615: MFC r350425: printf(1): Note that \c only works in %b strings.
MFC r350425: printf(1): Note that \c only works in %b strings
Aug 5 2019, 8:21 PM
jilles committed rS350613: MFC r350425: printf(1): Note that \c only works in %b strings.
MFC r350425: printf(1): Note that \c only works in %b strings
Aug 5 2019, 8:20 PM

Jul 31 2019

jilles added a comment to D21123: Teach ps(1) to select processes by parent process ID..

Perhaps it's better to convert ps to use getopt_long() so that we do not invent new single-letter options.

Jul 31 2019, 7:14 PM

Jul 29 2019

jilles committed rS350425: printf(1): Note that \c only works in %b strings.
printf(1): Note that \c only works in %b strings
Jul 29 2019, 8:43 PM

Jul 21 2019

jilles added a comment to D20969: Add option to set umask before starting child process.

Definitely a generic way of achieving this would be nice, and it looks like you can set umask with a login class - to be honest if I had known about the "${name}_login_class" before now I would have used that rather than writing this patch.

Jul 21 2019, 9:52 PM

Jul 18 2019

jilles added a comment to D20969: Add option to set umask before starting child process.

Perhaps it will be more generically useful to add a ${name}_umask variable to rc.subr instead.

Jul 18 2019, 9:00 PM

Jul 5 2019

jilles added inline comments to D20584: add a linux compatible copy_file_range(2) syscall.
Jul 5 2019, 1:45 PM

Jul 2 2019

jilles added inline comments to D20772: Provide protection against starvation of the ll/sc loops when accessing userpace..
Jul 2 2019, 10:10 PM

May 21 2019

jilles accepted D20258: posixshmcontrol(1), an utility to query and manipulate named posix shm objects.
May 21 2019, 8:42 PM

May 20 2019

jilles added a comment to D19902: bsearc.3: Add EXAMPLES section.
In D19902#437991, @hrs wrote:

Perhaps it is cleaner to pass the int age to be searched for by reference. However, the asymmetry in the compare function is intentional as this allows finding an object with more data given the key, while having only one storage array.

May 20 2019, 9:15 PM

May 19 2019

jilles added a comment to D20258: posixshmcontrol(1), an utility to query and manipulate named posix shm objects.

I think it will be useful to have this. It fixes most of the drop in functionality when moving from System V shared memory to POSIX shared memory.

May 19 2019, 9:17 PM
jilles added inline comments to D19902: bsearc.3: Add EXAMPLES section.
May 19 2019, 8:51 PM
jilles added a comment to D19902: bsearc.3: Add EXAMPLES section.
In D19902#437950, @hrs wrote:

As already pointed out on the mailing list, this example has a lot of problems which are not only style bugs. Ones I think as critical except for the style issues are the following:

  • The function to compare two elements should accept the same type, not using an "age" field value by using a pointer type. It is a function to compare, not look up a matched element in the definition of bsearch(3). Passing a raw value as (void *) type is not impossible, but it is not suitable for a "textbook" example.
May 19 2019, 8:42 PM

May 7 2019

jilles accepted D20187: Fix r347229 libsbuf symbol version.

The new function sbuf_printf_drain was added recently enough that this should be safe (binaries using sbuf_printf_drain linked against the old libsbuf.so.6 will not run against the new libsbuf.so.6).

May 7 2019, 9:10 PM

May 2 2019

jilles accepted D20111: directory.3: add a STANDARDS section.

Not so fast! I just discovered a serious footgun: Linux's struct dirent has a
d_off field, but it's meaning is different than FreeBSD's. That's worth
mentioning.

May 2 2019, 7:51 PM

May 1 2019

jilles added a comment to D20111: directory.3: add a STANDARDS section.

Not so fast! I just discovered a serious footgun: Linux's struct dirent has a
d_off field, but it's meaning is different than FreeBSD's. That's worth
mentioning.

May 1 2019, 11:13 PM

Apr 15 2019

jilles accepted D19902: bsearc.3: Add EXAMPLES section.
Apr 15 2019, 4:39 PM

Apr 13 2019

jilles added inline comments to D19902: bsearc.3: Add EXAMPLES section.
Apr 13 2019, 7:38 PM

Apr 5 2019

jilles accepted D18670: Minor speedup for load_kld function.
Apr 5 2019, 10:06 PM

Mar 27 2019

jilles committed rS345617: MFC r344306: sh: Send normal output from bind builtin to stdout.
MFC r344306: sh: Send normal output from bind builtin to stdout
Mar 27 2019, 10:09 PM
jilles committed rS345613: MFC r344306: sh: Send normal output from bind builtin to stdout.
MFC r344306: sh: Send normal output from bind builtin to stdout
Mar 27 2019, 9:53 PM

Mar 26 2019

jilles committed rS345561: MFC r344502: sh: Add set -o pipefail.
MFC r344502: sh: Add set -o pipefail
Mar 26 2019, 10:34 PM
jilles committed rS345559: MFC r328818: sh: Refactor job status printing, preparing for -o pipefail and.
MFC r328818: sh: Refactor job status printing, preparing for -o pipefail and
Mar 26 2019, 9:30 PM
jilles committed rS345556: MFC r327475: sh: Move various structs from jobs.h to jobs.c.
MFC r327475: sh: Move various structs from jobs.h to jobs.c
Mar 26 2019, 8:47 PM

Mar 24 2019

jilles committed rS345487: MFC r344502: sh: Add set -o pipefail.
MFC r344502: sh: Add set -o pipefail
Mar 24 2019, 10:10 PM

Mar 13 2019

jilles committed rS345117: MFC r342880,r343981,r344902: sh: Fix $((-9223372036854775808)).
MFC r342880,r343981,r344902: sh: Fix $((-9223372036854775808))
Mar 13 2019, 9:53 PM

Mar 8 2019

jilles accepted D19441: Remove an unneeded 'tail -n 1' from a pipeline.
Mar 8 2019, 10:00 PM

Mar 7 2019

jilles committed rS344902: sh/tests: Improve failure messages of expansion/arith15.0.
sh/tests: Improve failure messages of expansion/arith15.0
Mar 7 2019, 10:52 PM

Feb 24 2019

jilles committed rS344502: sh: Add set -o pipefail.
sh: Add set -o pipefail
Feb 24 2019, 9:05 PM

Feb 19 2019

jilles committed rS344306: sh: Send normal output from bind builtin to stdout.
sh: Send normal output from bind builtin to stdout
Feb 19 2019, 9:27 PM

Feb 17 2019

jilles accepted D19211: pkru(3).
Feb 17 2019, 9:15 PM
jilles committed rS344237: MFC r343896,r343922: dhclient: Pass through exit status from script.
MFC r343896,r343922: dhclient: Pass through exit status from script
Feb 17 2019, 8:25 PM
jilles added inline comments to D19221: Use iconv to ensure the output of calendar respects the output encoding.
Feb 17 2019, 1:03 PM

Feb 16 2019

jilles added inline comments to D19211: pkru(3).
Feb 16 2019, 6:58 PM
jilles added inline comments to D19211: pkru(3).
Feb 16 2019, 2:57 PM

Feb 10 2019

jilles committed rS343981: sh: Restore $((x)) error checking after fix for $((-9223372036854775808)).
sh: Restore $((x)) error checking after fix for $((-9223372036854775808))
Feb 10 2019, 10:23 PM
jilles closed D18926: sh: Restore $((x)) error checking after fix for $((-9223372036854775808)).
Feb 10 2019, 10:23 PM

Feb 8 2019

jilles committed rS343922: dhclient: Return non-zero status when script exits due to a signal.
dhclient: Return non-zero status when script exits due to a signal
Feb 8 2019, 11:03 PM