Page MenuHomeFreeBSD

Search for objective c method definitions
ClosedPublic

Authored by thj on Feb 8 2022, 1:51 PM.
Tags
None
Referenced Files
F120672167: D34202.diff
Fri, Jun 20, 2:41 AM
Unknown Object (File)
Wed, Jun 18, 8:05 AM
Unknown Object (File)
Tue, Jun 17, 11:20 PM
Unknown Object (File)
Thu, Jun 12, 8:05 AM
Unknown Object (File)
Wed, Jun 11, 8:44 PM
Unknown Object (File)
Wed, Jun 11, 2:49 PM
Unknown Object (File)
Wed, Jun 11, 11:43 AM
Unknown Object (File)
Tue, Jun 10, 7:18 PM

Details

Summary

When searching back for function definitions, consider lines starting
with '+' and '-', this allows us to pick up objective methods as well as
c style function definitions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

thj requested review of this revision.Feb 8 2022, 1:51 PM

don't forget to add a unit test

This revision is now accepted and ready to land.Feb 8 2022, 2:36 PM
  • Add tests for finding function names
This revision now requires review to proceed.Feb 10 2022, 3:17 PM

Other than that wording tweak, spelling and grammar in manual page change LGTM.

usr.bin/diff/diff.1
400
This revision is now accepted and ready to land.Feb 11 2022, 7:16 PM
jilles added inline comments.
usr.bin/diff/tests/functionname_objcm.in
22

Fortunately, this code is never run :) The pointer subtraction is immediate undefined behaviour.

This revision was automatically updated to reflect the committed changes.