Page MenuHomeFreeBSD

Search for objective c method definitions
ClosedPublic

Authored by thj on Feb 8 2022, 1:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 16 2024, 4:07 AM
Unknown Object (File)
Dec 27 2023, 12:05 PM
Unknown Object (File)
Dec 20 2023, 12:59 AM
Unknown Object (File)
Nov 4 2023, 6:44 PM
Unknown Object (File)
Oct 13 2023, 5:58 AM
Unknown Object (File)
Sep 18 2023, 10:21 AM
Unknown Object (File)
Aug 12 2023, 11:56 PM
Unknown Object (File)
Jul 22 2023, 6:44 AM

Details

Summary

When searching back for function definitions, consider lines starting
with '+' and '-', this allows us to pick up objective methods as well as
c style function definitions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

thj requested review of this revision.Feb 8 2022, 1:51 PM

don't forget to add a unit test

This revision is now accepted and ready to land.Feb 8 2022, 2:36 PM
  • Add tests for finding function names
This revision now requires review to proceed.Feb 10 2022, 3:17 PM

Other than that wording tweak, spelling and grammar in manual page change LGTM.

usr.bin/diff/diff.1
400
This revision is now accepted and ready to land.Feb 11 2022, 7:16 PM
jilles added inline comments.
usr.bin/diff/tests/functionname_objcm.in
22

Fortunately, this code is never run :) The pointer subtraction is immediate undefined behaviour.

This revision was automatically updated to reflect the committed changes.