Page MenuHomeFreeBSD

zdiff: avoid non-conformant features
ClosedPublic

Authored by kevans on May 20 2022, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 8, 1:24 AM
Unknown Object (File)
Fri, Mar 6, 8:06 PM
Unknown Object (File)
Fri, Mar 6, 7:39 AM
Unknown Object (File)
Tue, Mar 3, 8:42 AM
Unknown Object (File)
Tue, Mar 3, 2:03 AM
Unknown Object (File)
Sat, Feb 28, 9:32 PM
Unknown Object (File)
Thu, Feb 26, 2:29 AM
Unknown Object (File)
Feb 9 2026, 12:05 AM
Subscribers

Details

Summary

setvar is a non-conformant feature that looks slightly neater but is
not portable to other /bin/sh implementations. Making the script
portable is straightforward, so let's do it.

Tests are added to make sure that I didn't break anything major in the
process.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 21 2022, 12:27 PM
jilles requested changes to this revision.May 21 2022, 1:36 PM
jilles added inline comments.
usr.bin/gzip/zdiff
41–42

This used to work with filenames containing ", ` and $ but no longer does. Likewise for all other eval "$2= below.

This revision now requires changes to proceed.May 21 2022, 1:36 PM
kevans marked an inline comment as done.

Fix files containing ", `, and $. Add tests to cover those names, as well, for
all of these cases.

This revision is now accepted and ready to land.May 26 2022, 4:35 PM
This revision was automatically updated to reflect the committed changes.