Page MenuHomeFreeBSD

zdiff: avoid non-conformant features

Authored by kevans on May 20 2022, 8:47 PM.



setvar is a non-conformant feature that looks slightly neater but is
not portable to other /bin/sh implementations. Making the script
portable is straightforward, so let's do it.

Tests are added to make sure that I didn't break anything major in the

Sponsored by: Klara, Inc.

Diff Detail

rG FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.May 21 2022, 12:27 PM
jilles requested changes to this revision.May 21 2022, 1:36 PM
jilles added inline comments.

This used to work with filenames containing ", ` and $ but no longer does. Likewise for all other eval "$2= below.

This revision now requires changes to proceed.May 21 2022, 1:36 PM
kevans marked an inline comment as done.

Fix files containing ", `, and $. Add tests to cover those names, as well, for
all of these cases.

This revision is now accepted and ready to land.May 26 2022, 4:35 PM
This revision was automatically updated to reflect the committed changes.