Page MenuHomeFreeBSD

Bump amount of queued packets in for unresolved ARP/NDP entries to 16.
ClosedPublic

Authored by melifaro on Jan 9 2021, 7:27 PM.

Details

Summary

Bump amount of queued packets in for unresolved ARP/NDP entries.

Currently we default to keep only 1 packet per unresolved entry.
Ability to queue more than one packet was added 10 years ago, in r215207, though the default hasn't changed since then.

Things have changed since that time. Systems tend to initiate multiple connections at once for a variety of reasons.

For example, recent PR252278 describe happy-eyeball DNS behaviour sending multiple requests to the DNS server.

The primary reason for value determination is memory consumption: remote actors should not be able to easily exhaust local memory by sending packets to unresolved arp/ND entries.

So we should land something around D22447 before merging it back to stable.

Linux folks bumped the limit multiple times: 2011 2017.
TL;DR: they moved limit from 3 packets to 64kb, then to the variable depending on the amount of available system memory.

With all that in mind, I'm going to bump the current limit to 16 and work on implementing neigh limits.
I guess it's a bit late to convert the neigh limits from per-packet to per-queue to have it hit 13.0, but we certainly need to convert it at some point.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gbe added a subscriber: gbe.

LGTM from manpages

jilles added inline comments.
usr.sbin/arp/arp.4
52–55

I suppose this clause should be plural as well now.

melifaro retitled this revision from Bump amount of queued packets in case of unresolved ARP/NDP entry. to Bump amount of queued packets in for unresolved ARP/NDP entries to 16..Jan 9 2021, 8:05 PM
melifaro edited the summary of this revision. (Show Details)
melifaro added reviewers: network, bz, emaste.
This revision is now accepted and ready to land.Jan 9 2021, 8:17 PM
melifaro edited the summary of this revision. (Show Details)

Address comments; remove stale parts from the manpage.

This revision now requires review to proceed.Jan 9 2021, 8:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 11 2021, 8:01 PM
This revision was automatically updated to reflect the committed changes.