Page MenuHomeFreeBSD

Fix /root permissions after 'make installworld'
ClosedPublic

Authored by gbe on Oct 29 2023, 6:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 11:13 AM
Unknown Object (File)
Wed, Oct 1, 12:04 AM
Unknown Object (File)
Sun, Sep 28, 11:53 PM
Unknown Object (File)
Aug 31 2025, 10:05 AM
Unknown Object (File)
Jul 21 2025, 10:46 AM
Unknown Object (File)
Jul 13 2025, 6:10 PM
Unknown Object (File)
Jul 2 2025, 10:39 AM
Unknown Object (File)
Jun 25 2025, 6:31 PM

Details

Summary

According to /etc/mtree/BSD.root.dist /root should have
0750 permissions, but "make installworld" changes these to 0755.

This is caused by the installation of configuration directories
of "csh" and "sh".

Correct these by specifing the correct default /root permissions.

PR: 273342

Test Plan

make buildworld && make instalworld

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gbe requested review of this revision.Oct 29 2023, 6:40 AM

Tested by myself on head, stable/14 and releng/14.0.

Wouldn't it make more sense, to match the default set in etc/mtree/BSD.root.dist? Otherwise, if someone adjusts BSD.root.dist, there's a conflict again (as it already happend with D23392).

This looks like a reasonable quick fix, but I think it's unfortunate the /root directory permissions are specified both in bsd.dirs.mk variables and in the BSD.root.dist mtree file. It looks like the bsd.dirs.mk variables are required because of pkgbase.

This revision is now accepted and ready to land.Nov 14 2023, 10:06 PM