Page MenuHomeFreeBSD

stty(1): provide details about interaction with job control
ClosedPublic

Authored by kib on Sep 27 2022, 12:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 12 2024, 12:54 AM
Unknown Object (File)
Mar 12 2024, 12:54 AM
Unknown Object (File)
Mar 12 2024, 12:54 AM
Unknown Object (File)
Mar 12 2024, 12:54 AM
Unknown Object (File)
Mar 12 2024, 12:54 AM
Unknown Object (File)
Mar 12 2024, 12:54 AM
Unknown Object (File)
Mar 12 2024, 12:54 AM
Unknown Object (File)
Mar 12 2024, 12:54 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Sep 27 2022, 12:26 PM
kib added a reviewer: manpages.
emaste added inline comments.
bin/stty/stty.1
104

"not prepared to handle it" or "not prepared for it"

kib marked an inline comment as done.

Grammar fix by emaste.
More man page updates.

Since a similar effect can be obtained by having the shell ignore the signal via trap '' TTOU, I'm not sure it's a good idea to add an option for this.

An addition to the man page may be a good idea, though, since this effect of the disposition of SIGTTOU is listed in tcsetattr(3) but not in section 1 man pages.

bin/stty/stty.c
74 ↗(On Diff #111076)

Because various operands to stty start with - and do not need --, every option added makes it more likely to get a conflict between an option and an operand. This suggests only adding options when it is extremely important, and perhaps using uppercase for options to make conflicts less likely.

kib retitled this revision from stty(1): add -i option to ignore SIGTTOU to stty(1): provide details about interaction with job control.
kib edited the summary of this revision. (Show Details)
kib edited reviewers, added: jilles; removed: manu.
kib removed a subscriber: jilles.

Drop -i addition.

pauamma_gundo.com added inline comments.
bin/stty/stty.1
604
605
606

Since it's a symbolic constant.

609
611

Make it clear we don't mean open(2) or fopen(3) flags.

613
620
This revision now requires changes to proceed.Sep 28 2022, 7:53 PM
kib marked 7 inline comments as done.Sep 28 2022, 8:22 PM
kib added inline comments.
bin/stty/stty.1
611

It is open(2) O_NONBLOCK. It is mentioned earlier in the man page, in the description of -f.

kib marked an inline comment as done.

Pauamma comments

One minor manual page nit, fixable on commit.

bin/stty/stty.1
613

Should be above the .Pp.

This revision is now accepted and ready to land.Oct 1 2022, 3:58 AM
kib marked an inline comment as done.Oct 1 2022, 2:59 PM
kib added inline comments.
bin/stty/stty.1
613

Should be .Nm

kib marked an inline comment as done.

Stray .Pp, should be .Nm

This revision now requires review to proceed.Oct 1 2022, 3:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2022, 5:32 PM
This revision was automatically updated to reflect the committed changes.