Page MenuHomeFreeBSD

sh: nullify ENV in tests
ClosedPublic

Authored by pstef on Jul 21 2022, 6:45 PM.
Tags
None
Referenced Files
F103494957: D35876.id109598.diff
Mon, Nov 25, 6:01 PM
Unknown Object (File)
Sat, Nov 16, 6:47 AM
Unknown Object (File)
Sat, Nov 16, 6:45 AM
Unknown Object (File)
Sat, Nov 16, 3:51 AM
Unknown Object (File)
Sep 27 2024, 6:30 PM
Unknown Object (File)
Sep 24 2024, 10:11 AM
Unknown Object (File)
Sep 24 2024, 6:33 AM
Unknown Object (File)
Sep 17 2024, 12:33 PM
Subscribers

Details

Summary

This is to avoid loading .shrc which may contain commands that would result in output different than expected.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pstef requested review of this revision.Jul 21 2022, 6:45 PM

Thanks, I have also encountered this issue.

Perhaps this approach, adding ENV= before $SH -i uses in test scripts, is best since it supports running single test scripts without any wrapping. There are not that many test scripts that use interactive mode.

This revision is now accepted and ready to land.Jul 22 2022, 8:47 AM
This revision was automatically updated to reflect the committed changes.