sh: Don't add something to a null pointer
ClosedPublic
Actions

Authored by jilles on Jan 23 2022, 9:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 29, 3:27 AM

	Unknown Object (File)
	Wed, Jun 24, 6:25 AM

	Unknown Object (File)
	Tue, Jun 23, 2:42 AM

	Unknown Object (File)
	Wed, Jun 17, 6:11 AM

	Unknown Object (File)
	Wed, Jun 17, 4:45 AM

	Unknown Object (File)
	Mon, Jun 8, 9:51 PM

	Unknown Object (File)
	May 18 2026, 12:34 AM

	Unknown Object (File)
	May 18 2026, 12:34 AM

View All Files

Subscribers

imp

markmi_dsl-only.net

Details

Reviewers

bdrewery
imp

Commits

rG5a1a07f2a0e1: sh: Don't add something to a null pointer

Summary

Pointer arithmetic on a null pointer is undefined behavior.

The bug can be reproduced by running bin/sh/tests/builtins/wait6.0 with
UBSAN.

Test Plan

kyua test

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jilles created this revision.Jan 23 2022, 9:28 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2022, 9:28 PM

jilles requested review of this revision.Jan 23 2022, 9:28 PM

imp accepted this revision.Jan 24 2022, 12:00 AM

This revision is now accepted and ready to land.Jan 24 2022, 12:00 AM

Closed by commit rG5a1a07f2a0e1: sh: Don't add something to a null pointer (authored by jilles). · Explain WhyJan 26 2022, 10:18 PM

This revision was automatically updated to reflect the committed changes.

jilles added a commit: rG5a1a07f2a0e1: sh: Don't add something to a null pointer.

Revision Contents
Changeset List

Path

Size

bin/

sh/

jobs.c

2 lines

Diff 101965

View Options

sh: Don't add something to a null pointerClosedPublicActions