Page MenuHomeFreeBSD

sh/tests: Cut down builtins/read12.0 by 2 seconds
Needs ReviewPublic

Authored by jilles on Sun, Feb 8, 11:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 5, 3:23 PM
Unknown Object (File)
Mon, Mar 2, 9:29 PM
Unknown Object (File)
Wed, Feb 11, 11:11 AM
Unknown Object (File)
Wed, Feb 11, 6:02 AM
Unknown Object (File)
Wed, Feb 11, 4:52 AM
Unknown Object (File)
Tue, Feb 10, 7:39 AM
Unknown Object (File)
Tue, Feb 10, 6:18 AM
Unknown Object (File)
Sun, Feb 8, 11:31 PM
Subscribers

Details

Reviewers
des
Summary

Since the test assumes a 250 ms response time, the test delay can be 1
second instead of 3.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70533
Build 67416: arc lint + arc unit

Event Timeline

Since the test assumes a 250 ms response time, the test delay can be 1 second instead of 3.

That is a complete non sequitur.

Why does the test need to be shortened?

In D55191#1261862, @des wrote:

Since the test assumes a 250 ms response time, the test delay can be 1 second instead of 3.

That is a complete non sequitur.

Why does the test need to be shortened?

To make it nicer to develop sh(1), I have gone to great lengths to make its tests fast. Avoiding sleeps also improves reliability of the tests.

I am aware that tests for other parts of the system may be unnecessarily slow.