Page MenuHomeFreeBSD

bsddialog: Correct type for bsddialog_total_progview
ClosedPublic

Authored by emaste on May 9 2025, 12:41 AM.
Tags
None
Referenced Files
F165437578: D50261.id.diff
Sat, Aug 8, 5:14 AM
F165357176: D50261.id155208.diff
Fri, Aug 7, 7:50 PM
F165353442: D50261.id155167.diff
Fri, Aug 7, 7:25 PM
Unknown Object (File)
Wed, Aug 5, 9:01 AM
Unknown Object (File)
Tue, Aug 4, 8:29 AM
Unknown Object (File)
Sun, Aug 2, 4:49 PM
Unknown Object (File)
Sat, Aug 1, 7:07 AM
Unknown Object (File)
Fri, Jul 31, 3:54 AM
Subscribers

Details

Summary
It was an int, but printed with %lli format.  Although it would be
reasonable to use a 32-bit int here (i.e., changing the printf format
instead) this matches what was done in bsddialog upstream (and now in
main).

PR:             286655

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
emaste added a reviewer: jhb.

OK, I remember the problem described in PR286655, I found it testing the installer on a 32bit (cheap) raspberry and watching a video on youtube (2 years ago). Of course "num extracted bytes" > "max int", I obseverd things like "-676330 files read" (negative num).
I fixed like in this review and now it is in main/CURRENT: I kept %lli because previously libdpv printed a %lli and I changed int to long long int.

This revision is now accepted and ready to land.May 9 2025, 4:52 PM

I fixed like in this review and now it is in main/CURRENT

Yeah; after 14.3 is out I think we should MFC the bsddialog updates. For now I just wanted a minimal change.