It was an int, but printed with %lli format. Although it would be reasonable to use a 32-bit int here (i.e., changing the printf format instead) this matches what was done in bsddialog upstream (and now in main). PR: 286655
Details
Details
- Reviewers
asiciliano jhb - Group Reviewers
releng - Commits
- rGa9b30c92ab1c: bsddialog: Correct type for bsddialog_total_progview
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
OK, I remember the problem described in PR286655, I found it testing the installer on a 32bit (cheap) raspberry and watching a video on youtube (2 years ago). Of course "num extracted bytes" > "max int", I obseverd things like "-676330 files read" (negative num).
I fixed like in this review and now it is in main/CURRENT: I kept %lli because previously libdpv printed a %lli and I changed int to long long int.
Comment Actions
I fixed like in this review and now it is in main/CURRENT
Yeah; after 14.3 is out I think we should MFC the bsddialog updates. For now I just wanted a minimal change.