Thank you for the review, I updated to fix.

In D50894#1177756, @grahamperrin wrote:

In the preview, some of the navigation buttons don't work, for example:

• Next at https://freebsd-accessibility-9d667f.gitlab.io/en/books/accessibility/partii/index.html
• Prev at https://freebsd-accessibility-9d667f.gitlab.io/en/books/accessibility/development/index.html

Thank you for the review. I updated the diff to fix

Thank you for the review. I updated the diff to fix.

In D50894#1169940, @pauamma_gundo.com wrote:

One minor nit I missed the first time through, but I think what's already written works as is. Do you plan to commit this in stages, or in a single commit once complete?

Thank you for the review, I updated the diff to fix.

Thank you very much for the review. I’ve updated the diff to incorporate the suggestions and improvements.

Thank you for the review, I'll update to fix.

Fix: pane(s) -> panel(s)

In D44280#1147015, @khorben_defora.org wrote:

Also noteworthy in terms of UX:

• With bsddialog, the <TAB> key will go straight from the first input field to the [ OK ] button; the "arrow down" key should be used instead.

OK, I remember the problem described in PR286655, I found it testing the installer on a 32bit (cheap) raspberry and watching a video on youtube (2 years ago). Of course "num extracted bytes" > "max int", I obseverd things like "-676330 files read" (negative num).
I fixed like in this review and now it is in main/CURRENT: I kept %lli because previously libdpv printed a %lli and I changed int to long long int.

In D48668#1110114, @jlduran wrote:

After a simple:

grep -r -A3 "case 10" contrib/bsddialog/

I could not find any other occurrence that needs fixing.

Probably the review title and description can be changed, because it wants to introduce GUI for timezone. (Otherwise, if its purpose is adding backtitle to tzsetup (timezone) we can add just 5-6 lines to tzsetup.c :D). Maybe:

In D44670#1018433, @khorben_defora.org wrote:

However I can look into creating a different version of this replacement of timezone with some tweaking in bsdconfig instead.

I fixed in upstream (https://gitlab.com/alfix/bsddialog/-/commit/ce220b82ad546d3518a805750e5ee6add73f1fbf) because the problem also appears in other places in this file. I'll test and import the new version 1.0.3 by 2-3 days.

Ok, I have the same patch locally.

LGTM

LGTM. I tested the new selectdists file in the my XFCE Terminal. I wrote some tip, you can consider or ignore.

New solution.

In D41507#949813, @pauamma_gundo.com wrote:

Maybe, now that the call for testing is out, add a link to https://lists.freebsd.org/archives/freebsd-accessibility/2023-August/000034.html at the end of the report so people know how to test?

Thanks for the review, I updated to fix.

In D41507#945746, @carlavilla wrote:

Please use one sentence per line and the package macro.
If you don’t know how to use the macro tell me and I’ll help.

Btw, looks good, thanks for this improvement!

@carlavilla I fixed one sentence per line, but I don't know package macro and how to use them.

In D35754#943208, @markj wrote:

In D35754#943181, @asiciliano wrote:

I am interested to take/continue this feature. Are others already working?

Not that I've seen. I think there are two major things which need to be addressed: the userspace interface should be converted to use file descriptors rather than sysctls, and we should find a way to avoid making term_char_t larger.

I am interested to take/continue this feature. Are others already working?

I am interested to take/continue this feature. Are others already working?

I am interested to take/continue this feature. Are others already working?

Thank you for the review, the updated diff should fix.

ping @dteske

Abandon: this replacement can be implied just by changing the $DIALOG variable in bsdconfig.

Abandon: uses struct sysctl_oid definition previous FreeBSD 1400071