Page MenuHomeFreeBSD

bsdinstall: Fix newfs bsddialog menu
ClosedPublic

Authored by emaste on Fri, Nov 7, 10:58 PM.
Tags
None
Referenced Files
F135399462: D53639.id166052.diff
Sun, Nov 9, 12:25 PM
F135366026: D53639.id166070.diff
Sun, Nov 9, 4:02 AM
Unknown Object (File)
Sat, Nov 8, 7:22 PM
Unknown Object (File)
Sat, Nov 8, 7:54 AM
Unknown Object (File)
Sat, Nov 8, 6:18 AM
Unknown Object (File)
Sat, Nov 8, 3:17 AM
Unknown Object (File)
Sat, Nov 8, 2:05 AM
Unknown Object (File)
Sat, Nov 8, 1:18 AM
Subscribers

Details

Summary
The first 3 members of struct bsddialog_menuitem are:

                   const char *prefix;
                   bool on;
                   unsigned int depth;

The newfs dialog options in bsdinstall's partition tool had on and depth
swapped, so the defaults did not work.

PR: 290857
Fixes: 50e244964e9b ("bsdinstall/partedit: Replace libdialog with libbsddialog")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
213

Separately this should probably just be -F 32 without -c 1. I will look at that and post a patch after testing.

Thank you for finding this issue and the fix.

This revision is now accepted and ready to land.Fri, Nov 7, 11:09 PM
This revision was automatically updated to reflect the committed changes.