Page MenuHomeFreeBSD

bsdinstall: Fix newfs bsddialog menu
ClosedPublic

Authored by emaste on Nov 7 2025, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 12, 7:03 PM
Unknown Object (File)
Mon, May 11, 10:09 PM
Unknown Object (File)
Sun, May 10, 10:53 PM
Unknown Object (File)
Thu, Apr 30, 6:55 AM
Unknown Object (File)
Tue, Apr 28, 2:26 AM
Unknown Object (File)
Mon, Apr 27, 10:31 AM
Unknown Object (File)
Sun, Apr 26, 11:05 AM
Unknown Object (File)
Wed, Apr 22, 3:30 AM
Subscribers

Details

Summary
The first 3 members of struct bsddialog_menuitem are:

                   const char *prefix;
                   bool on;
                   unsigned int depth;

The newfs dialog options in bsdinstall's partition tool had on and depth
swapped, so the defaults did not work.

PR: 290857
Fixes: 50e244964e9b ("bsdinstall/partedit: Replace libdialog with libbsddialog")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
213

Separately this should probably just be -F 32 without -c 1. I will look at that and post a patch after testing.

Thank you for finding this issue and the fix.

This revision is now accepted and ready to land.Nov 7 2025, 11:09 PM
This revision was automatically updated to reflect the committed changes.