devel/subversion{,-lts}: remove port option STATIC

[michaelo]

Summary

Since the switch to CMake for textproc/utf8proc
(207abfe1369d1ef1d89fae73b1091b37b9060ef7) the static library is not being built
anymore. This means that the static build of Subversion has been broken since
2022-01. For the past two years only one has complained (PR 279430) and
the maintainer of textproc/utf8proc (PR 280429) cannot easily provide an archive
with CMake anymore. Therefore, removing the STATIC port option for good.

PR: 279430
Approved by: jrm (mentor), otis (mentor), diizzy

[michaelo]

Formatting

[michaelo]

Remove port option STATIC

[diizzy]

You likely don't want to remove the contents in post-install-STATIC-off

[michaelo]

Address diizzy's comment

[jrm]

devel/subversion-lts/Makefile.common

25

Can you confirm that removing --with-sqlite is intentional? Without context, this seems unrelated.

devel/subversion/Makefile.common

25

Same comment as above.

[michaelo]

devel/subversion-lts/Makefile.common

25

Yes, it is on purpose. SQLite is a mandatory requirement. When this option isn't passed, the autoconf system will fall back to pkgconf automatically adding all required linktime and runtime libs to it. When passed directly, it shorthands. Here is the the m4 macro: https://github.com/apache/subversion/blob/097a445d8ec5f27a8086aabe5d345b8bead41f50/build/ac-macros/sqlite.m4#L76-L101

[michaelo]

@jrm, this happens when pkgconf is not present:

configure: serf library configuration via pkg-config
checking was serf enabled... no

An appropriate version of serf could not be found, so libsvn_ra_serf
will not be built.  If you want to build libsvn_ra_serf, please
install serf 1.3.4 or newer.

configure: looking for apr_memcache as part of apr-util
checking apr_memcache.h usability... yes
checking apr_memcache.h presence... yes
checking for apr_memcache.h... yes
checking for apr_memcache_create in -laprutil-1... yes
checking for Apache module support via DSO through APXS... no
==================================================================
WARNING: skipping the build of mod_dav_svn
         try using --with-apxs
==================================================================
configure: checking sqlite library
checking sqlite amalgamation... no
checking sqlite amalgamation... no
checking sqlite3.h usability... no
checking sqlite3.h presence... no
checking for sqlite3.h... no
no

An appropriate version of sqlite could not be found.  We recommmend
3.8.11.1, but require at least 3.8.2.
Please either install a newer sqlite on this system

or

get the sqlite 3.8.11.1 amalgamation from:
    https://www.sqlite.org/2015/sqlite-amalgamation-3081101.zip
unpack the archive using unzip and rename the resulting
directory to:
/wrkdirs/usr/ports/devel/subversion-lts/work/subversion-1.14.3/sqlite-amalgamation

configure: error: Subversion requires SQLite

[michaelo]

@diizzy , can you please have another sharp look at this?

[diizzy]

Passes Poudriere and lgtm,

While out of scope for the PR perhaps it's time to retire the -lts port given upstream development?

[michaelo]

In D46096#1053797, @diizzy wrote:

Passes Poudriere and lgtm,

While out of scope for the PR perhaps it's time to retire the -lts port given upstream development?

Why? Both branch ideas are supported upstream and the effort is minimal.

[diizzy]

We seem to be the only ones doing this looking at https://repology.org/project/subversion/versions and upstream development seems to have slowed down?