net/wifi-firmware-*: build framework and license hack cleanup

[bz]

Summary

Cleanup the extra layer of "flavour" that came into the build framework
when flavours were introduced at a time when it was not planned.
Make linters some more happy. [1]

Remove the special license hack to install additional files.
If DISABLE_LICENSES is set we still installed files making builds fail [2].
One would hope to always install the lincese files but simply disable
any checking by the framework.
Introduce a new way using LICENSE_COMB=multi to install the default
license file, the extra WHENCE and any possible extra firmware license
files. Technically this is an abuse of the system too but at least it
should work and not break non default options.

Based on: D45369 by jrm [1]
Reported by: pi [2]
Sponsored by: The FreeBSD Foundation

Test Plan

None yet; someone with a clean ports build setup should probably try this out.

[bz]

net/wifi-firmware-kmod/Makefile.inc

44

Add extra firmware *license* files.

[jrm]

net/wifi-firmware-kmod/Makefile.inc

46

I did a quick test, and I got build failures.

https://pkg.ftfl.ca/build.html?mastername=15amd64-default&build=2024-08-01_13h38m25s

Removing this line fixed the build.

[bz]

net/wifi-firmware-kmod/Makefile.inc

46

It seems that the :range of
FOO=
and
FOO= 1
both evaluate to 1. So if there is no license it still tries to add one if the variable is defined; if the variable was not defined at all there likely was an error.
Can you try the update which comes in a few minutes?

[bz]

Try to fix the ;range check in case the variable is not defined or defined
without value; in the latter case :range seems to still evaluate to 1.

FLAVORS=a b c d

DISTFILES_a_lic=        1 2 3
DISTFILES_b_lic=
DISTFILES_c_lic=        7

all:
.for FLAVOR in ${FLAVORS}
.if "${DISTFILES_${FLAVOR}_lic}"
        @echo "FLAVOR '${FLAVOR}' : " ${DISTFILES_${FLAVOR}_lic:range}

.for _n in ${DISTFILES_${FLAVOR}_lic:range}
        @echo "  ${_n}"
.endfor
.endif
.endfor

[jrm]

Build succeeds.