Looks good to me.

LGTM. I flagged a few other optional nits.

Thanks. Looks good. Could you also run it through something like portlint -AC and portclippy/portfmt?

To elaborate, I felt that specifically checking for the issue at hand is unlikely to introduce any new problems, but adding set -e, which, of course, affects the whole script is more likely. That said, since @michael is prepared to take on any new problems, I'm fine either way.

In D42719#1021238, @mandree wrote:

In D42719#1020644, @jrm wrote:

@michaelo, thanks for sticking with this review. My preference is still to go with the || exit \$? with or without the set -e.

@jrm I have not understood the motivation to avoid set -e. My standard is to "set -eu" to trap maintainer oversights, which happen quickly. And possibly even "set -o pipefail" if I know the shell supports it (if bash has been ensured some way).
My clear preference is set -e and stop polluting the code with || exit and what not. You want robust scripts? Then you want error checking EVERYWHERE. I abhor scripts that run past errors and pretend they had completed and possibly even leave exit code 0...

@michaelo, thanks for sticking with this review. My preference is still to go with the || exit \$? with or without the set -e.

LGTM However, someone from portmgr should approve. I'll try to get someone to look today.

Also chase editors/emacs update

I'll commit now and incorporate @pauamma_gundo.com's suggestion.

In D44291#1012493, @jfree wrote:

Hey @jrm, efnet seems to be down so I can't ask you this over IRC. I keep getting freefall build failures for i386-quarterly. Would it be ok to push my changes to the relevant quarterly branches?

I committed these in two separate commits.

Hi Chris,

@cperciva, it would be good to get your approval here as well.

portfmt has two suggestions:

Looks good to me unless @vvd has something actionable regarding runtime issues.

It looks good on 14.0 amd64. http://pkg.ftfl.ca/data/14amd64-default/2024-03-05_19h14m11s/logs/eclipse-4.24_2.log

FYI, devel/eclipse failed in my 15.0-CURRENT 1500008 amd64 jail.

Everything looks good.

@chs, what should I look for to confirm the update has been applied?