Page MenuHomeFreeBSD

Mk/: Possible values for "ssl" are inconsistent
ClosedPublic

Authored by michaelo on Jul 22 2024, 11:26 AM.
Tags
None
Referenced Files
F104061101: D46059.id141218.diff
Tue, Dec 3, 12:31 AM
Unknown Object (File)
Oct 30 2024, 8:02 AM
Unknown Object (File)
Oct 4 2024, 3:49 PM
Unknown Object (File)
Oct 4 2024, 10:32 AM
Unknown Object (File)
Oct 3 2024, 10:09 PM
Unknown Object (File)
Oct 2 2024, 8:49 AM
Unknown Object (File)
Oct 2 2024, 2:26 AM
Unknown Object (File)
Oct 1 2024, 11:33 PM
Subscribers

Details

Summary

PR: 279430
Approved by: jrm (mentor), otis (mentor), brnrd

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo created this revision.
This revision is now accepted and ready to land.Jul 23 2024, 10:04 PM

Should add portmgr as a reviewer? There may be a server-side git hook to ensure commits under Mk/ are approved by them.

In D46059#1052323, @jrm wrote:

Should add portmgr as a reviewer? There may be a server-side git hook to ensure commits under Mk/ are approved by them.

Why not, please do.

We probably need a message on each list asking to keep it in sync with the two other.

Anyone else, any objections?

As I said, we need a message at each location saying "update the two other locations", please add it.

Something like this

Mk/Scripts/qa.sh
625–630
Mk/Uses/ssl.mk
11–15
Mk/bsd.default-versions.mk
149–151
In D46059#1053623, @mat wrote:

Something like this

I see what you are after now, thanks.

This revision now requires review to proceed.Aug 3 2024, 10:27 AM

Issues addressed.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 3 2024, 4:01 PM
This revision was automatically updated to reflect the committed changes.