mat, we will be in for major cleanup if the -iWHATEVER option is not overridable, and people will rather reimplement their own REINPLACE_CMD replacements if you mutilate it to the point it can no longer be adapted. My sed_checked.sh that you dismissed calling it names already validates arguments... https://reviews.freebsd.org/D24240 needs a proper technical review and approval, not something polemic or political, to end the stream of other issues with REINPLACE_CMD.

Michael, also see https://reviews.freebsd.org/D24240 for an in-depth fix to most things. I'd like to know if with my changed sed_checked.sh, your problem reproduces. (Note that the original change was prior to a relocation from Tools/scripts to Mk/Scripts)

since swills@ has reverted this as of r552736, reopen.

approved

Unfortunately though, util-linux conflicts with other packages, partial list in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251489

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251489 came up with a reason to restart this endeavour. Any takers for getting the patch updated? If someome wants to take responsibility, use the action "commandeer revision" which makes you the new owner.

Approved of for net/unison232.

In D26924#600684, @madpilot wrote:

@madpilot for unison232, approved. Be sure to keep the changes from https://reviews.freebsd.org/rP553182 in your tree (i. e. update) before committing your patch.

Ho-hum, generally this looks good but now my point is I can't get unison232 to function (run-time), it tries to read its ~/.unison/default.prf, closes it, then prints 15 bytes of garbage to stderr and then SIGSEGV and the kernel disposes of it. FreeBSD 12.1-amd64.

I might find breaking out one build into multiple packages very useful,
but for a successful launch I propose this would require a proper specification added to the documentation. Documentation by example is no good for developers who are new to this feature.
I wonder if there should be an option for split-out pkg-plist files, which would be much easier to understand.

see inline comment

Please also see my new inline comments above.

@rene can you PLEASE stop editing all the many .if lines and updating them from >= [11.3] to >= [11.4] and similar, in particular (1) graphics/drm-kmod/ (2) graphics/linux-c7-libdrm and (3) sysutils/ebsnvme-id
I repeat, these are .if lines that check behaviour for past versions of FreeBSD - and their past behaviour does not change with 11.3 becoming EOL, it does not make sense to update these version limits, it will only be confusing for people when they debug and touch history.

There is also a bug on deinstall if a @sample keyword is used with only one argument that does NOT end in .sample: in that case, the configuration file is copied onto itself on install, and on deinstall, it is compared to itself, found matching, and removed. Arguably, this can also be caught in the stage-qa phase and would also be clobbered on update, but it should be flagged so that the offending package's pkg-plist can be fixed. I have seen and fixed such bugs in the wild.

This is broken and causes leftover files in the poudriere testport security/ca_root_nss, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250415
Please revise.

what needs to happen to get this tested, approved, and moving?

uh, this should not have been closed - the commit tracking interface is a bit too simplistic and is not up for partial commits. Reopening.

I am adding a few inline comments (not thorough), please review them and then omit blunt sweeping OSVERSION changes.

Rationale first, then the request in the bottom three lines in boldface.

Rene, for graphics/rawtherapee I will need to investigate first. Thanks for the reminder.

OK, then this will escalate to core@ for abuse because there has been no feedback as to why it's unacceptable in spite of solving practical problems.

ping