User Details
- User Since
- Jun 12 2014, 10:01 AM (467 w, 6 d)
Sun, May 28
Fri, May 19
Tue, May 16
Sat, May 13
LGTM, but other than the relocation; I see no difference. Tested with
Fri, May 5
Apr 28 2023
Apr 23 2023
Apr 17 2023
Apr 15 2023
Apr 13 2023
Apr 7 2023
Apr 1 2023
Mar 30 2023
I also wonder why we don't install a 3.7+ compatible Python script and call that from the lua trigger. It would be far more useful (as in count of available developers) to write this in Python and not Lua, and we'd get proper debugging and logging libs for free. Lua is a bit minimalistic for the rather complex task at hand.
As a more general comment, I removed some immature code. I am not too troubled about *how* we solve it, but we need robust code that properly traps errors, properly reports them, and is fully tested, and DOES NOT GET COMMITTED BEFORE it's properly tested and approved by all. Python isn't your average leaf port sandbox in the playground, but high-profile stuff. And we surely should not comment anything in the next few days (hours) before 2023Q2 has branched. If something is mature and does not break semantics of other ports, we can still MFH to quarterly later, or just really clean up for 2023Q3 before July.
Mar 28 2023
Mar 24 2023
Mar 22 2023
Mar 21 2023
Mar 19 2023
Mar 18 2023
Mar 12 2023
@jbeich wrote to the mailing lists:
this isn't working properly. Reopening
Mar 8 2023
Mar 4 2023
Mar 2 2023
Feb 28 2023
Also, there is practically no error checking and handling. This seems inappropriate for code that is applied to high-profile ports with lots of users.
we cannot have duplicated code all around. This is unmaintainable, error-prone, and Charlie has not given any non-refuted reason that would justify code duplication.
@vishwin remove me again from reviewers and that will have grave consequences.
So, the trigger is redundantly duplicated across all Python versions. This is bad style and error-prone.
Feb 27 2023
@tcberner please make sure that and how your mentees request -exp runs for major changes. Let me know if you need a hand.
Feb 26 2023
Feb 20 2023
Feb 18 2023
Feb 16 2023
Feb 11 2023
Feb 9 2023
Note this introduces an extra PATH search for systems that do NOT yet have nproc so perhaps we need to add some OSVERSION switch here.