ca_root_nss
ClosedPublic
Actions

Authored by michaelo on Thu, Oct 17, 10:29 AM.

Details

Reviewers

jrm
otis
kevans
des
driesm

Summary

PR: 282155
Approved by: jrm (mentor), otis (mentor), kevans, des

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60055
Build 56939: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Thu, Oct 17, 10:29 AM

michaelo created this revision.

Harbormaster completed remote builds in B60055: Diff 145025.Thu, Oct 17, 10:29 AM

Assuming @kevans or @des don't chime in to say something is missing in the base certificate store, lgtm.

This revision is now accepted and ready to land.Thu, Oct 17, 3:14 PM

In D47164#1075300, @jrm wrote:

Assuming @kevans or @des don't chime in to say something is missing in the base certificate store, lgtm.

Yep, ugly code never dies: https://github.com/composer/ca-bundle/blob/66457b8698063a414b782c859b6d3bac3dc357b3/src/CaBundle.php#L83-L98

No objections received, maintainer timeout. Will go ahead and merge it.

Didn't notice that the devel port is maintained by @driesm ...

Np, go ahead!

Change merged.

Revision Contents
Changeset List

Path

Size

sysutils/

vm-bhyve-devel/

Makefile

3 lines

vm-bhyve/

Makefile

4 lines

Diff 145025

View Options

sysutils/vm-bhyve-devel/Makefile