Page MenuHomeFreeBSD

dhclient: Ignore SIP servers DHCP option defined in RFC 3361
ClosedPublic

Authored by michaelo on Jul 4 2024, 6:13 PM.
Tags
None
Referenced Files
F103096068: D45873.id140555.diff
Wed, Nov 20, 10:22 PM
Unknown Object (File)
Tue, Nov 19, 6:46 PM
Unknown Object (File)
Mon, Nov 18, 12:40 AM
Unknown Object (File)
Mon, Nov 18, 12:39 AM
Unknown Object (File)
Wed, Nov 13, 10:25 PM
Unknown Object (File)
Tue, Nov 12, 7:14 AM
Unknown Object (File)
Oct 19 2024, 6:56 PM
Unknown Object (File)
Oct 17 2024, 7:40 AM
Subscribers

Details

Summary

Ignore SIP servers dhcp option to shut up the warning message.
This option is defined in the RFC 3361 and sent from NSD-G1000T router.

PR: 280119

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm added a subscriber: brooks.

RFC 3361 declares 120 to be the code for the option, and this is doing the same thing as what's done for other unimplemented options, so this seems fine to me too. I'll add @brooks, a src committer who just touched dhclient, to be sure we're not missing something. Please make sure you use git commit --author to attribute Yuichiro NAITO in the commit logs.

This revision is now accepted and ready to land.Jul 4 2024, 6:35 PM
In D45873#1045890, @jrm wrote:

RFC 3361 declares 120 to be the code for the option, and this is doing the same thing as what's done for other unimplemented options, so this seems fine to me too. I'll add @brooks, a src committer who just touched dhclient, to be sure we're not missing something. Please make sure you use git commit --author to attribute Yuichiro NAITO in the commit logs.

Did that already, gave the reporter full credits.

Seems reasonable to me.