QCOM GENI I²C driver
ClosedPublic
Actions

Authored by phk on Apr 5 2025, 7:00 PM.

Details

Reviewers

adrian
imp

Commits

rG76113680635e: QCOM GENI I²C driver

Summary

This is a from scratch, minimally viable, I²C driver for QCOM's GENI serial engine.

No QCOM documentation is available, so other FOSS device drivers were consulted to figure things out

The driver works on T14s G6 "Snapdragon" hardware, to such a degree that ACPI clients and HID devices work (polling mode & needs modifications to iichid)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

phk requested review of this revision.Apr 5 2025, 7:00 PM

phk created this revision.

adrian added inline comments.Apr 5 2025, 7:37 PM

/usr/src/sys/dev/iicbus/controller/qcom/geni_iic.c
181 ↗	(On Diff #153182)	Are these status bits not documented in linux?
307 ↗	(On Diff #153182)	do you need a space between " and slave?

phk added inline comments.Apr 5 2025, 8:00 PM

/usr/src/sys/dev/iicbus/controller/qcom/geni_iic.c
181 ↗	(On Diff #153182)	They have GPL-2.0'ed .h file with a boatload of #defines, but I would not call it "documentation" Given that this driver is written pretty "blind" I did not want the source to give the impression that I actually know what I'm doing...
307 ↗	(On Diff #153182)	Probably not a bad idea :-)

oh added a subscriber: oh.Apr 7 2025, 9:22 AM

I think it's fine to land as-is and clean it up as we need to.

I'm going to need to write an FDT stub when I get enough clock/reset/gpio/pinmux stuff written anyway, so that'll likely be the next time I poke at this.

Thanks for doing it!