qat: Rename to qat_c2xxx and remove support for modern chipsets
ClosedPublic
Actions

Authored by markj on Jul 14 2022, 3:41 PM.

Details

Reviewers

pauamma_gundo.com
emaste

Group Reviewers

manpages

Commits

rGf4f56ff43dbd: qat: Rename to qat_c2xxx and remove support for modern chipsets

Summary

A replacement driver will be imported, but this replacement does not
attach to Atom C2xxx hardware. So, the existing driver will be kept
around to provide opencrypto offload support.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46504
Build 43393: arc lint + arc unit

Event Timeline

markj created this revision.Jul 14 2022, 3:41 PM

Herald added a reviewer: manpages. · View Herald TranscriptJul 14 2022, 3:41 PM

Herald added a subscriber: imp. · View Herald Transcript

markj requested review of this revision.Jul 14 2022, 3:41 PM

Harbormaster completed remote builds in B46438: Diff 108174.Jul 14 2022, 3:41 PM

markj mentioned this in D34632: Intel (R) QAT driver.Jul 14 2022, 3:47 PM

The qat(4) manual page was deleted, not moved or renamed. Is that deliberate?

In D35817#813191, @pauamma_gundo.com wrote:

The qat(4) manual page was deleted, not moved or renamed. Is that deliberate?

Yes. The new QAT driver has its own manual page, and since qat_c2xxx is specifically for old hardware and won't be receiving improvements beyond the usual maintenance, I don't see much reason to keep a man page for it.

In D35817#813503, @markj wrote:

In D35817#813191, @pauamma_gundo.com wrote:

The qat(4) manual page was deleted, not moved or renamed. Is that deliberate?

Yes. The new QAT driver has its own manual page, and since qat_c2xxx is specifically for old hardware and won't be receiving improvements beyond the usual maintenance, I don't see much reason to keep a man page for it.

I don't like the idea of removing an existing manpage from an existing driver, just on general principles. Can you keep it and rename it appropriately instead?

In D35817#813561, @rpokala wrote:

<grimace>

I don't like the idea of removing an existing manpage from an existing driver, just on general principles. Can you keep it and rename it appropriately instead?

Seconded.

This revision now requires changes to proceed.Jul 17 2022, 9:40 PM

Re-add the manual page.

Harbormaster completed remote builds in B46504: Diff 108396.Jul 21 2022, 4:44 PM

I guess note in the commit message that there's no change to ObsoleteFiles.inc etc. because the new driver will provide the files that have been removed. (Is that the case for all of the firmware files?)

share/man/man4/qat_c2xxx.4
74	We'll want to add an Xr to new qat once it goes in

In D35817#814621, @markj wrote:

Re-add the manual page.

Thanks!

In D35817#814630, @emaste wrote:

I guess note in the commit message that there's no change to ObsoleteFiles.inc etc. because the new driver will provide the files that have been removed. (Is that the case for all of the firmware files?)

Oh hmm, not sure about the firmware files in fact.

In D35817#814638, @markj wrote:

In D35817#814630, @emaste wrote:

I guess note in the commit message that there's no change to ObsoleteFiles.inc etc. because the new driver will provide the files that have been removed. (Is that the case for all of the firmware files?)

Oh hmm, not sure about the firmware files in fact.

I think it's ok. The firmware is installed as kernel modules, e.g., qat_dh895xcc_fw.ko. Some of them have different names with the new driver, but they'll be replaced simply by installing a new kernel, since installkernel wipes out the old one.

In D35817#814649, @markj wrote:

I think it's ok. The firmware is installed as kernel modules, e.g., qat_dh895xcc_fw.ko. Some of them have different names with the new driver, but they'll be replaced simply by installing a new kernel, since installkernel wipes out the old one.

👍

Manual page change English looks good to me and its content is consistent with change summary.

This revision is now accepted and ready to land.Jul 23 2022, 8:02 AM

Closed by commit rGf4f56ff43dbd: qat: Rename to qat_c2xxx and remove support for modern chipsets (authored by markj). · Explain WhyJul 27 2022, 3:14 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGf4f56ff43dbd: qat: Rename to qat_c2xxx and remove support for modern chipsets.