Page MenuHomeFreeBSD

nvmecontrol: logpage will use the controller's vid to choose the formatting function when the vendor name is not provided.
Changes PlannedPublic

Authored by wanpengqian_gmail.com on Jan 7 2022, 1:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 15, 6:10 PM
Unknown Object (File)
Wed, Jan 11, 5:56 AM
Unknown Object (File)
Dec 28 2022, 1:16 PM
Unknown Object (File)
Dec 24 2022, 1:03 PM
Unknown Object (File)
Dec 14 2022, 10:47 PM
Unknown Object (File)
Dec 14 2022, 6:12 PM
Unknown Object (File)
Dec 2 2022, 7:18 AM

Details

Reviewers
imp
Group Reviewers
manpages
Summary

When displaying a vendor specified logpage, currently we have to specify the vendor name. if the user did not provide the vendor name, we can use the controller's vid to choose the formatting function.

Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com>

Test Plan

query vendor specify logpage without specify vendor name, check the display output.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43822
Build 40710: arc lint + arc unit

Event Timeline

A more proper approach would be to provide the vendor id when registering a logpage.
later it can be used to match the controller's id.

update print function for logpage vendor help. also update man page.

Beside that, the manual page change LGTM.

sbin/nvmecontrol/nvmecontrol.8
249

By "match", do you mean "select" or "choose"? If so, I would use either of those instead for clarity.

sbin/nvmecontrol/nvmecontrol.8
249

It means "choose". I have updated the man page.

Manual page change LGTM now. Can't speak about the rest.

wanpengqian_gmail.com retitled this revision from nvmecontrol: lookup vendor name based on vendor id when formating logpage to nvmecontrol: logpage will use the controller's vid to choose the formatting function when the vendor name is not provided..Jan 11 2022, 4:09 AM
rpokala added inline comments.
sbin/nvmecontrol/nvmecontrol.8
247

"HGST/WDC"
"Intel"

249

"Vendor ID"

Manual page LGTM at this point; will rereview when it's no longer a WIP.