Page MenuHomeFreeBSD

dmesg: Document kern.msgbuf_show_timestamp
ClosedPublic

Authored by imp on Fri, May 6, 4:32 PM.

Details

Reviewers
None
Group Reviewers
manpages
Commits
R10:2f44ad86f555: dmesg: Better wording from review
Summary

kern.msgbuf_show_timestamp=1 turns on timestamps in kernel's message
buffer which dmesg(8) prints.

Sponsored by: Netflix

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Fri, May 6, 4:32 PM
rpokala added inline comments.
sbin/dmesg/dmesg.8
92

"The kernel's placing data" sounds... wrong. I can't quite put my finger on why. :-S

In any case, perhaps one of these alternate phrasings?

variables can be used to control how the kernel places data into

or

variables can be used to control the behavior of the kernel when placing data into

or

variables can be used to control the kernel's behavior when placing data into
allanjude added inline comments.
sbin/dmesg/dmesg.8
92

Any of Ravi's 3 recommendations sounds much better to me as well

I like Ravi's first, but you can also drop "can be used to"
The following sysctl variables control how the kernel ...

Yea, I stole the wording from one of the geom man pages.
I'll update. I accidentally pushed this too soon, but I'll update with this review.

This revision was not accepted when it landed; it landed in state Needs Review.Sat, May 7, 3:55 PM
This revision was automatically updated to reflect the committed changes.
pauamma_gundo.com added inline comments.
sbin/dmesg/dmesg.8
76–77

Having a sentence ending in . between one ending in : and the list : says follows looks wrong.