lualoader: Add loader_menu_multi_user_prompt config variable
ClosedPublic
Actions

Authored by jrtc27 on Sep 1 2022, 10:17 PM.

Details

Reviewers

imp
kevans
manu
rpokala

Commits

rGffe0cd442311: lualoader: Add loader_menu_multi_user_prompt config variable
rG9b17aa27406f: lualoader: Add loader_menu_multi_user_prompt config variable

Summary

This allows the "Multi user" in "[B]oot Multi user" to be substituted
with another string, for example with "Installer" in installer media.
Note that this is lua-only at the moment, since loader.4th's menu.rc
defines the alternate name as Boot [M]ulti User, unlike lualoader which
leaves it as [B]oot Multi user. Ideally loader.4th would adopt the newer
and simpler lualoader behaviour and then it could gain support for this
option, but loader.4th is on the way out and isn't used by any official
installer media so this is not a significant concern.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Sep 1 2022, 10:17 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 1 2022, 10:17 PM

Herald added a subscriber: dab. · View Herald Transcript

jrtc27 requested review of this revision.Sep 1 2022, 10:17 PM

Harbormaster completed remote builds in B47222: Diff 110060.Sep 1 2022, 10:17 PM

jrtc27 added a child revision: D36419: release: Set loader_menu_multi_user_prompt to "Installer" for installer.Sep 1 2022, 10:18 PM

jrtc27 added a reviewer: rpokala.Sep 1 2022, 10:28 PM

rpokala accepted this revision.Sep 1 2022, 10:42 PM

This revision is now accepted and ready to land.Sep 1 2022, 10:42 PM

I'd think that the loader_ prefix is a bit much...

In D36418#827224, @imp wrote:

I'd think that the loader_ prefix is a bit much...

This was to match loader_menu_frame/timeout_[xy]/title(_align)/[xy] that already exist to influence various ways the menu is displayed (although mostly in drawer.lua not menu.lua)

Seems fine to me, thanks!

Closed by commit rG9b17aa27406f: lualoader: Add loader_menu_multi_user_prompt config variable (authored by jrtc27). · Explain WhySep 2 2022, 7:37 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG9b17aa27406f: lualoader: Add loader_menu_multi_user_prompt config variable.

imp added a commit: rGffe0cd442311: lualoader: Add loader_menu_multi_user_prompt config variable.Jan 24 2023, 10:17 PM