The libc default is 1KB; 64KB should help significantly without excessive overhead.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Tue, Jan 31
Nov 18 2022
Oct 28 2022
Oct 3 2022
.Sh NOTE ZVOLs are discouraged for use as swap devices, because ZFS needs to allocate memory in order to write, which may not be possible while the system is under memory pressure. In other words, ZFS needs memory to make memory available. ZFS swap files are discouraged for the same reason.
Sep 15 2022
Is the problem when the year won't fit into an int, or specifically when it won't fit into a 32-bit int?
Sep 5 2022
I have reworded the proposed diff for better readability in English; please consider adopting any or all of these changes:
.Ss Staging Slop The kernel needs to allocate memory during very early bootstrap, when creating kernel page tables and other data structures needed for initial operations. Because the kernel cannot even parse the firmware tables describing available memory without allocating, this makes bootstrapping problematic. To solve this issue, the kernel assumes that some memory after the staging area .Po where the kernel itself, together with modules and metadata, as loaded by .Nm , resides .Pc is available for use, without causing corruption of any firmware data. .Pp It is up to the loader to ensure that the staging area is larger than just the loaded kernel, modules, and metadata, by an extra .Dq slop amount. By default, amd64 reserves 8MB. The .Ic staging_slop command allows for tuning the slop size. It takes a single argument, the size of the slop in bytes. .Ss amd64 Nocopy BIOS loaders on i386 and amd64 put the staging area starting at the physical address .Ad 2M , then enables paging with identical mapping for the low .Ad 1G . The initial port of .Nm followed the same scheme for handing control to the kernel, since it avoided modifications for the loader/kernel hand-off protocol, and for the kernel page table bootstrap. .Pp This approach is incompatible with the UEFI specification, and as a practical matter, caused troubles on many boards, because UEFI firmware is free to use any memory for its own needs. Applications like .Nm must only use memory explicitly allocated using boot interfaces. The original way also potentially destroyed UEFI runtime interfaces data. .Pp Eventually, .Nm and the kernel were improved to avoid this problem. For backward bug-compatibility, and to allow booting older kernels with newer .Nm , this .Sq nocopy behaviour can be controlled by the loader .Ic copy_staging command. It takes a single argument, which can be one of .Bl -tag -width disable .It Ar disable Force-disable copying staging area to .Ad 2M . .It Ar enable Force-enable copying staging area to .Ad 2M . .It Ar auto Selects the behaviour based on the kernel's capability of boostraping from non-2M physical base. The kernel reports this capability by exporting the symbol .Va kernphys . .El .Pp Arm64 loaders have operated in the .Sq nocopy mode from their inception, so there is no .Ic copy_staging command on that platform. .Ss amd64 Faults Because it executes in x86 protected mode, the amd64 version of .Nm is susceptible to CPU faults due to programmer mistakes and memory corruption. To make debugging such faults easier, amd64 .Nm can provide detailed reporting of the CPU state at the time of the fault. .Pp The .Ic grab_faults command installs a handler for faults directly in the IDT, avoiding the use of the UEFI debugging interface .Fn EFI_DEBUG_SUPPORT_PROTOCOL.RegisterExceptionCallback . That interface is left available for advanced debuggers in the UEFI environment. The .Ic ungrab_faults command tries to deinstall the fault handler, returning TSS and IDT CPU tables to their pre-installation state. The .Ic fault command produces a fault in the .Nm environment for testing purposes, by executing the .Ic ud2 processor instruction.
Sep 1 2022
Aug 29 2022
Aug 26 2022
Aug 23 2022
Aug 22 2022
Aug 5 2022
Given that we h ave a number of options in ports, why? What would dhcpd in base provide us that one of the alternatives in ports cannot?
Jul 28 2022
Based on my previous comments, I suggest something like this for dv_type:
.It dv_type Type of device. The supported types are: .Bl -tag -width "DEVT_NONE" .It DEVT_NONE .It DEVT_DISK .It DEVT_NET .It DEVT_CD .It DEVT_ZFS .It DEVT_FD .El Each type may have its own associated (struct type_devdesc), which has the generic (struct devdesc) as its first member.
(The markup might need a little tweaking, particularly the references to the structures, but that should be in the right ballpark.)
In D35966#816520, @pauamma wrote:I agree "package" is unclear, but I have mixed feelings about "distribution". "tzdata data" read weirdly to me, so what about "information"?
Jul 27 2022
Jul 26 2022
I would suggest clarifying "appropriate for the situation".
Jul 25 2022
Jul 21 2022
In D35817#814621, @markj wrote:Re-add the manual page.
Jul 19 2022
FWIW, I'd switch to printf '%s' "$ROOTPASS" on general principles, to avoid the possibility of silliness.
Jul 18 2022
Jul 17 2022
In D35817#813503, @markj wrote:In D35817#813191, @pauamma_gundo.com wrote:The qat(4) manual page was deleted, not moved or renamed. Is that deliberate?
Yes. The new QAT driver has its own manual page, and since qat_c2xxx is specifically for old hardware and won't be receiving improvements beyond the usual maintenance, I don't see much reason to keep a man page for it.
Jul 16 2022
LGTM.
Jul 13 2022
LGTM.
In D35774#812599, @jhb wrote:Perhaps adjust the log message a bit to something like:
Jul 12 2022
I implemented something similar to strverscmp() several years back, but in a much simpler (though potentially slower?) way, by leveraging strtol():
int strnumcmp( const char *s1, const char *s2) { unsigned int n1 = 0; unsigned int n2 = 0;
Jul 11 2022
May 27 2022
In D35326#800921, @imp wrote:"You should not use glabel with any device you plan on putting a filesystem on"
might be better advise.
May 6 2022
In D35141#796582, @imp wrote:In D35141#796580, @rpokala wrote:Nice! (How did I not know that kern.msgbuf_show_timestamp was a thing?!?)
Because nobody has done something like https://reviews.freebsd.org/D35139 to document it?
Nice! (How did I not know that kern.msgbuf_show_timestamp was a thing?!?)
May 1 2022
Apr 28 2022
Apr 27 2022
Apr 26 2022
Apr 12 2022
Apr 6 2022
Apr 1 2022
Mar 31 2022
Mar 23 2022
Mar 16 2022
Mar 11 2022
Mar 9 2022
FWIW, LGTM.
Mar 4 2022
Feb 13 2022
Feb 11 2022
Might I suggest something like this next to the definition of module_verbose:
enum { MODULE_VERBOSE_SILENT, /* 0 */ MODULE_VERBOSE_QUIET, /* 1 */ MODULE_VERBOSE_DEFAULT, /* 2 */ MODULE_VERBOSE_FULL, /* 3 */ };
Or something along those lines. Then, rather than comparing against bare 0 or 2 (or potentially 3, as you mentioned here in Phabricator), you'd compare against the symbol. And of course get rid of MODULE_VERBOSE in favor of MODULE_VERBOSE_DEFAULT.
Feb 4 2022
Feb 3 2022
Nov 12 2021
... leaving just arm (which still enables it for GENERIC and TEGRA124) and mips
(which still enables it for RT2880_FDT and various std.mediatek-using kernel
configs), ...
Nov 10 2021
Nov 8 2021
Nov 5 2021
Nov 4 2021
Sep 10 2021
Jun 13 2021
To make sure I understand this: this change is to no longer allow Linuxulator to be built into the kernel, and only allow it to be built as a module?
May 31 2021
May 13 2021
In D30254#679505, @brooks wrote:Can we please encourage per-file or per-group consistency? Patches are annoying to read when the a group of #defines randomly switches between styles.
May 5 2021
In D30116#676007, @phk wrote:I would go with:
"Estimated System Boot time. When the clock is set, this is recalculated as new_time - uptime"
I think the "Estimated" is important, because neither clock-frequency tweaks, up to half a millisecond per second, nor leap-seconds are accounted for.
May 2 2021
Apr 26 2021
Apr 23 2021
Apr 20 2021
@freqlabs requested a second set of eyes; LGTM
Apr 10 2021
Apr 7 2021
Thanks!
As for the copyright, it was originally there but got removed after @imp said it was no longer custom.
In addition to the copyright thing mentioned inline, a question: This is for FreeBSD VMs running under Linux Kernel-based Virtual Machine, correct? If that's the case, for clarity, please change the
# KVM support
line in in the GENERIC and NOTES files to something like
# Linux KVM support
Apr 6 2021
Apr 5 2021
Code LGTM. ==@ambrisko WRT testing on legacy BIOS platforms.