Page MenuHomeFreeBSD
Feed Advanced Search

Thu, Oct 10

rpokala added a comment to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

Don't forget a manpage. :-)

Thu, Oct 10, 6:10 PM

Mon, Sep 16

rpokala added a comment to D20477: Introduce stats(3).
Mon, Sep 16, 12:34 AM

Sep 14 2019

rpokala added a comment to D21660: Ask sync(8) to sync multiple times.

My understanding of the "old wives tale" was not sync()ing three times, but actually *typing* sync<enter> three times; by the time you finished typing the third one, any background operations initiated by the first one would have completed.

Sep 14 2019, 8:43 PM

Sep 10 2019

rpokala added inline comments to D21593: Add an option to gnop to allow rejecting I/O after allowing some through..
Sep 10 2019, 8:37 PM

Aug 23 2019

rpokala added inline comments to D21383: Add VMD support to FreeBSD.
Aug 23 2019, 7:51 PM

Aug 15 2019

D21265: fusefs: fix conditional from r351061 is now accepted and ready to land.

LGTM, thanks for the fast turn-around.

Aug 15 2019, 4:36 AM

Jul 30 2019

rpokala added a comment to D21111: beinstall.sh: Use bectl instead of beadm by default.

I second @bcr's manpages comments. Otherwise LGTM.

Jul 30 2019, 9:36 PM

Jul 24 2019

rpokala added inline comments to D21034: improve swapon comments.
Jul 24 2019, 6:03 AM

Jul 18 2019

D20988: Provide new tunable hw.nvme.verbose_cmd_dump is now accepted and ready to land.

SHIP IT!

Jul 18 2019, 9:34 PM
rpokala added a comment to D20983: Sort & dedupe getopt flags for daemon.

Now this includes parts of D20969 😕

Jul 18 2019, 4:40 PM
D20983: Sort & dedupe getopt flags for daemon now requires changes to proceed.

In addition to fixing the getopt() line, please upload a full diff, as described on the FreeBSD wiki: https://wiki.freebsd.org/action/show/Phabricator#Create_a_Revision_via_Web_Interface

Jul 18 2019, 5:18 AM
rpokala added inline comments to D20969: Add option to set umask before starting child process.
Jul 18 2019, 3:07 AM
D17102: Add build-time option to boot0sio to reset terminal is now accepted and ready to land.

LGTM, but I defer to @imp. Oh, and @kevans did a lot of stuff related to loader output as part of LuaLoader, so you might want to get his feedback as well.

Jul 18 2019, 2:47 AM

Jul 16 2019

rpokala added inline comments to D17102: Add build-time option to boot0sio to reset terminal.
Jul 16 2019, 4:19 PM

Jul 15 2019

D20950: Implement a devtype command. is now accepted and ready to land.

Looks reasonable to my not-very-CAM-savvy eyes.

Jul 15 2019, 9:41 PM
rpokala added inline comments to D20950: Implement a devtype command..
Jul 15 2019, 8:57 PM

Jun 17 2019

rpokala added inline comments to D20678: Changes to allow camcontrol to use cached data more often.
Jun 17 2019, 8:45 PM

May 29 2019

rpokala committed rS348376: Add bits related to SANITIZE, SED, and form-factor to (struct ata_params).
Add bits related to SANITIZE, SED, and form-factor to (struct ata_params)
May 29 2019, 11:50 PM
rpokala closed D20455: Add bits related to SANITIZE, SED, and form-factor to (struct ata_params).
May 29 2019, 11:50 PM
rpokala created D20455: Add bits related to SANITIZE, SED, and form-factor to (struct ata_params).
May 29 2019, 5:47 AM

May 21 2019

rpokala added inline comments to D20326: Expose the buildid hash through sysctl.
May 21 2019, 4:45 PM

May 20 2019

rpokala added inline comments to D20326: Expose the buildid hash through sysctl.
May 20 2019, 9:07 PM

Apr 25 2019

rpokala added a comment to D20054: Document the UEFI boot loading process.

boot1.efi.8 needs to mention where boot1.efi lives on disk. (/efi/boot/boot${ARCH}.efi, right?)

Apr 25 2019, 5:24 PM

Apr 17 2019

rpokala added inline comments to D19944: random(4): Restore availability tradeoff prior to r346250.
Apr 17 2019, 10:28 PM

Apr 5 2019

rpokala added a comment to D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.
In D19827#425235, @imp wrote:

I specifically allowed those duplicates when I was originally reviewing this change....

Apr 5 2019, 5:31 AM
rpokala created D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.
Apr 5 2019, 4:50 AM

Apr 3 2019

rpokala committed rS345838: MFC r345611:.
MFC r345611:
Apr 3 2019, 6:37 AM
rpokala committed rS345837: MFC r345611:.
MFC r345611:
Apr 3 2019, 6:37 AM
rpokala committed rS345836: MFC r345611:.
MFC r345611:
Apr 3 2019, 6:36 AM
rpokala committed rS345827: MFC r345457:.
MFC r345457:
Apr 3 2019, 3:31 AM
rpokala committed rS345826: MFC r345457:.
MFC r345457:
Apr 3 2019, 3:30 AM

Apr 2 2019

rpokala added inline comments to D19799: rewrite of intro(4) manpage.
Apr 2 2019, 9:52 PM · docs
rpokala added inline comments to D19799: rewrite of intro(4) manpage.
Apr 2 2019, 9:17 PM · docs

Mar 29 2019

rpokala committed rS345668: MFC r339683:.
MFC r339683:
Mar 29 2019, 1:32 AM

Mar 28 2019

rpokala committed rS345663: MFC r339683:.
MFC r339683:
Mar 28 2019, 10:19 PM

Mar 27 2019

rpokala committed rS345611: Teach jedec_dimm(4) to be more forgiving of non-fatal errors..
Teach jedec_dimm(4) to be more forgiving of non-fatal errors.
Mar 27 2019, 9:50 PM
rpokala closed D19681: Teach jedec_dimm(4) to be more forgiving of non-fatal errors..
Mar 27 2019, 9:50 PM

Mar 25 2019

rpokala added a comment to D19681: Teach jedec_dimm(4) to be more forgiving of non-fatal errors..

@avg ping? Please take a look at this in the next day or two. If I don't hear from you, I'll go ahead and submit, but I'd prefer to have your review.

Mar 25 2019, 11:25 PM

Mar 23 2019

rpokala committed rS345457: Add descriptions for sysctls in kern_mib.c and sysctl.3 which lack them..
Add descriptions for sysctls in kern_mib.c and sysctl.3 which lack them.
Mar 23 2019, 7:53 PM
rpokala closed D19007: Add descriptions for sysctls in kern_mib.c which lack them..
Mar 23 2019, 7:53 PM
rpokala updated the diff for D19007: Add descriptions for sysctls in kern_mib.c which lack them..

Remove the reference to sysctl(3) from the individual descriptions.

Mar 23 2019, 6:36 PM
rpokala updated the diff for D19007: Add descriptions for sysctls in kern_mib.c which lack them..

As suggested, simplified the descriptions and added a pointer to the manpage.

Mar 23 2019, 3:03 AM

Mar 22 2019

rpokala created D19681: Teach jedec_dimm(4) to be more forgiving of non-fatal errors..
Mar 22 2019, 6:39 PM

Feb 19 2019

rpokala added a comment to D19245: Add support for legacy 512-byte block size MBRs on 4K block size disks.

Yes, BIOS INT call will treat the 4KB device like if it was 512 byte based and hide the fact we are using multiples of 4KB disk access. This was observed by at least Apple's BIOS.

Feb 19 2019, 10:37 PM
rpokala added a comment to D19245: Add support for legacy 512-byte block size MBRs on 4K block size disks.

I'm not sure I understand the point of this. No matter what the GEOM is doing, the BIOS INT call interface doesn't support 4KB sectors...?

Feb 19 2019, 10:04 PM

Jan 31 2019

rpokala added a comment to D19007: Add descriptions for sysctls in kern_mib.c which lack them..

Thanks for the feedback, @kib; take another look?

Jan 31 2019, 3:10 AM
rpokala updated the diff for D19007: Add descriptions for sysctls in kern_mib.c which lack them..

Update descriptions based on Kostik's feedback.

Jan 31 2019, 3:09 AM

Jan 30 2019

rpokala added a comment to D18696: sysctlmibinfo(3).

Anyway I have no strong opinion about the prefix/naming, What do you prefer? sysctlmib.h/.c/.3/_* ?

Jan 30 2019, 8:33 PM
rpokala added a comment to D19029: Remove unecessary "All rights reserved" from files under my or Panasas's copyright..

Err, yes. Thanks @rgrimes.

Jan 30 2019, 5:18 PM
rpokala closed D19029: Remove unecessary "All rights reserved" from files under my or Panasas's copyright..

Committed as r343583, but forgot to attach this review to the commit message. 🤦‍♂️

Jan 30 2019, 5:14 PM
rpokala committed rS343583: Remove unecessary "All rights reserved" from files under my or Panasas's.
Remove unecessary "All rights reserved" from files under my or Panasas's
Jan 30 2019, 4:55 PM
rpokala retitled D19029: Remove unecessary "All rights reserved" from files under my or Panasas's copyright. from Remove unecessary "All rights reserved" from files under my or Panasas's copyright. The files related to jedec_dimm(4) also bear avg@'s copyright; he approves of this change as well. to Remove unecessary "All rights reserved" from files under my or Panasas's copyright..
Jan 30 2019, 9:13 AM
rpokala created D19029: Remove unecessary "All rights reserved" from files under my or Panasas's copyright..
Jan 30 2019, 8:59 AM

Jan 29 2019

rpokala added a comment to D18696: sysctlmibinfo(3).

Question: why "sysctlmif", as opposed to "sysctlmib"? Since this is about walking the MIB tree?

Jan 29 2019, 2:05 AM

Jan 28 2019

rpokala created D19007: Add descriptions for sysctls in kern_mib.c which lack them..
Jan 28 2019, 9:51 PM

Jan 15 2019

rpokala added inline comments to D18841: New port: sysutils/ltfs: Reference implementation of LTFS for stand alone tape drive.
Jan 15 2019, 3:21 PM

Jan 11 2019

rpokala added a comment to D17930: clang: default to DWARF 4 as of FreeBSD 12.

Since 12 is already out and using 2, shouldn't that be <= 12?

Jan 11 2019, 9:01 PM

Jan 3 2019

rpokala added a comment to D18708: add instructions for SMTP access setup.

FWIW, LGTM.

Jan 3 2019, 7:00 AM

Dec 6 2018

rpokala added a comment to D18445: Update ext2fs(5) man page.

Please create links for ext3fs.5 and ext4fs.5; in share/man/man5/Makefile, add these to the list:

MLINKS+= ext2fs.5 ext3fs.5
MLINKS+= ext2fs.5 ext4fs.5
Dec 6 2018, 1:39 AM

Dec 3 2018

rpokala added inline comments to D17947: Rework UEFI ESP generation.
Dec 3 2018, 11:54 PM

Nov 29 2018

rpokala added inline comments to D18380: Fix a number of style issues with trim(8).
Nov 29 2018, 7:11 PM

Oct 4 2018

rpokala added inline comments to D16092: Committer guide: add note about private discussions.
Oct 4 2018, 10:01 PM
rpokala added inline comments to D16089: committer guide: update rules for contrib software..
Oct 4 2018, 9:58 PM

Aug 28 2018

rpokala committed rD52189: I forgot to update the docs with my keys when I first got my commit bit..
I forgot to update the docs with my keys when I first got my commit bit.
Aug 28 2018, 10:39 PM
rpokala closed D16915: Long-overdue addition of my keys..
Aug 28 2018, 10:39 PM
rpokala added a comment to D16915: Long-overdue addition of my keys..

I went ahead and moved the news.xml change as you suggested; I'm including it there for posterity.

Aug 28 2018, 7:42 AM
rpokala updated the diff for D16915: Long-overdue addition of my keys..

Re-order change to news.xml to be in reverse-chronological order.

Aug 28 2018, 7:37 AM

Aug 27 2018

rpokala updated the diff for D16915: Long-overdue addition of my keys..

Actually include the new key in the diff...

Aug 27 2018, 3:34 AM
rpokala created D16915: Long-overdue addition of my keys..
Aug 27 2018, 3:33 AM

Aug 25 2018

rpokala accepted D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

LGTM from a purely technical standpoint. (I'm actively avoiding the larger policy discussion around drm(4) and drm2(4).)

Aug 25 2018, 2:13 AM

Aug 1 2018

rpokala committed rS337033: Remove jedec_ts(4).
Remove jedec_ts(4)
Aug 1 2018, 8:24 AM
rpokala closed D16537: Remove jedec_ts(4)..
Aug 1 2018, 8:24 AM

Jul 31 2018

rpokala updated the diff for D16537: Remove jedec_ts(4)..

Fix a typo in UPDATING: "jdedc_ts" -> "jedec_ts".

Jul 31 2018, 9:06 PM
rpokala created D16537: Remove jedec_ts(4)..
Jul 31 2018, 9:03 PM
rpokala committed rS336976: MFC r336662,r336682.
MFC r336662,r336682
Jul 31 2018, 4:08 PM

Jul 24 2018

rpokala committed rS336682: Update .Dd in light of r336662..
Update .Dd in light of r336662.
Jul 24 2018, 7:21 PM
rpokala committed rS336662: Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead.
Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead
Jul 24 2018, 8:15 AM
rpokala closed D16412: Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead..
Jul 24 2018, 8:15 AM
rpokala created D16412: Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead..
Jul 24 2018, 12:34 AM

Jul 21 2018

rpokala accepted D16375: Mention the Linux compatibility layer instead of the Linux emulator in the BUGS section..

Looks good to me.

Jul 21 2018, 1:35 AM
rpokala added inline comments to D16375: Mention the Linux compatibility layer instead of the Linux emulator in the BUGS section..
Jul 21 2018, 12:51 AM

Jul 11 2018

rpokala added a comment to D16211: run(4): Add a new USB device ID..

... the numbers just happened to coincide here.

Jul 11 2018, 1:53 AM
rpokala added a comment to D16211: run(4): Add a new USB device ID..

The summary says PAU06 is the combination of two already-supported chips: RT5372 radio and RT5392 MAC. But nothing in the diff mentions the latter chip.

Jul 11 2018, 1:27 AM

Jun 29 2018

rpokala accepted D16064: bin/dd: Add conv=direct.
Jun 29 2018, 4:21 PM

Jun 25 2018

rpokala added inline comments to D15999: Create PCI_MATCH and pci_match_device.
Jun 25 2018, 7:55 PM

Jun 22 2018

rpokala added a comment to D15927: Update ixl(4) and ixlv(4) man pages.
In D15927#338098, @erj wrote:
In D15927#337633, @pi wrote:

Please expand LOM to 'onboard interfaces (LAN on Motherboard, LOM)', if possible. I'm a 30-years user of ethernet, but I've never heard that abbreviation.

I don't think it's that rare of an abbreviation, but I can add the expansion.

Jun 22 2018, 5:53 PM

Jun 9 2018

rpokala accepted D14818: lualoader: Add cli.lua(8) to the tree.
Jun 9 2018, 6:44 PM

Jun 8 2018

rpokala added a comment to D14819: lualoader: Add config.lua(8) to the tree.

Just a note: Anywhere I wrote {kernel} is because I couldn't come up with a better markup. I have no idea what the ideal syntax is for "this is a path with this variable substituted in" rather than "this is a path with this variable name literally in it"

Jun 8 2018, 3:52 AM
rpokala added a comment to D14476: libsa(3): Correct statement about FS Write-support, name change.

Might want to poke @imp and/or @jhb while all three of you are in the same city. :-)

Jun 8 2018, 3:51 AM
rpokala requested changes to D14819: lualoader: Add config.lua(8) to the tree.
Jun 8 2018, 3:49 AM
rpokala requested changes to D14818: lualoader: Add cli.lua(8) to the tree.
Jun 8 2018, 3:49 AM
rpokala requested changes to D14815: lualoader: Add hook.lua(8) to tree.
Jun 8 2018, 3:48 AM
rpokala closed D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
Jun 8 2018, 3:27 AM
rpokala abandoned D5672: MAC of VLAN interface does not change.
Jun 8 2018, 3:22 AM
rpokala commandeered D5672: MAC of VLAN interface does not change.
Jun 8 2018, 3:22 AM

Jun 7 2018

rpokala added a comment to D15689: Including rc_conf_directories to be loaded with rc(8).

I think this looks good now. Now you can point someone who actually knows `rc' at it. :-)

Jun 7 2018, 4:08 PM
rpokala added inline comments to D15689: Including rc_conf_directories to be loaded with rc(8).
Jun 7 2018, 2:44 PM
rpokala added inline comments to D15689: Including rc_conf_directories to be loaded with rc(8).
Jun 7 2018, 2:32 PM
rpokala added inline comments to D15689: Including rc_conf_directories to be loaded with rc(8).
Jun 7 2018, 2:22 PM

May 30 2018

rpokala committed rS334364: Remove the mlx5 driver from LINT kernel config for 32-bit PPC.
Remove the mlx5 driver from LINT kernel config for 32-bit PPC
May 30 2018, 2:26 AM