Page MenuHomeFreeBSD
Feed Advanced Search

Sat, Dec 7

rgrimes accepted D22706: Add per-FIB gateway support to rc.d/routing.
Sat, Dec 7, 6:26 AM

Fri, Dec 6

rgrimes accepted D22644: Fix the CE reflector receiver state machine in DCTCP.
Fri, Dec 6, 7:54 AM

Thu, Dec 5

rgrimes accepted D22691: ifnet: add callback for post-free cleanup.

I might of used tunif_freed inplace of tunifdtor, but thats just me wanting grep to find these :-)

Thu, Dec 5, 7:34 PM
rgrimes requested changes to D22644: Fix the CE reflector receiver state machine in DCTCP.

I am ok to move forward with this and leave rethinking of factoring out the newreno latch to a cc function until later, how ever I would like to not use default: for the only possible state of the ECT bits being 00, OR explicity comment that the only case that can trigger the default is ECN=00.

Thu, Dec 5, 7:05 PM
rgrimes accepted D22670: Send immediate ACK on receipt of CWR.
Thu, Dec 5, 6:56 PM
rgrimes added a comment to D20468: Port if_vether from OpenBSD.

I would encourage continued work on this and the switch code too.

Thu, Dec 5, 7:54 AM
rgrimes added a reviewer for D20468: Port if_vether from OpenBSD: rgrimes.
Thu, Dec 5, 7:51 AM
rgrimes added a comment to D18892: Phase 2 to add Proportional Rate Reduction (RFC6937) to FreeBSD.

This is a visual code read only review, I have not compiled or tested the code.

Thu, Dec 5, 7:37 AM
rgrimes accepted D22670: Send immediate ACK on receipt of CWR.

Nice find.

Thu, Dec 5, 7:17 AM
rgrimes added a comment to D22657: bhyve: add wrapper for debug printf statements.

Can you first revert the wrong change, which cleans this up by not doing the deletes of \n\r that was added by that diff.

Thu, Dec 5, 6:54 AM
rgrimes requested changes to D22644: Fix the CE reflector receiver state machine in DCTCP.

From the summary:

The main question remaining is then, if the DCTCP receiver
state machine asks for an explicit immediate ACK to be set,
in order to convey any change in the "CE" state of the incoming
packets in a timely fashion.
Thu, Dec 5, 6:50 AM

Tue, Dec 3

rgrimes accepted D22595: Align refcounting in multicast code between IPv4 and IPv6.

Thanks

Tue, Dec 3, 8:30 AM
rgrimes accepted D22595: Align refcounting in multicast code between IPv4 and IPv6.

Thanks for quickly addressing this. Just a code comment I noticed, and am curious if I missed something that would not allow the removal of a duplicate conditional

Tue, Dec 3, 7:38 AM
rgrimes added a comment to D15488: If reading the routing table fails, retry up to 10 times.

Offering a solution. Have the kernel track the max size of the routing table and return that value on sysctl(null) rather than the current size. This should only fail during initial table growth on a large table router, and should not require a retry except on rare occasion.

Tue, Dec 3, 6:20 AM

Mon, Dec 2

rgrimes added a comment to D15488: If reading the routing table fails, retry up to 10 times.

I have come to the state that if your running into this problem you probably should not be using netstat -rn to look at route tables but rather use the proper tool that talks with your routing daemon, adding a "bang on the kernel" repeat inside of netstat is probably a poor solution.

Well, I'm not sure.
First of all, there _are_ cases where you have to fetch the data, regardless of its size - troubleshooting can be one of those.

And when trouble shooting netstat -rn general works ok, it gets the error only while the route table is growing rapidly and is very easy for the user to retry the command, SHOULD they be using it.

Mon, Dec 2, 6:42 PM

Thu, Nov 28

rgrimes added a comment to D15488: If reading the routing table fails, retry up to 10 times.

I have come to the state that if your running into this problem you probably should not be using netstat -rn to look at route tables but rather use the proper tool that talks with your routing daemon, adding a "bang on the kernel" repeat inside of netstat is probably a poor solution.

Thu, Nov 28, 4:23 AM

Thu, Nov 21

rgrimes accepted D22466: add deprecation warning to amd.
Thu, Nov 21, 1:25 AM

Mon, Nov 18

rgrimes accepted D22436: Add access to TOS(ECN bits) to the TCP syncache.
Mon, Nov 18, 3:15 AM

Sun, Nov 17

rgrimes accepted D22429: Addition of flag bit definitions in preparation of AccECN.

Something really strange here with this diff

The raw diff should be ok though...

Sun, Nov 17, 7:21 PM
rgrimes added a comment to D22429: Addition of flag bit definitions in preparation of AccECN.

Something really strange here with this diff

Sun, Nov 17, 8:18 AM
rgrimes accepted D22428: Editorial change to enhance readability of the TF_* bit constants.
Sun, Nov 17, 8:02 AM
rgrimes requested changes to D22428: Editorial change to enhance readability of the TF_* bit constants.
Sun, Nov 17, 7:59 AM
rgrimes accepted D22426: Add access to TOS(ECN bits) byte in TCP RACK.
Sun, Nov 17, 4:24 AM

Sat, Nov 16

rgrimes accepted D19118: Add Boundary and Overflow checks in Cubic formulas.

I usually do the comparison separate from formula when they already exist, but either is ok with me.

Sat, Nov 16, 4:14 AM
rgrimes added a reviewer for D21798: Restrict cwnd growth on app-limited flows: rgrimes.
Sat, Nov 16, 1:32 AM

Sep 15 2019

rgrimes accepted D21662: sysctl: deprecation notices.

This is defanitly needed. Only two comment, you elude to having a version, it would indeed be nice to have a thing like the gonein(13) functionality, how to do that I do not know, and I would commit this in 2 parts, the new functionality, and then its first use.

Sep 15 2019, 4:23 PM

Sep 10 2019

rgrimes accepted D21581: Disable the default of ntpd locking of pages in memory.
Sep 10 2019, 5:23 PM

Aug 16 2019

D19976: bhyve: Support a _VARS.fd file for bootrom is now accepted and ready to land.
Aug 16 2019, 6:55 PM
rgrimes added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

The additional note on style(9) on variable order declaration is informative only, you can choose to fix at your option.

Aug 16 2019, 6:39 PM

Aug 15 2019

D21060: Stop installing clang, clang++, and clang-cpp hardlinks in /usr/bin. is now accepted and ready to land.
Aug 15 2019, 4:50 PM
rgrimes added a comment to D21270: ping6: Disable definition of the old copyright variable.

My position is that "intent" in law carries a greater weight than "implementation". I agree that the intent of UCB was to embed the Copyright into the binary, and the fact that has been defeated by the choice of tools is on us to correct. Though Berne makes the binary copyright by default, it was still the intent of the original author to have these copyright strings appear. It is also very much understood in copyright law that "removing of any copyright" is an actionable item. Now, the likely hood that UCB would take action is moot. We could contact the UCB legal office and ask them for advice? Even a duplicate copyright can raise that question, I have seen no place an exception based on the fact that the same copyright appeared more than once.

Aug 15 2019, 4:08 PM

Aug 7 2019

rgrimes added a comment to D21181: Remove the fuse.ko -> fusefs.ko symlink.

Thanks for remebering to clean this up.

Aug 7 2019, 8:19 PM

Jun 27 2019

rgrimes added a comment to D20762: Add an initial RELNOTES file..

Reformat to 80 columns.

Jun 27 2019, 5:16 PM

Jun 26 2019

rgrimes committed rS349443: MFC: r347065 (by jhb) Emulate the "ADD reg, r/m" instruction (opcode 03H)..
MFC: r347065 (by jhb) Emulate the "ADD reg, r/m" instruction (opcode 03H).
Jun 26 2019, 9:59 PM
rgrimes committed rS349441: Emulate the "TEST r/m{16,32,64}, imm{16,32,32}" instructions (opcode F7H)..
Emulate the "TEST r/m{16,32,64}, imm{16,32,32}" instructions (opcode F7H).
Jun 26 2019, 9:20 PM
rgrimes closed D20755: Emulate the TEST instruction with opcode F7 /0..
Jun 26 2019, 9:20 PM
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

Finally review please

Jun 26 2019, 8:27 PM
rgrimes added reviewers for D20755: Emulate the TEST instruction with opcode F7 /0.: markj, pmooney_pfmooney.com.
Jun 26 2019, 8:27 PM
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

Fix 7F to F7 in 4 places

Jun 26 2019, 8:26 PM
rgrimes added inline comments to D20755: Emulate the TEST instruction with opcode F7 /0..
Jun 26 2019, 8:23 PM
rgrimes added a reviewer for D20755: Emulate the TEST instruction with opcode F7 /0.: jhb.

I was kinda waiting for jhb@ on this, as it is his patch, but given the urgency I am commandering this, and I'll push a new patch up for review. I would like to ask markj and pmooney to final review that and accept it before I commit to ^/head and push for an immediate MFC, and merge to releng. I'll also need to merge r347065 which is 6 weeks past MFC date.

Jun 26 2019, 8:03 PM
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

Ping, since 11.3RC3 is back on the table I would like to see this pushed through along with r347065 which should of already been pushed through as it is 3 weeks past original MFC.

Jun 26 2019, 7:23 PM
rgrimes added a comment to D19495: bhyve - Snapshot Save and Restore.

I have applied the feedback @jhb gave, except for the #ifdef guards. Will work on it after rebasing with a newer master.

Jun 26 2019, 11:11 AM · bhyve
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

I helped Jason Tubnor test this patch on 11.3RC2, we had to first merge r347065 to get this patch to apply, and then had to make the 0x7F to 0xF7 Markj points out to get it to work. OpenBSD now runs as a guest in 11.3RC2

Jun 26 2019, 3:43 AM

Jun 25 2019

rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

I am working with the original poster to get him a binary so he can test this fix.

Jun 25 2019, 2:14 PM

Jun 21 2019

rgrimes added a comment to D12419: HD Audio Emulation For Bhyve (Based on D7840).

Just tested with TruOS/Trident from a May 2019 kernel, and it's getting ECAPMODE. Maybe the problems with Capsicum aren't worked out yet. I'll look some more at it.

Jun 21 2019, 7:55 PM

Jun 20 2019

rgrimes added a comment to D7840: HD Audio Emulation For Bhyve.

This appears to be hung up on Capsicum additions

Jun 20 2019, 5:07 PM
rgrimes resigned from D20389: bhyve vioapic writes can deadlock instance.
Jun 20 2019, 4:52 PM · bhyve

Jun 19 2019

rgrimes added a comment to D20673: Make RFB_ENCODING_ZLIB message handling idempotent..

In agreement on it probably needs cleaned up, but first finding out why it was done this way as a safe position to take.

Jun 19 2019, 2:01 PM

Jun 13 2019

rgrimes added a comment to D20626: bhyve: move common code to net_utils.c.

I am pulling Kyle Evans in on this as he just did a bunch of cleanup on mac generation code and there may already be existing code to reused rather than have yet another mac generator.

...

One could theoretically take advantage of this to have a stable MAC across hosts for cases like, e.g., migration, no? Although it's not clear that bhyve folk would want to maintain this kind of promise, I could see it being somewhat handy.

For the purpose of migration you take the mac with you, that is part of the guest state.

Jun 13 2019, 5:42 PM
rgrimes added a comment to D20626: bhyve: move common code to net_utils.c.

I am pulling Kyle Evans in on this as he just did a bunch of cleanup on mac generation code and there may already be existing code to reused rather than have yet another mac generator.

Jun 13 2019, 4:54 AM
rgrimes added a reviewer for D20626: bhyve: move common code to net_utils.c: kevans.
Jun 13 2019, 4:53 AM
rgrimes accepted D20623: Deterministically initialize the PCI command register for passthru devices..

Good find.

Jun 13 2019, 4:41 AM

Jun 10 2019

rgrimes added a comment to D20581: bhyve: virtio: introduce vq_kick_enable() and vq_kick_disable().
In D20581#445096, @v.maffione_gmail.com wrote:

Moved include <machine/atomic.h> to virtio.h.

Jun 10 2019, 8:30 PM
rgrimes accepted D20365: simplify bhyve vlapic ESR logic.
Jun 10 2019, 2:28 PM · bhyve

Jun 8 2019

rgrimes resigned from D18880: Extend mmap/mprotect API to specify the max page protections..
Jun 8 2019, 1:42 AM

Jun 6 2019

rgrimes added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

Please document why the -2 is needed per the earlier discussion. Does this need urgent attention to get in 11.3?

Jun 6 2019, 5:51 PM
rgrimes accepted D20531: Keep the shadow PCIR_COMMAND synced with the real one for pass through..

Looks like diff has gotten really confused by something making this very hard to see what it is that really changed since we are seeing function
pci_emul_cmdsts_write
compared to a new function
pci_emul_cmd_changed and are not actually seeing what changed in
pci_emul_cmdsts_write

Jun 6 2019, 1:08 AM
rgrimes accepted D20530: Enable memory and I/O decoding in PCI devices on demand..
Jun 6 2019, 12:59 AM

Jun 5 2019

rgrimes accepted D20525: Support MSI-X for passthrough devices with a separate PBA BAR..

Just questions really, no changes requested.

Jun 5 2019, 5:18 PM
rgrimes added a comment to D20520: Normalize deployment tools usage and definitions.
In D20520#443376, @imp wrote:

bootools is a terrible name, so bad I'm ticking 'request changes'.,

I agree here, but did not have a better name so opted to say nothing.

Jun 5 2019, 4:01 PM
rgrimes added reviewers for D20520: Normalize deployment tools usage and definitions: bdrewery, sjg.
Jun 5 2019, 9:10 AM
rgrimes added a comment to D20520: Normalize deployment tools usage and definitions.

I am not really keen on adding yet another top level .mk file that sets command names, much of this is caused by scatering etc/Makefile contents and rules about the tree when it was and should of been maintained as the one place for all of this and simply called as a submake. Perhaps it makes since anymore, perhaps not. But certainly having INSTALL and INSTALL_CMD default to and 99.999% of the time be "install" is not a good idea, same for MTREE and MTREE_CMD, they are being used in mixed manners, this needs to be sorted out asap and just use
MTREE_CMD and untwist some of this MTREE overload that should really overlaod MTREE_CMD.

Jun 5 2019, 9:09 AM

Jun 4 2019

rgrimes added a comment to D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.

This is a ping. The pr https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229852 has had another success report. This really should get in tree and in release, what is holding it up?

Jun 4 2019, 4:09 AM · bhyve

May 29 2019

rgrimes accepted D20448: style.9: Codify tolerance for eliding blank lines.
May 29 2019, 9:26 PM
rgrimes added a comment to D20448: style.9: Codify tolerance for eliding blank lines.

The very first version had:

f3()
{
					/* Empty line if no variables. */
	return (1);
}

Quote above As Ed beat me to the comment, I had be saying: Actually look closer at that 1.1 version, at line 119 it existed, and then in 1.3 was modified at line 159 became 194.
We can ask Kirk for clarity?

May 29 2019, 12:18 AM

May 28 2019

rgrimes accepted D20448: style.9: Codify tolerance for eliding blank lines.
May 28 2019, 6:04 PM
rgrimes added a comment to D20448: style.9: Codify tolerance for eliding blank lines.

I would even be fine with "If the function has no local variables", I do not think the length should come into play at all. Can someone explain why we have this special case at all? I know we want a blank line between variable declarations and the start of the function, is this just an attempt to preserve that empty line when there are no declarations?

May 28 2019, 6:04 PM

May 26 2019

rgrimes commandeered D16913: vmrun: add -x flag to disable reboot loop.
May 26 2019, 2:58 AM
rgrimes updated the summary of D16913: vmrun: add -x flag to disable reboot loop.
May 26 2019, 2:57 AM

May 25 2019

rgrimes committed rS348271: MFC: r346714: Add accessor function for vm->maxcpus.
MFC: r346714: Add accessor function for vm->maxcpus
May 25 2019, 11:28 AM
rgrimes committed rS348270: Correctly align usage: output.
Correctly align usage: output
May 25 2019, 11:23 AM
rgrimes committed rS348269: MFC: r346717: Make bhyve SMBIOS table topology aware.
MFC: r346717: Make bhyve SMBIOS table topology aware
May 25 2019, 10:17 AM

May 24 2019

rgrimes resigned from D19247: Merge hold_count into wire_count..

Getting way above my pay grade

May 24 2019, 11:33 PM
rgrimes retitled D16913: vmrun: add -x flag to disable reboot loop from vmrun: add -x flag to always exit when bhyve exists to vmrun: add -x flag to disable reboot loop.
May 24 2019, 3:33 PM
rgrimes added a comment to D16913: vmrun: add -x flag to disable reboot loop.

@allanjude I know your work load is huge as well, if you need me to push a new diff I can do that, but then you have to agree to commit it or I have to pester bde/phk for an approval.

May 24 2019, 3:30 PM
rgrimes added a comment to D10009: Fix a memory leak in bhyve.

Concur, but not sure how to force it closed.

May 24 2019, 3:23 PM
rgrimes resigned from D10009: Fix a memory leak in bhyve.
May 24 2019, 3:23 PM
rgrimes committed rS348226: MFC: r346717: Make bhyve SMBIOS table topology aware.
MFC: r346717: Make bhyve SMBIOS table topology aware
May 24 2019, 5:47 AM
rgrimes committed rS348223: MFC: r346714: Add accessor function for vm->maxcpus.
MFC: r346714: Add accessor function for vm->maxcpus
May 24 2019, 4:16 AM
rgrimes added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

@jhb, reopening a commited phab review messes with things, as now when you make a second commit the default top patch in this review well be the one you commit, and one has to go digging in the review history to find the prior patch that was in the first commit. It is fine to reopen a review for a revert, but I think one should start a new review for a new change, which is what this is.

May 24 2019, 12:45 AM · bhyve

May 23 2019

rgrimes committed rS348201: MFC: r332298,333712,334199,334216,334219 bhyve cpu topology.
MFC: r332298,333712,334199,334216,334219 bhyve cpu topology
May 23 2019, 9:23 PM
rgrimes committed rS348188: MFC: r347960: bhyve virtio needs barriers.
MFC: r347960: bhyve virtio needs barriers
May 23 2019, 6:58 PM
rgrimes committed rS348186: MFC: r347960: bhyve virtio needs barriers.
MFC: r347960: bhyve virtio needs barriers
May 23 2019, 6:49 PM
rgrimes accepted D19904: bhyve: Add Integrated Endpoint to PCIe Capability.
May 23 2019, 4:46 PM
rgrimes accepted D19905: bhyve: Add EUI64 to NVMe device.
May 23 2019, 4:45 PM
rgrimes accepted D20365: simplify bhyve vlapic ESR logic.
May 23 2019, 12:48 AM · bhyve
rgrimes removed reviewers for D20365: simplify bhyve vlapic ESR logic: rgrimes, bhyve.
May 23 2019, 12:48 AM · bhyve
rgrimes resigned from D20365: simplify bhyve vlapic ESR logic.
May 23 2019, 12:47 AM · bhyve
rgrimes accepted D20365: simplify bhyve vlapic ESR logic.
May 23 2019, 12:46 AM · bhyve

May 22 2019

rgrimes added a comment to D20365: simplify bhyve vlapic ESR logic.

Minor nits, and a major win, good work!

May 22 2019, 9:18 PM · bhyve

May 21 2019

rgrimes added a comment to D20335: bhyve could be more precise with vPIT.

Any more little gold mines like this sitting around?

May 21 2019, 7:51 PM · bhyve

May 18 2019

rgrimes closed D19501: bhyve virtio needs barriers.
May 18 2019, 7:33 PM
rgrimes committed rS347960: bhyve virtio needs barriers.
bhyve virtio needs barriers
May 18 2019, 7:33 PM
rgrimes accepted D19501: bhyve virtio needs barriers.
May 18 2019, 5:10 AM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

Ok to commit once blank lines are added per jhb in person

May 18 2019, 5:10 AM

May 15 2019

rgrimes accepted D16728: Move master.passwd and group to lib/libc/gen/.

I thought this had already been committed?

May 15 2019, 7:43 PM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

I would like to see this in next weeks 11.3-PRERELEASE build, this looks to be a low risk barrier addition, @jhb does that seem to be a reasonable target, or would you like to see a longer ^head test cycle? Does anyone see any risk in this change?

May 15 2019, 1:46 PM

May 10 2019

rgrimes accepted D20117: Restructure mbuf send tags to provide stronger guarantees..
May 10 2019, 8:00 PM

May 9 2019

rgrimes updated the test plan for D19501: bhyve virtio needs barriers.
May 9 2019, 4:51 PM