The attached patch puts /boot/efi back in mtree, so it is created on systems without an ESP as well as systems with an ESP (I still don't really understand why we want this...). To make installations work so that only real ESPs get set up with the loader and efibootmgr, the logic in the installer is switched from whether /boot/efi exists (which it now always does) to whether it is present as a mountpoint in the in-progress fstab.
Details
Details
- Reviewers
imp emaste bdragon rgrimes - Commits
- rGe77cf2a4ab32: Restore /boot/efi to mtree.
NOTE: I have not tested this fully yet, but it takes long enough to do end-to-end build and test for installer changes that I'm putting this up for review now to save time. It's a 2-line diff anyway, so I'm guessing most of the discussion will be on concept rather than any bugs that might exist.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This is a move in the right directions, at least this is state created by the installer.
Comment Actions
Confirmed that I can still install on powerpc64le in qemu with this change, and that the empty /boot/efi directory exists again.
Comment Actions
It was always state created by the installer, for the record. It's just different state now (whether it make a directory earlier vs. whether it added that directory to /etc/fstab after making it).