Page MenuHomeFreeBSD

nwhitehorn (Nathan Whitehorn)
User

Projects

User Details

User Since
Sep 10 2014, 9:01 PM (337 w, 6 d)

Recent Activity

Yesterday

nwhitehorn committed R10:2c26d77d989a: Remove /boot/efi from mtree, missed in 0b7472b3d8d2. (authored by nwhitehorn).
Remove /boot/efi from mtree, missed in 0b7472b3d8d2.
Tue, Mar 2, 4:50 PM

Thu, Feb 25

nwhitehorn added a comment to D28912: Use makefs(8) in release VM-image generation instead of mdconfig/newfs/etc..

Just committed this. I agree about 13.0 -- I was planning to merge to stable/13 after 13.0 has branched and smoke-test this in HEAD for a bit in the meantime.

Thu, Feb 25, 2:26 AM
nwhitehorn closed D28912: Use makefs(8) in release VM-image generation instead of mdconfig/newfs/etc..
Thu, Feb 25, 2:26 AM
nwhitehorn committed R10:1ca8842f3ad9: Use makefs(8) in release VM-image generation instead of md(4) and newfs. (authored by nwhitehorn).
Use makefs(8) in release VM-image generation instead of md(4) and newfs.
Thu, Feb 25, 2:26 AM

Wed, Feb 24

nwhitehorn committed R10:f7aebfbe5c0a: Add GPT PREP-boot type to mkimg(1) from geom_gpt. (authored by nwhitehorn).
Add GPT PREP-boot type to mkimg(1) from geom_gpt.
Wed, Feb 24, 3:34 PM
nwhitehorn requested review of D28912: Use makefs(8) in release VM-image generation instead of mdconfig/newfs/etc..
Wed, Feb 24, 3:27 PM
nwhitehorn committed R10:e70eb4027151: Mount the ESP on /boot/efi in VM images. (authored by nwhitehorn).
Mount the ESP on /boot/efi in VM images.
Wed, Feb 24, 1:20 PM
nwhitehorn committed R10:1af48800c20f: Delete memstick images for PowerPC. (authored by nwhitehorn).
Delete memstick images for PowerPC.
Wed, Feb 24, 3:20 AM

Tue, Feb 23

nwhitehorn committed R10:0b7472b3d8d2: Mount the EFI system partition (ESP) on newly-installed systems. (authored by nwhitehorn).
Mount the EFI system partition (ESP) on newly-installed systems.
Tue, Feb 23, 9:25 PM
nwhitehorn closed D28897: Mount ESP on newly-installed systems.
Tue, Feb 23, 9:24 PM
nwhitehorn retitled D28897: Mount ESP on newly-installed systems from Mount ESP on newly-installed systems (WIP) to Mount ESP on newly-installed systems.
Tue, Feb 23, 8:27 PM
nwhitehorn updated the diff for D28897: Mount ESP on newly-installed systems.

Now tested and working, with UFS and ZFS, including multi-disk ZFS setups. In principle ready for commit.

Tue, Feb 23, 8:12 PM
nwhitehorn updated the diff for D28897: Mount ESP on newly-installed systems.

Now does ZFS (including redundant setups) as well. Still not fully tested.

Tue, Feb 23, 5:02 PM
nwhitehorn added a comment to D28897: Mount ESP on newly-installed systems.

@imp any thoughts on the gmirror solution for ZFS? I think it solves 95% of the update issues and shouldn't be too bad to implement.

Tue, Feb 23, 3:26 PM
nwhitehorn requested review of D28897: Mount ESP on newly-installed systems.
Tue, Feb 23, 3:09 PM

Sat, Feb 20

nwhitehorn added a comment to D28814: hier.7: move ESP mountpoint to /efi (from /boot/efi).

Just to be pedantic: We actually *do* have /boot as separate on some systems (e.g. recent powerpc64), but those systems are mutually exclusive with EFI systems. I have a mild preference /boot/efi, but it doesn't really matter much so long as we pick something -- the status quo is it not being mounted *at all*, so reliability of mounting or whatever is obviously a second-order issue.

Sat, Feb 20, 1:49 AM

Dec 17 2020

nwhitehorn committed rS368718: Make non-debug kernels installable..
Make non-debug kernels installable.
Dec 17 2020, 2:20 PM

Dec 13 2020

nwhitehorn committed R9:4cc52c752887: Add myself to website, with a news article. (authored by nwhitehorn).
Add myself to website, with a news article.
Dec 13 2020, 5:48 PM
nwhitehorn committed R9:8528d4bd7d0b: Add myself to developers list. (authored by nwhitehorn).
Add myself to developers list.
Dec 13 2020, 5:48 PM
nwhitehorn committed R9:9ce5365ef595: Add myself to authors list. (authored by nwhitehorn).
Add myself to authors list.
Dec 13 2020, 5:48 PM
nwhitehorn committed R9:009ca73b1469: Add my PGP key in appropriate places. (authored by nwhitehorn).
Add my PGP key in appropriate places.
Dec 13 2020, 5:48 PM
nwhitehorn committed R9:74da878eda9e: Update PowerPC platform Known Issues to reflect the issues that still (authored by nwhitehorn).
Update PowerPC platform Known Issues to reflect the issues that still
Dec 13 2020, 5:42 PM
nwhitehorn committed R9:92740a2da1b4: Reflect the declining list of caveats attached to the PowerPC port. This (authored by nwhitehorn).
Reflect the declining list of caveats attached to the PowerPC port. This
Dec 13 2020, 5:37 PM
nwhitehorn committed R9:06e09685e5a0: Update PowerPC port page to reflect the introduction of G5 support and (authored by nwhitehorn).
Update PowerPC port page to reflect the introduction of G5 support and
Dec 13 2020, 5:32 PM

Oct 29 2020

nwhitehorn committed rP553626: Updates net-im/slack-libpurple by two years, bringing in a wide variety of.
Updates net-im/slack-libpurple by two years, bringing in a wide variety of
Oct 29 2020, 3:40 PM

Oct 15 2020

nwhitehorn committed rS366723: Provide a slightly more-tolerant set of thermal parameters for PowerMac.
Provide a slightly more-tolerant set of thermal parameters for PowerMac
Oct 15 2020, 1:43 PM

Jul 6 2020

nwhitehorn committed rP541344: Now in Michigan..
Now in Michigan.
Jul 6 2020, 2:08 PM

May 12 2020

nwhitehorn added a comment to D15243: Powerpc64: Enable Hardware Transactional Memory.

So, HTM is removed in PowerISA 3.1 and it's broken on POWER9. Is it even worth doing at this point? I'm inclined to abandon this.

May 12 2020, 4:03 AM · PowerPC

May 10 2020

nwhitehorn committed rP534857: Update to a newer SEMS snapshot, which brings some minor bugfixes related.
Update to a newer SEMS snapshot, which brings some minor bugfixes related
May 10 2020, 5:44 PM
nwhitehorn added a comment to D23731: powerpc: Add a CPU-custom machine check handler.

Do we know all supported 32-bit AIM CPUs do the same things with DSISR? Otherwise, it looks good to me.

May 10 2020, 5:32 PM

Dec 1 2019

nwhitehorn committed rS355259: Checkpoint rtsx(4) bring-up. Now can communicate a little with the card,.
Checkpoint rtsx(4) bring-up. Now can communicate a little with the card,
Dec 1 2019, 7:44 AM

Nov 30 2019

nwhitehorn committed rS355229: In-progress driver for the Realtek SD card reader annoyingly found in.
In-progress driver for the Realtek SD card reader annoyingly found in
Nov 30 2019, 4:59 PM

Sep 7 2019

nwhitehorn added a comment to D21478: Automatic dependency tracking for FDT/OFW..

I have pretty mixed feelings about this approach. It only works for ofwbus children, not simplebus children, and canonicalizes a bunch of behaviors that I don't believe are standards (I'm in an airport departure lounge and don't have the spec handy). I'm also not really sure how it interacts with multipass etc. Could you elaborate a little more on the mechanism?

Sep 7 2019, 7:24 AM

Aug 27 2019

nwhitehorn committed rP509981: net/sems: SIP Express Media Server (new port).
net/sems: SIP Express Media Server (new port)
Aug 27 2019, 3:15 AM
nwhitehorn closed D21410: net/sems: SIP Express Media Server (new port).
Aug 27 2019, 3:15 AM

Aug 26 2019

nwhitehorn added a comment to D21410: net/sems: SIP Express Media Server (new port).

Fix fat-fginering; this is the right diff. It also sets Python to use Python 2, since a handful of scripts cared.

Aug 26 2019, 4:49 PM
nwhitehorn added inline comments to D21410: net/sems: SIP Express Media Server (new port).
Aug 26 2019, 4:17 PM
nwhitehorn added a comment to D21410: net/sems: SIP Express Media Server (new port).

Updates from review.

Aug 26 2019, 4:17 PM

Aug 25 2019

nwhitehorn created D21410: net/sems: SIP Express Media Server (new port).
Aug 25 2019, 12:04 AM

Jul 21 2019

nwhitehorn added a comment to D20944: powerpc64/mmu: Make moea64_pvo_enter() return if an entry already exists.

OK, sounds good, thanks for testing!

Jul 21 2019, 4:15 AM

Jul 15 2019

nwhitehorn added a comment to D20944: powerpc64/mmu: Make moea64_pvo_enter() return if an entry already exists.

Just make the page table size really small. There's a spill counter in the statistics; when it gets small enough, you should see it moving. If spill-handling doesn't work, and you have spills, everything breaks fast.

Jul 15 2019, 9:52 PM
nwhitehorn added a comment to D20944: powerpc64/mmu: Make moea64_pvo_enter() return if an entry already exists.

Does this break PTE spills? This code path historically was involved in re-adding PVOs to the hashed page table on faults if they got spilled.

Jul 15 2019, 8:45 PM

Jul 11 2019

nwhitehorn added a comment to D20903: powerpc/pmap64: Make moea64 statistics optional.

That's a fair point. I've used them to assess hash-table spill rates when performance is not great, but not for a long time. We could also just delete them.

Jul 11 2019, 4:30 PM
nwhitehorn added a comment to D20903: powerpc/pmap64: Make moea64 statistics optional.

Yeah, counter(9) seems like the actual solution here.

Jul 11 2019, 6:50 AM

Jun 19 2019

nwhitehorn added a comment to D20694: powerpc64/pmap: Reduce scope of PV_LOCK in remove path.

Looks good to me; do you know how much this actually helps?

Jun 19 2019, 6:13 AM

Jun 17 2019

D20598: powerpc: Transition to Secure-PLT, like most other OSs is now accepted and ready to land.
Jun 17 2019, 8:34 PM

Jun 16 2019

nwhitehorn committed rS349121: Fix bug on newbus device deletion: we should delete the child's devinfo.
Fix bug on newbus device deletion: we should delete the child's devinfo
Jun 16 2019, 9:57 PM

Jun 11 2019

nwhitehorn added inline comments to D20598: powerpc: Transition to Secure-PLT, like most other OSs.
Jun 11 2019, 3:40 AM

Feb 26 2019

nwhitehorn added a comment to D19208: powerpc/mpc85xx: Synchronize timebase the platform correct way.

Should we panic if freeze_timebase somehow doesn't get set? Or, alternately, fall back on the old lame thing?

Feb 26 2019, 4:54 PM

Feb 10 2019

nwhitehorn committed rS343969: Performance improvements for octe(4):.
Performance improvements for octe(4):
Feb 10 2019, 8:14 PM

Jan 13 2019

nwhitehorn accepted D18709: powerpc/boot: Move ubldr to /boot/uboot, and make this a separate filesystem.

Longer-term, it might be better to avoid a proliferation of special cases like this to set LOADER_MSDOS_SUPPORT for the U-boot loader and make loader flexible enough to find the kernel etc. in the root rather than /boot. But this is fine for now.

Jan 13 2019, 4:53 AM

Oct 19 2018

nwhitehorn accepted D17601: ppc64: limited 32-bit DMA address range.
Oct 19 2018, 3:27 PM

Oct 11 2018

nwhitehorn added a comment to D17446: powerpc/spe: Implement SPE exception handling.

Aside from one inline note, this looks OK for non-SPE.

Oct 11 2018, 8:14 PM
nwhitehorn committed rS339301: Loader GELI support, like lua loader, seems to be broken on PowerPC as.
Loader GELI support, like lua loader, seems to be broken on PowerPC as
Oct 11 2018, 12:55 AM

Oct 5 2018

nwhitehorn accepted D17361: powerpc/pseries: EOI interrupts in XICS by setting lowest priority.
Oct 5 2018, 9:41 PM
nwhitehorn accepted D17356: powerpc64/powernv: Don't mask MSIs in OPAL.
Oct 5 2018, 9:40 PM

Sep 19 2018

nwhitehorn accepted D17183: Fix random DMA failure on powernv.
Sep 19 2018, 8:24 PM · PowerPC

Sep 17 2018

nwhitehorn added a comment to D17183: Fix random DMA failure on powernv.

Can we make the check the presence of a PHB4 node in the device tree rather than an #ifdef? It might also be best to do this in platform_powernv.c, but that's a bit larger of a project.

Sep 17 2018, 6:25 PM · PowerPC

Aug 30 2018

nwhitehorn added a comment to D16794: Update PPC loader relocations to match the kernel..
In D16794#361563, @jhb wrote:

On closer examination, the loader doesn't actually modify the kernel or modules in place at all. Instead, this routine is used to apply relocations on copies of data. So for example, the code to parse module metadata copies individual records out of the kernel into a local variable on the stack, then asks the relocation to be applied to that local copy. This is a really good reason to honor the the 'data' and 'len' bounds as otherwise it allows writing to random crap on the stack. Also, we do explicitly ignore all relocations for the kernel itself, so it must be some relocation in tcp_rack.ko that wasn't handled before that is being handled now perhaps. I would have expected that to trigger a warning if so in the existing code though for an "unhandled relocation type".

Aug 30 2018, 12:07 AM

Aug 29 2018

nwhitehorn added a comment to D16794: Update PPC loader relocations to match the kernel..
In D16794#361523, @jhb wrote:

I believe since ppc is using Elf_Rela and that all of the relocations calculated absolute values to store at *where or *hwhere (vs using += or the like), the loader relocations just get overwritten by the kernel. I think when using Elf_Rel you might use the original value of *where as the addend in which case multiple passes of relocations is indeed destructive, but I don't think it is for Elf_Rela.

Aug 29 2018, 10:17 PM

Aug 24 2018

nwhitehorn committed rD52173: Update PGP key to one I still actually have..
Update PGP key to one I still actually have.
Aug 24 2018, 9:34 PM

Aug 19 2018

nwhitehorn requested changes to D16794: Update PPC loader relocations to match the kernel..

I just looked at the actual patch. The kernel sometimes (almost always on ppc64, less often on ppc32) relocates itself again post-loader to an address that loader does not know, so I think this does not solve the actual problem, or at least solves it in only a subset of cases. Processing these relocations in the kernel would solve the issue in all cases.

Aug 19 2018, 10:58 PM
nwhitehorn added a comment to D16794: Update PPC loader relocations to match the kernel..
In D16794#357383, @jhb wrote:

I added Justin and Nathan (who I meant to include from the start).

I believe PPC kernels are relocatable. I think they use ET_DYN instead of ET_EXEC (and there is a pending PR to fix that issue in libkvm as libkvm doesn't work on it currently as it only expects ET_EXEC for a kernel). Justin and/or Nathan can confirm.

Aug 19 2018, 7:18 PM

Aug 11 2018

nwhitehorn added a comment to D16653: libfdt: Update to 1.5.0.

Looks OK to me. One question: Do we want the various instances of fdt_check_header() in our code to be spelled FDT_RO_PROBE() now?

Aug 11 2018, 9:18 PM

Jul 31 2018

nwhitehorn accepted D16346: ofw_cpu: Add support for getting cpu clock via clock property.
Jul 31 2018, 8:40 PM

Jul 19 2018

nwhitehorn added a comment to D16346: ofw_cpu: Add support for getting cpu clock via clock property.

Since I'm not familiar with the clock code, where is EXT_RESOURCES defined? Can we just use that code unconditionally?

Jul 19 2018, 8:06 PM
nwhitehorn accepted D16232: Merge the md_page structs for AIM and Book-E into a single unioned struct.
Jul 19 2018, 8:05 PM

Jun 29 2018

nwhitehorn accepted D16071: Support multiple OPAL consoles, and don't crash if uart is not stdout.

Assuming you have tested this and it works, looks great.

Jun 29 2018, 7:18 PM

Jun 21 2018

nwhitehorn accepted D15932: Introduce PMCR-based cpufreq(4) driver, for IBM POWER9 systems.

Looks good to me.

Jun 21 2018, 4:57 AM
nwhitehorn requested changes to D15835: Set the console sc if it's not already set..
Jun 21 2018, 4:56 AM

Jun 20 2018

nwhitehorn accepted D15921: Attach dev.cpu nodes on SMT cores, using only the first found thread.

Approved if you fix the #if 0 bit.

Jun 20 2018, 4:59 AM

Jun 15 2018

nwhitehorn added inline comments to D15818: Add a delayed VT attachment for ofwfb.
Jun 15 2018, 9:41 PM
nwhitehorn added inline comments to D15818: Add a delayed VT attachment for ofwfb.
Jun 15 2018, 6:37 PM
nwhitehorn accepted D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.
Jun 15 2018, 6:33 PM
nwhitehorn added a comment to D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.

Don't you want strcmp() == 0?

Jun 15 2018, 6:19 PM
nwhitehorn added a comment to D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.

It's mildly stupid, since the universe of pci* isn't big, but I think I would prefer a check for "pci" || "pciex" to just checking the first three characters.

Jun 15 2018, 3:59 AM

Jun 11 2018

nwhitehorn added a comment to D15229: Allow run-time delayed attachment of devices.
In D15229#333064, @imp wrote:
In D15229#333038, @imp wrote:

The final option would be to do a variation on the prior option, but institutionalize it in DEVICE_ATTACH_LATE. It would be called just after interrupts were enabled for deferred work like this. It would cover the vast majority of driver independencies by giving a 'last' point. At that point, you return an error if you still weren't ready, and we'd loop while the number of devices returning an error was declining. It could largely replace config_intrhook.

I think this would work reasonably well for the general case here; the other suggestions would solve the case of smu(4), but there are other, simpler, ways to do that.

That said, I'm not sure what the advantage of a DEVICE_ATTACH_LATE() is over the mechanism originally proposed here or something like it except that it, as a side effect, delays until after interrupts -- which might not even be wanted, for example if the device in question is an interrupt controller.

If the device is an interrupt controller, you need to put it on a different pass. There's no way around that. But this isn't an interrupt controller, and interrupt controllers are special beasts that already have special handling in many places. Having a delayed attach for them is likely completely unacceptable so none of the proposals is appropriate for them.

Jun 11 2018, 6:39 PM
nwhitehorn added a comment to D15229: Allow run-time delayed attachment of devices.
In D15229#333038, @imp wrote:

The final option would be to do a variation on the prior option, but institutionalize it in DEVICE_ATTACH_LATE. It would be called just after interrupts were enabled for deferred work like this. It would cover the vast majority of driver independencies by giving a 'last' point. At that point, you return an error if you still weren't ready, and we'd loop while the number of devices returning an error was declining. It could largely replace config_intrhook.

Jun 11 2018, 6:25 PM

Jun 5 2018

nwhitehorn added a comment to D15229: Allow run-time delayed attachment of devices.

It's been another couple weeks. Any objections or approvals?

Jun 5 2018, 2:18 PM

Jun 4 2018

nwhitehorn accepted D15664: Add partition scheme for mpc85xx devices.
Jun 4 2018, 4:42 PM
nwhitehorn accepted D15660: Set kernelname in bootconfig to the kernel file.
Jun 4 2018, 4:00 AM

May 30 2018

nwhitehorn committed rS334372: If linebytes property is missing from the graphics device, assume no.
If linebytes property is missing from the graphics device, assume no
May 30 2018, 4:15 AM

May 26 2018

nwhitehorn accepted D15566: Make opal_pci driver work with POWER9.

This looks good to me, though I haven't tested on P8.

May 26 2018, 3:21 AM
nwhitehorn accepted D15581: Only crop the VPN on POWER4 and derivatives for TLBIE operations.

On POWER9, I think the lock is unnecessary (the ISA spec doesn't mention it).

May 26 2018, 12:29 AM

May 25 2018

nwhitehorn added a comment to D15229: Allow run-time delayed attachment of devices.

Any other thoughts? I'd like to get this in soon since it is blocking other things.

May 25 2018, 3:54 AM

May 20 2018

nwhitehorn updated the diff for D15229: Allow run-time delayed attachment of devices.

Fix style and spelling issues in man pages.

May 20 2018, 9:05 PM
nwhitehorn updated the diff for D15229: Allow run-time delayed attachment of devices.

Probe for pending devices at the end of each pass and after modules loaded. Add documentation.

May 20 2018, 7:24 PM
nwhitehorn committed rS333934: Fix build with PSERIES but not POWERNV defined..
Fix build with PSERIES but not POWERNV defined.
May 20 2018, 6:26 PM
nwhitehorn accepted D15492: Add support for the XIVE XICS emulation mode for POWER9 systems.
May 20 2018, 3:21 AM
nwhitehorn added inline comments to D15492: Add support for the XIVE XICS emulation mode for POWER9 systems.
May 20 2018, 2:50 AM
nwhitehorn added a comment to D15492: Add support for the XIVE XICS emulation mode for POWER9 systems.

See the comment on line 467 about powernv_smp_ap_init(). Otherwise, looks good.

May 20 2018, 2:03 AM

May 19 2018

nwhitehorn committed rS333897: Avoid writing to the frame buffer in early boot on PowerPC if the CPU's.
Avoid writing to the frame buffer in early boot on PowerPC if the CPU's
May 19 2018, 10:05 PM
nwhitehorn added inline comments to D15492: Add support for the XIVE XICS emulation mode for POWER9 systems.
May 19 2018, 8:40 PM
nwhitehorn accepted D15487: Add hypervisor trap handling, using HSRR0/HSRR1.

Approved if you also install it to EXC_HEA.

May 19 2018, 4:05 AM

May 18 2018

nwhitehorn accepted D15482: powerpc64: Ignore NVlink memory regions.
  1. Is there a document describing this that we can reference?

I was not able to find any documentation. Looking at the web, I found a patch[1] that documents it quickly in Linux, but it seems it was never accepted. I will ask internally.

May 18 2018, 6:14 PM
nwhitehorn added a comment to D15482: powerpc64: Ignore NVlink memory regions.

This looks good, even if the deice tree situation is a bit lamentable. Two questions:

  1. Is there a document describing this that we can reference?
  2. If this is just part of the PowerNV platform, maybe the code belongs in platform_powernv.c instead?
May 18 2018, 5:49 PM
nwhitehorn committed rS333804: Use sysrc(8) in the documentation rather than echoing things to rc.conf.
Use sysrc(8) in the documentation rather than echoing things to rc.conf
May 18 2018, 5:46 PM
nwhitehorn committed rS333803: Fix math error in the computation of the free space after the last partition.
Fix math error in the computation of the free space after the last partition
May 18 2018, 5:43 PM

May 14 2018

nwhitehorn added a comment to D15229: Allow run-time delayed attachment of devices.

Thanks -- I'll tweak the implementation to handle KLDs properly and write a man page, then update this diff.

May 14 2018, 8:50 PM
nwhitehorn committed rS333599: Final fix for alignment issues with the page table first patched with.
Final fix for alignment issues with the page table first patched with
May 14 2018, 4:01 AM