Page MenuHomeFreeBSD
Differential D30018

powerpc: Rework IPI message processing
ClosedPublic
Actions

Authored by jhibbits on Apr 28 2021, 1:36 AM.
Tags
None
Referenced Files
F158039021: D30018.diff
Wed, May 27, 7:42 PM
Unknown Object (File)
Thu, May 21, 2:46 PM
Unknown Object (File)
Mon, May 18, 10:32 PM
Unknown Object (File)
Sun, May 17, 12:51 AM
Unknown Object (File)
Sat, May 16, 9:12 PM
Unknown Object (File)
Sat, May 16, 5:50 PM
Unknown Object (File)
Thu, May 14, 7:52 AM
Unknown Object (File)
Mon, May 11, 10:36 PM
View All Files
Subscribers
imp

Details

Reviewers
bdragon
nwhitehorn
Group Reviewers
PowerPC
Commits
rG7ed09a6778d3: powerpc: Rework IPI message processing
Summary

There's no need to use a while loop in the IPI handler, the message list
is cached once and processed. Instead, since the existing code calls
ffs(), sort the handlers, and use a simple 'if' sequence.

Test Plan

Boot a SMP PowerPC system

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Apr 28 2021, 1:36 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 28 2021, 1:36 AM
jhibbits requested review of this revision.Apr 28 2021, 1:36 AM
Harbormaster completed remote builds in B38897: Diff 88287.Apr 28 2021, 1:36 AM
nwhitehorn accepted this revision.May 7 2021, 2:08 PM

Looks good to me, assuming it works anyway.

sys/powerpc/powerpc/mp_machdep.c
323

There's no switch anymore here.

This revision is now accepted and ready to land.May 7 2021, 2:08 PM
Closed by commit rG7ed09a6778d3: powerpc: Rework IPI message processing (authored by jhibbits). · Explain WhyMay 17 2021, 1:48 PM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rG7ed09a6778d3: powerpc: Rework IPI message processing.

Revision Contents
Changeset List

PathSize
sys/
powerpc/
powerpc/
68 lines

Diff 89352

View Options

sys/powerpc/powerpc/mp_machdep.c

Loading...