Page MenuHomeFreeBSD

bdragon (Brandon Bergren)
Animal

Projects

User Details

User Since
Jun 6 2018, 11:31 PM (142 w, 5 d)

Recent Activity

Today

bdragon committed R10:384ee7cc6e9e: [PowerPC] [PowerPCSPE] Fix multiple issues in fpsetmask(). (authored by bdragon).
[PowerPC] [PowerPCSPE] Fix multiple issues in fpsetmask().
Mon, Mar 1, 3:18 AM
bdragon committed R10:dd95b39235dd: [PowerPC64] Fix multiple issues in fpsetmask(). (authored by bdragon).
[PowerPC64] Fix multiple issues in fpsetmask().
Mon, Mar 1, 2:39 AM

Thu, Feb 25

bdragon committed R10:5001c579baff: [PowerPC64LE] pseries: Fix input buffering logic. (authored by bdragon).
[PowerPC64LE] pseries: Fix input buffering logic.
Thu, Feb 25, 8:52 PM

Thu, Feb 18

bdragon accepted D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Should be good for HEAD.

Thu, Feb 18, 9:59 PM · PowerPC

Mon, Feb 15

bdragon added a comment to D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Universe build went fine.

Mon, Feb 15, 3:21 PM · PowerPC

Fri, Feb 12

bdragon added a comment to D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Confirmed correct on an nvidia-based powerbook g4.

Fri, Feb 12, 4:59 AM · PowerPC

Thu, Feb 11

bdragon added a comment to D28580: powernv: Include NUMA locality information in the CPU topology.

On a deca-core POWER8 (SMT-8):

Presumably this is not a NUMA system? Or should we be seeing an additional layer in the topology?

Thu, Feb 11, 5:20 PM · PowerPC
bdragon added a comment to D28580: powernv: Include NUMA locality information in the CPU topology.

One possible problem with your assumptions is that arbitray cores may be GUARDed out for a given boot. So some cores may exist but be offline due to being deconfig'd during IPL. I'm not sure whether that would have an effect on this or not. The IPL logic will always deconfig the entire core, and therefore the entire thread/smt group when there is a fault entry. So the domains might have differing numbers of online cores.

When is this done in practice?

I'm not a huge fan of assuming that all domains have an identical number of cores, this assumption is just needed to use the somewhat simplistic smp_topo_*() functions. I'll revisit this and see if I can handle asymmetric domains without having to complicate the code too much.

Thu, Feb 11, 5:16 PM · PowerPC
bdragon added a comment to D28580: powernv: Include NUMA locality information in the CPU topology.

One possible problem with your assumptions is that arbitray cores may be GUARDed out for a given boot. So some cores may exist but be offline due to being deconfig'd during IPL. I'm not sure whether that would have an effect on this or not. The IPL logic will always deconfig the entire core, and therefore the entire thread/smt group when there is a fault entry. So the domains might have differing numbers of online cores.

Thu, Feb 11, 3:29 AM · PowerPC
bdragon added a comment to D28580: powernv: Include NUMA locality information in the CPU topology.

On a deca-core POWER8 (SMT-8):

Thu, Feb 11, 3:17 AM · PowerPC
bdragon added a comment to D28580: powernv: Include NUMA locality information in the CPU topology.

Since jhibbits tried for Talos II already, I will try on TYAN POWER8 instead.

Thu, Feb 11, 1:53 AM · PowerPC

Wed, Feb 10

bdragon changed the repository for D28580: powernv: Include NUMA locality information in the CPU topology from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.
Wed, Feb 10, 9:48 PM · PowerPC
bdragon added a comment to D28580: powernv: Include NUMA locality information in the CPU topology.

Will try this on Talos II.

Wed, Feb 10, 9:46 PM · PowerPC
bdragon committed R10:c48cbd0254de: powerpc64: Fix boot on virtual-mode OF (PowerMac G5) (authored by bdragon).
powerpc64: Fix boot on virtual-mode OF (PowerMac G5)
Wed, Feb 10, 3:44 AM
bdragon committed R10:187492ef639f: powerpc64: Fix boot on virtual-mode OF (PowerMac G5) (authored by bdragon).
powerpc64: Fix boot on virtual-mode OF (PowerMac G5)
Wed, Feb 10, 3:21 AM

Tue, Feb 9

bdragon added inline comments to D27475: ofwfb: fix boot on LE.
Tue, Feb 9, 4:33 PM · PowerPC

Sun, Feb 7

bdragon committed R10:d26f2a50ff48: powerpc64: Fix boot on virtual-mode OF (PowerMac G5) (authored by bdragon).
powerpc64: Fix boot on virtual-mode OF (PowerMac G5)
Sun, Feb 7, 10:15 PM

Thu, Feb 4

bdragon accepted D28475: mrsas: update man file and add driver to powerpc64le/GENERIC64LE.

Looks good.

Thu, Feb 4, 2:09 PM · PowerPC

Tue, Feb 2

bdragon committed R9:bd3ec6a73499: Trivial change: Remove duplicated paragraph. (authored by bdragon).
Trivial change: Remove duplicated paragraph.
Tue, Feb 2, 4:22 PM

Dec 30 2020

bdragon closed D27365: [POWERPC64LE] fix sysctl dev.opal_sensor.* on little-endian kernel.

Manually closing. Phab didn't pick up on the commit message due to a glitch in the documentation.

Dec 30 2020, 10:44 PM · PowerPC
bdragon accepted D27443: [POWERPC64LE] enable IPMI using OPAL bus.

Yes please.

Dec 30 2020, 10:13 PM · PowerPC

Dec 25 2020

bdragon committed R10:2ca7f72fee3c: MFC r364447: (authored by bdragon).
MFC r364447:
Dec 25 2020, 9:09 PM
bdragon committed R10:a6922d706d52: MFC r364447: (authored by bdragon).
MFC r364447:
Dec 25 2020, 9:09 PM
bdragon committed R10:efc7664f9ba1: MFC r361703: (authored by bdragon).
MFC r361703:
Dec 25 2020, 8:49 PM
bdragon committed R10:5c51ee529fd4: MFC r361024: (authored by bdragon).
MFC r361024:
Dec 25 2020, 8:40 PM

Dec 13 2020

bdragon closed D27453: [PowerPC] Floating-point exception trap followup.
Dec 13 2020, 3:59 AM · PowerPC
bdragon committed rS368604: [PowerPC] Floating-point exception trap followup.
[PowerPC] Floating-point exception trap followup
Dec 13 2020, 3:59 AM

Dec 12 2020

bdragon updated the diff for D27453: [PowerPC] Floating-point exception trap followup.

Addressing review comments.

Dec 12 2020, 11:47 PM · PowerPC

Dec 5 2020

bdragon added a comment to D27387: Add CFI start/end proc directives to arm64, i386, and ppc.

I'm fine with it on readthrough, I just hadn't gotten around to the actual tests. If it broke anything in powerpc land, it should be easy to fix. Thanks for tidying up the procedure annotations!

Dec 5 2020, 3:18 AM

Dec 3 2020

bdragon requested review of D27453: [PowerPC] Floating-point exception trap followup.
Dec 3 2020, 1:44 AM · PowerPC
bdragon closed D27431: [PowerPC64LE] Fix LE VSX/fpr interop.
Dec 3 2020, 1:40 AM · PowerPC
bdragon committed rS368290: [PowerPC64LE] Fix LE VSX/fpr interop.
[PowerPC64LE] Fix LE VSX/fpr interop
Dec 3 2020, 1:40 AM

Dec 1 2020

bdragon requested review of D27431: [PowerPC64LE] Fix LE VSX/fpr interop.
Dec 1 2020, 1:11 AM · PowerPC

Nov 23 2020

bdragon added a comment to D27293: lang/rust: Update to 1.48.0.

Doesn't apply on fresh ports tree:

C         devel/cargo-c/Makefile
>         rejected hunk @@ -2,6 +2,7 @@
C         lang/rust/files/patch-compiler_rustc__target_src_spec_i686__unknown__freebsd.rs
>         rejected hunk @@ -1,5 +1,5 @@
C         lang/rust/files/powerpc64-elfv1/patch-compiler_rustc__llvm_build.rs
>         rejected hunk @@ -1,5 +1,5 @@
C         lang/rust/files/powerpc64-elfv2/patch-compiler_rustc__target_src_abi_call_powerpc64.rs
>         rejected hunk @@ -1,5 +1,5 @@
C         lang/rust/files/powerpc64-elfv2/patch-compiler_rustc__target_src_spec_powerpc64__unknown__freebsd.rs
>         rejected hunk @@ -1,5 +1,5 @@
C         lang/rust/files/powerpc64le/patch-compiler_rustc__target_src_spec_mod.rs
>         rejected hunk @@ -1,5 +1,5 @@

Yeah, that's just a side effect of moved files. I worked around this on my end when patching by pre-moving the changed patch files.

I don't know why the uploaded patch isn't able to do this automatically, I think it might have just been uploaded with the wrong options or needs to be applied in a certain manner. It's not showing up as a delete/add like usual though.

Nov 23 2020, 1:00 AM
bdragon added a comment to D27293: lang/rust: Update to 1.48.0.

Doesn't apply on fresh ports tree:

C         devel/cargo-c/Makefile
>         rejected hunk @@ -2,6 +2,7 @@
C         lang/rust/files/patch-compiler_rustc__target_src_spec_i686__unknown__freebsd.rs
>         rejected hunk @@ -1,5 +1,5 @@
C         lang/rust/files/powerpc64-elfv1/patch-compiler_rustc__llvm_build.rs
>         rejected hunk @@ -1,5 +1,5 @@
C         lang/rust/files/powerpc64-elfv2/patch-compiler_rustc__target_src_abi_call_powerpc64.rs
>         rejected hunk @@ -1,5 +1,5 @@
C         lang/rust/files/powerpc64-elfv2/patch-compiler_rustc__target_src_spec_powerpc64__unknown__freebsd.rs
>         rejected hunk @@ -1,5 +1,5 @@
C         lang/rust/files/powerpc64le/patch-compiler_rustc__target_src_spec_mod.rs
>         rejected hunk @@ -1,5 +1,5 @@
Nov 23 2020, 12:57 AM

Nov 20 2020

bdragon abandoned D26699: [PowerPC64LE] (WIP) Cross-endian loader support.

We are going to go with the solution of compiling the entire loader in LE, so we don't have to deal with stuff like filesystem endianness etc.

Nov 20 2020, 5:47 PM · PowerPC
bdragon accepted D27257: [POWERPC] set default kernel config for powerpc64le and powerpcspe variants.

Fine by me.

Nov 20 2020, 4:49 PM · PowerPC

Nov 17 2020

bdragon accepted D27257: [POWERPC] set default kernel config for powerpc64le and powerpcspe variants.

Go for it. And yeah, go ahead and add the default powerpcspe kernel too.

Nov 17 2020, 5:46 PM · PowerPC

Nov 15 2020

bdragon accepted D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.

Looks good to me, and works nicely.

Nov 15 2020, 3:08 AM · PowerPC

Nov 13 2020

bdragon closed D27181: [PowerPC64LE] Radix fixes for LE.
Nov 13 2020, 4:56 PM · PowerPC
bdragon committed rS367644: [PowerPC64LE] Radix MMU fixes for LE..
[PowerPC64LE] Radix MMU fixes for LE.
Nov 13 2020, 4:56 PM
bdragon closed D26669: [PowerPC] Allow traversal of oversize OF properties.
Nov 13 2020, 4:50 PM · PowerPC
bdragon committed rS367643: [PowerPC] Allow traversal of oversize OF properties..
[PowerPC] Allow traversal of oversize OF properties.
Nov 13 2020, 4:50 PM

Nov 11 2020

bdragon added inline comments to D27181: [PowerPC64LE] Radix fixes for LE.
Nov 11 2020, 7:00 PM · PowerPC
bdragon requested review of D27181: [PowerPC64LE] Radix fixes for LE.
Nov 11 2020, 6:41 PM · PowerPC

Nov 8 2020

bdragon committed rS367496: [PowerPC] Fix powerpc64le boot after HPT superpages addition.
[PowerPC] Fix powerpc64le boot after HPT superpages addition
Nov 8 2020, 11:34 PM

Nov 6 2020

bdragon accepted D26605: Make powerpc use MAXARGS instead of hardcoding '10'.

No complaints here.

Nov 6 2020, 7:23 PM

Oct 31 2020

bdragon committed rS367238: Fix 32-bit build after r367209.
Fix 32-bit build after r367209
Oct 31 2020, 10:14 PM
bdragon committed rS367235: Fix 32-bit build after r367229..
Fix 32-bit build after r367229.
Oct 31 2020, 9:11 PM
bdragon added a watcher for linuxkpi: bdragon.
Oct 31 2020, 7:20 PM
bdragon added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Oct 31 2020, 7:19 PM

Oct 9 2020

bdragon added a comment to D26721: lang/rust: Update to 1.47.0.

Native build on powerpc64le worked after updating the paths in distinfo.

Oct 9 2020, 6:46 PM
bdragon added inline comments to D26721: lang/rust: Update to 1.47.0.
Oct 9 2020, 5:11 PM

Oct 8 2020

bdragon added a comment to D26711: [PowerPC64LE] Rust powerpc64le port.

OK, sure, I can reroll when 1.47 is out if you like.

Oct 8 2020, 5:13 PM · PowerPC

Oct 7 2020

bdragon requested review of D26711: [PowerPC64LE] Rust powerpc64le port.
Oct 7 2020, 7:33 PM · PowerPC

Oct 6 2020

bdragon updated the summary of D26699: [PowerPC64LE] (WIP) Cross-endian loader support.
Oct 6 2020, 7:10 PM · PowerPC
bdragon requested review of D26699: [PowerPC64LE] (WIP) Cross-endian loader support.
Oct 6 2020, 7:09 PM · PowerPC

Oct 4 2020

bdragon added a comment to D26669: [PowerPC] Allow traversal of oversize OF properties.

As I was writing the patch description, I realized that we actually need to be even more defensive about property name lengths, as we aren't blocking userland from setting properties up to OFIOCMAXNAME, which means someone could force an overflow of newname[] by setting a long property to something and then traversing it, which would force OF to corrupt the kernel stack using nextprop.

Oct 4 2020, 11:52 PM · PowerPC
bdragon requested review of D26669: [PowerPC] Allow traversal of oversize OF properties.
Oct 4 2020, 11:48 PM · PowerPC

Sep 30 2020

bdragon added a comment to D26605: Make powerpc use MAXARGS instead of hardcoding '10'.

I think you might be right, at most args[6] and args[7] would be subject to being pulled from the argument overflow area of the stack frame rather than the registers, assuming an 8 parameter syscall going through SYS___syscall, and they are filled in to args at their final positions instead of their raw positions.

Sep 30 2020, 8:05 PM
bdragon added a comment to D26605: Make powerpc use MAXARGS instead of hardcoding '10'.

I believe the necessity for this is for SYS___syscall. It burns *two* registers on 32-bit for alignment reasons.

Sep 30 2020, 4:15 PM
bdragon added a comment to D26605: Make powerpc use MAXARGS instead of hardcoding '10'.

and indeed, the code to do so still exists in cpu_fetch_syscall_args().

Sep 30 2020, 4:09 PM
bdragon added a comment to D26605: Make powerpc use MAXARGS instead of hardcoding '10'.

It does look like it was intentionally done at the time, due to there being code that explicitly copies in more arguments from the user stack frame if sy_narg goes over 8.

Sep 30 2020, 4:07 PM
bdragon added a comment to D26605: Make powerpc use MAXARGS instead of hardcoding '10'.

It comes from the Book-E syscall. See the changes to sys/powerpc/booke/trap.c in rS208453 -- it uses two more args than AIM.

Sep 30 2020, 3:58 PM

Sep 23 2020

bdragon added a reviewer for D26114: pmcstat: fix PPC kernel symbol resolution: bdragon.
Sep 23 2020, 11:40 PM · PowerPC
bdragon committed rS366063: [PowerPC64LE] Fix RTAS LE calls in pseries..
[PowerPC64LE] Fix RTAS LE calls in pseries.
Sep 23 2020, 4:09 AM
bdragon committed rD54514: Document __FreeBSD_version 1300116: Introduction of powerpc64le arch..
Document __FreeBSD_version 1300116: Introduction of powerpc64le arch.
Sep 23 2020, 4:06 AM
bdragon committed rS366062: __FreeBSD_version bump for introduction of the powerpc64le arch..
__FreeBSD_version bump for introduction of the powerpc64le arch.
Sep 23 2020, 3:19 AM
bdragon committed rS366061: arch(7): PowerPC64LE architecture definition.
arch(7): PowerPC64LE architecture definition
Sep 23 2020, 3:13 AM
bdragon closed D26379: [PowerPC] Fix multiple ntp configuration issues.
Sep 23 2020, 2:53 AM · PowerPC
bdragon committed rS366058: [PowerPC] Fix multiple ntp configuration issues.
[PowerPC] Fix multiple ntp configuration issues
Sep 23 2020, 2:53 AM
bdragon committed rS366057: [PowerPC64LE] Fix sleeping on POWER8..
[PowerPC64LE] Fix sleeping on POWER8.
Sep 23 2020, 2:28 AM
bdragon committed rS366056: [PowerPC64LE] Pass our byte order to the sqlite3 build..
[PowerPC64LE] Pass our byte order to the sqlite3 build.
Sep 23 2020, 2:17 AM
bdragon committed rS366055: [PowerPC64LE] libkvm powerpc64le support..
[PowerPC64LE] libkvm powerpc64le support.
Sep 23 2020, 2:11 AM
bdragon committed rS366054: [PowerPC64LE] Fix gdtoa configurations on LE..
[PowerPC64LE] Fix gdtoa configurations on LE.
Sep 23 2020, 2:06 AM
bdragon committed rS366053: [PowerPC64LE] Fix AP spinup on powernv..
[PowerPC64LE] Fix AP spinup on powernv.
Sep 23 2020, 1:56 AM
bdragon committed rS366051: [PowerPC64LE] Endian fix for opal_hmi.c.
[PowerPC64LE] Endian fix for opal_hmi.c
Sep 23 2020, 1:51 AM
bdragon committed rS366049: [PowerPC64LE] Get XIVE up and running..
[PowerPC64LE] Get XIVE up and running.
Sep 23 2020, 1:49 AM
bdragon committed rS366048: [PowerPC64LE] Endian fix for opal_dev.c..
[PowerPC64LE] Endian fix for opal_dev.c.
Sep 23 2020, 1:42 AM
bdragon committed rS366047: [PowerPC64LE] Endian fixes for opal_pci.c..
[PowerPC64LE] Endian fixes for opal_pci.c.
Sep 23 2020, 1:37 AM
bdragon committed rS366046: [PowerPC64LE] Implement endian-independent dword atomic PTE lock..
[PowerPC64LE] Implement endian-independent dword atomic PTE lock.
Sep 23 2020, 1:34 AM
bdragon committed rS366045: [PowerPC64LE] Fix endian conversion bugs in moea64..
[PowerPC64LE] Fix endian conversion bugs in moea64.
Sep 23 2020, 1:29 AM
bdragon committed rS366044: [PowerPC64LE] Add release building script for powerpc64le..
[PowerPC64LE] Add release building script for powerpc64le.
Sep 23 2020, 1:13 AM
bdragon committed rS366043: [PowerPC64LE] Initial GENERIC64LE kernel config..
[PowerPC64LE] Initial GENERIC64LE kernel config.
Sep 23 2020, 1:08 AM
bdragon committed rS366041: [PowerPC64LE] powernv ILE setup code..
[PowerPC64LE] powernv ILE setup code.
Sep 23 2020, 12:33 AM
bdragon committed rS366040: [PowerPC64LE] LE opal_call() implementation.
[PowerPC64LE] LE opal_call() implementation
Sep 23 2020, 12:29 AM
bdragon committed rS366039: [PowerPC64LE] Use a shared LIBC_ARCH for powerpc64le..
[PowerPC64LE] Use a shared LIBC_ARCH for powerpc64le.
Sep 23 2020, 12:22 AM
bdragon committed rS366038: [PowerPC64LE] Fix endianness issues in phyp_vscsi..
[PowerPC64LE] Fix endianness issues in phyp_vscsi.
Sep 23 2020, 12:14 AM
bdragon committed rS366037: [PowerPC64LE] Work around qemu TCG bug in mtmsrd emulation..
[PowerPC64LE] Work around qemu TCG bug in mtmsrd emulation.
Sep 23 2020, 12:09 AM
bdragon committed rS366036: [PowerPC64LE] Fix endianness issues in phyp and opal consoles..
[PowerPC64LE] Fix endianness issues in phyp and opal consoles.
Sep 23 2020, 12:07 AM
bdragon committed rS366035: [PowerPC64LE] Tell the hypervisor to switch interrupts to LE at CHRP attach..
[PowerPC64LE] Tell the hypervisor to switch interrupts to LE at CHRP attach.
Sep 23 2020, 12:03 AM

Sep 22 2020

bdragon committed rS366034: [PowerPC64LE] Fix endian dependence of ofw_real.c..
[PowerPC64LE] Fix endian dependence of ofw_real.c.
Sep 22 2020, 11:59 PM
bdragon committed rS366033: [PowerPC64LE] LE bringup work: locore / machdep / platform.
[PowerPC64LE] LE bringup work: locore / machdep / platform
Sep 22 2020, 11:56 PM
bdragon closed D26399: [PowerPC64LE] Set up powerpc.powerpc64le architecture.
Sep 22 2020, 11:54 PM · PowerPC
bdragon committed rS366032: [PowerPC64LE] Set up powerpc.powerpc64le architecture.
[PowerPC64LE] Set up powerpc.powerpc64le architecture
Sep 22 2020, 11:54 PM
bdragon added inline comments to D26399: [PowerPC64LE] Set up powerpc.powerpc64le architecture.
Sep 22 2020, 11:54 PM · PowerPC
bdragon committed rS366029: Tweak ficl definition from r365724.
Tweak ficl definition from r365724
Sep 22 2020, 11:27 PM
bdragon added a comment to D26471: Build debug kernels with -O2..

+1 from the PowerPC camp here.

Sep 22 2020, 7:51 PM

Sep 17 2020

bdragon added a comment to D26453: Hack to install symlinks atomically..

Regarding installing it multiple times, I suspect that something is going wrong in the target up to date logic for the library.

Sep 17 2020, 8:04 PM

Sep 16 2020

bdragon added inline comments to D26399: [PowerPC64LE] Set up powerpc.powerpc64le architecture.
Sep 16 2020, 2:38 AM · PowerPC